You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@weex.apache.org by wispy316 <gi...@git.apache.org> on 2017/04/07 02:41:17 UTC
[GitHub] incubator-weex pull request #229: add link from customer view to actual dom....
GitHub user wispy316 opened a pull request:
https://github.com/apache/incubator-weex/pull/229
add link from customer view to actual dom. copy from #203.
Android customer view has no link to the actual dom. so there is no way to access from the View to virtual dom ( we can call WXComponet.getDomObj() on the actual dom to get virtual dom).
Added public T getComponent(); to IRenderStatus , everything shines.
#203 always failed at travis with unkown reason. (failed at iOS and html5, but no relative change in this pr)
just create a branch from dev-0.12, then try again.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/wispy316/incubator-weex feature-android-irender-result
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/incubator-weex/pull/229.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #229
----
commit 87fb7947a6e739560d639276f053e9fee918a0a9
Author: \u884c\u4e45 <yi...@alibaba-inc.com>
Date: 2017-03-30T03:55:06Z
add link from customer view to actul dom.
commit 591d5b114b4c70d46481bc0e3a2bed1c298da890
Author: \u884c\u4e45 <yi...@alibaba-inc.com>
Date: 2017-04-05T03:32:38Z
Merge remote-tracking branch 'origin/0.12-dev' into feature-android-vdom-properties
commit b7e5b16c42ad78e68f7fbda53b1a565f87de7a24
Author: \u884c\u4e45 <yi...@alibaba-inc.com>
Date: 2017-04-05T03:37:47Z
[android] change getComponent from IRenderStatus to IRenderResult
commit 3c63aff536355a8e8652a76adfc430b1797a96b4
Author: \u884c\u4e45 <yi...@alibaba-inc.com>
Date: 2017-04-05T03:46:44Z
[android] the new IRenderResult interface.
commit 55954156492e339819a25dd52847ff038c6479d7
Author: \u884c\u4e45 <yi...@alibaba-inc.com>
Date: 2017-04-06T06:51:39Z
[android] just fire the CI run again.
commit 9fe977c166525b1f08607ac6edba57f5b43c200a
Author: \u884c\u4e45 <yi...@alibaba-inc.com>
Date: 2017-04-06T07:47:37Z
Merge remote-tracking branch 'origin/0.12-dev' into feature-android-vdom-properties
commit 1021fd4440ffb963c4f99f0ff3941b6f1277fcd0
Author: \u884c\u4e45 <yi...@alibaba-inc.com>
Date: 2017-04-07T02:34:41Z
Merge remote-tracking branch 'wispy/feature-android-vdom-properties' into feature-android-irender-result
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-weex pull request #229: add link from customer view to actual dom....
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/incubator-weex/pull/229
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-weex issue #229: add link from customer view to actual dom. copy f...
Posted by wispy316 <gi...@git.apache.org>.
Github user wispy316 commented on the issue:
https://github.com/apache/incubator-weex/pull/229
@zshshr @sospartan dear, have a look at this Pull request.
Ignore the failure of travis CI.
I have tried with empty modification, travis CI failed too. #247
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-weex issue #229: add link from customer view to actual dom. copy f...
Posted by weex-bot <gi...@git.apache.org>.
Github user weex-bot commented on the issue:
https://github.com/apache/incubator-weex/pull/229
<!--
0 failure:
1 warning: Potential BREAK C...
-->
<table>
<thead>
<tr>
<th width="50"></th>
<th width="100%" data-danger-table="true">Warnings</th>
</tr>
</thead>
<tbody><tr>
<td>:warning:</td>
<td>Potential BREAK CHANGE. Modify public in android/sdk/src/main/java/com/taobao/weex/ui/view/WXFrameLayout.java without metion it in commit message. You'd better add 'break change' in your commit log. </td>
</tr>
</tbody>
</table>
<p align="right">
Generated by :no_entry_sign: <a href="http://github.com/danger/danger-js/">dangerJS</a>
</p>
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---