You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@poi.apache.org by bu...@apache.org on 2016/07/04 03:06:31 UTC

[Bug 59789] Comments not shifted when row shifting

https://bz.apache.org/bugzilla/show_bug.cgi?id=59789

Javen O'Neal <on...@apache.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |RESOLVED
         Resolution|---                         |FIXED

--- Comment #1 from Javen O'Neal <on...@apache.org> ---
HSSFComment shifting was already done inside the main for-loop, but had pretty
terrible performance because it searched the drawing patriarch for all comments
for ever row in the shift range.

Assuming all NoteRecords are HSSFComments, we can move the comment shifting
that's done inside the main for-loop outside so that only one search for
HSSFComments in the drawing patriarch is necessary.

Applied in r1751198.

-- 
You are receiving this mail because:
You are the assignee for the bug.

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@poi.apache.org
For additional commands, e-mail: dev-help@poi.apache.org