You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@tamaya.apache.org by William Lieurance <wi...@namikoda.com> on 2018/01/17 06:49:26 UTC
Recent test failures with Extensions
Hi there.
I've been looking into the recent test failures on the extensions builds [1] and I think I've got a pretty good handle on it. Check out https://github.com/peculater/incubator-tamaya-extensions/compare/NOJIRA-test-idempotency?w=1 for what I think is happening there. There are two fixes described in that commit:
First, the CDIAwareServiceContextTest now uses the same Arquillian
backing as various other successful tests.
Second, the ConfiguredVetoExtensionTest is now more idempotent with respect
to the ConfigurationProvider. Previously, it would leave the shared
ConfigurationProvider pointing at the mocked ConfigurationContext, which
caused other tests (specifically ConfiguredBTest) which rely on a valid
ConfigurationContext to fail.
After making these changes, the tests run successfully for me consistently. I don't see a jira ticket for the errors, but am happy to update my commit messages if I missed one. I also probably need to sign whatever contributor forms are relevant for this project.
Thoughts?
--William Lieurance
1. Example from yesterday: https://builds.apache.org/view/S-Z/view/Tamaya/job/Tamaya-Extensions-Master/1317/org.apache.tamaya.ext$tamaya-cdi/#showFailuresLink
Re: Recent test failures with Extensions
Posted by Werner Keil <we...@gmail.com>.
Great stuff. Glad to see the Tamaya team grow. And with a company that
seems to deal with configuration a lot it might also broaden the user base.
If that continues it may also increase chances of graduation.
Cheers,
Werner
On Tue, Jan 23, 2018 at 11:23 PM, P. Ottlinger <po...@apache.org>
wrote:
> Am 21.01.2018 um 01:32 schrieb William Lieurance:
> > I'm super happy to wander through to code or help out with jira issues
> as I find them. I'll make comments as I go? TAMAYA-296 seemed simple
> enough, so I put in some patches that I think cover what's needed.
>
>
> @William:
> will merge your patches tomorrow.
>
> Thanks for scanning the Jira :-)
>
> Cheers,
> Phil
>
Re: Recent test failures with Extensions
Posted by "P. Ottlinger" <po...@apache.org>.
Am 21.01.2018 um 01:32 schrieb William Lieurance:
> I'm super happy to wander through to code or help out with jira issues as I find them. I'll make comments as I go? TAMAYA-296 seemed simple enough, so I put in some patches that I think cover what's needed.
@William:
will merge your patches tomorrow.
Thanks for scanning the Jira :-)
Cheers,
Phil
Re: Recent test failures with Extensions
Posted by William Lieurance <wi...@namikoda.com>.
Yay! Glad I could help out.
I'm super happy to wander through to code or help out with jira issues as I find them. I'll make comments as I go? TAMAYA-296 seemed simple enough, so I put in some patches that I think cover what's needed.
Yes, I'm on the developer list. Reading through the last couple months of archives is really informative.
Thanks!
William
________________________________________
From: P. Ottlinger <po...@apache.org>
Sent: Saturday, January 20, 2018 2:38:28 PM
To: William Lieurance
Cc: dev@tamaya.incubator.apache.org
Subject: Re: Recent test failures with Extensions
Dear William,
thanks for signing all the legal documents - I've applied the patch and
resolved TAMAYA-324.
Am 18.01.2018 um 10:39 schrieb William Lieurance:
> Otherwise I'm excited about JSR-382 and Tamaya's server option. I don't
> have any pressing issues currently, but am happy to help with some of
> the backlog. I've got a 2018 goal to contribute more to projects I
> like. Any places you'd recommend I start?
Apart from more tests of all modules and "real world" applications that
might yield new bug tickets we are generally happy about people with
interest in Tamaya.
So - browse the code, find stuff that needs enhancements or more tests
:-) .... give feedback.
Are you already subscribed to our developer mailing list?
Cheers,
Phil
Re: Recent test failures with Extensions
Posted by "P. Ottlinger" <po...@apache.org>.
Dear William,
thanks for signing all the legal documents - I've applied the patch and
resolved TAMAYA-324.
Am 18.01.2018 um 10:39 schrieb William Lieurance:
> Otherwise I'm excited about JSR-382 and Tamaya's server option. I don't
> have any pressing issues currently, but am happy to help with some of
> the backlog. I've got a 2018 goal to contribute more to projects I
> like. Any places you'd recommend I start?
Apart from more tests of all modules and "real world" applications that
might yield new bug tickets we are generally happy about people with
interest in Tamaya.
So - browse the code, find stuff that needs enhancements or more tests
:-) .... give feedback.
Are you already subscribed to our developer mailing list?
Cheers,
Phil
Re: Recent test failures with Extensions
Posted by William Lieurance <wi...@namikoda.com>.
Hi Phil,
I've updated my branch and uploaded a patch to TAMAYA-324. I've also submitted my ICLA to secretary@apache.org. Hopefully that's sufficient. :-)
Otherwise I'm excited about JSR-382 and Tamaya's server option. I don't have any pressing issues currently, but am happy to help with some of the backlog. I've got a 2018 goal to contribute more to projects I like. Any places you'd recommend I start?
--William
________________________________
From: P. Ottlinger <po...@apache.org>
Sent: Wednesday, January 17, 2018 3:55 PM
To: William Lieurance
Cc: dev@tamaya.incubator.apache.org
Subject: Re: Recent test failures with Extensions
Hi William,
Am 17.01.2018 um 07:49 schrieb William Lieurance:
> I've been looking into the recent test failures on the extensions
builds [1] and I think I've got a pretty good handle on it. Check out
https://github.com/peculater/incubator-tamaya-extensions/compare/NOJIRA-test-idempotency?w=1
for what I think is happening there. There are two fixes described in
that commit
thanks for your help and great contribution - I've created
https://issues.apache.org/jira/browse/TAMAYA-324
for the failures and verified that your patches work fine as I had one
of those "older Ubuntu LTS" environment that showed the problem.
Strangely only some ASF-Jenkins nodes had the problems resulting in
flaky builds.
Please adapt your merge request accordingly and we will be able to merge
it into the extensions module.
If you do not have a signed contributor agreement ASF is pleased to
receive one - more info:
https://www.apache.org/licenses/
https://www.apache.org/licenses/icla.pdf
Thanks again for your help -
are there any other issues you have with Tamaya?
We are always looking for new contributors ;-)
Cheers,
Phil
Re: Recent test failures with Extensions
Posted by "P. Ottlinger" <po...@apache.org>.
Hi William,
Am 17.01.2018 um 07:49 schrieb William Lieurance:
> I've been looking into the recent test failures on the extensions
builds [1] and I think I've got a pretty good handle on it. Check out
https://github.com/peculater/incubator-tamaya-extensions/compare/NOJIRA-test-idempotency?w=1
for what I think is happening there. There are two fixes described in
that commit
thanks for your help and great contribution - I've created
https://issues.apache.org/jira/browse/TAMAYA-324
for the failures and verified that your patches work fine as I had one
of those "older Ubuntu LTS" environment that showed the problem.
Strangely only some ASF-Jenkins nodes had the problems resulting in
flaky builds.
Please adapt your merge request accordingly and we will be able to merge
it into the extensions module.
If you do not have a signed contributor agreement ASF is pleased to
receive one - more info:
https://www.apache.org/licenses/
https://www.apache.org/licenses/icla.pdf
Thanks again for your help -
are there any other issues you have with Tamaya?
We are always looking for new contributors ;-)
Cheers,
Phil