You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@dolphinscheduler.apache.org by GitBox <gi...@apache.org> on 2022/06/29 06:03:32 UTC
[GitHub] [dolphinscheduler] zhongjiajie commented on a diff in pull request #10660: Doc change datasource
zhongjiajie commented on code in PR #10660:
URL: https://github.com/apache/dolphinscheduler/pull/10660#discussion_r909227962
##########
docs/docs/en/guide/datasource/redshift.md:
##########
@@ -0,0 +1,22 @@
+# Amazon Redshift
+
+
+
+## Datasource Parameters
+
+| **Datasource** | **Description** |
+| --- | --- |
+| Datasource | Select Redshift. |
+| Datasource Name | Enter the name of the datasource. |
+| Description | Enter a description of the datasource. |
+| IP/Host Name | Enter the Redshift service IP. |
+| Port | Enter the Redshift service port. |
+| Username | Set the username for Redshift connection. |
+| Password | Set the password for Redshift connection. |
+| Database Name | Enter the database name of the Redshift connection. |
+| jdbc connect parameters | Parameter settings for Redshift connection, in JSON format. |
+
+
Review Comment:
```suggestion
```
remove the unnessary blank line
##########
docs/docs/en/guide/datasource/oracle.md:
##########
@@ -0,0 +1,22 @@
+# Oracle
+
+
+
+## Datasource Parameters
+
+| **Datasource** | **Description** |
+| --- | --- |
+| Datasource | Select Oracle. |
+| Datasource Name | Enter the name of the datasource. |
+| Description | Enter a description of the datasource. |
+| IP/Host Name | Enter the Oracle service IP. |
+| Port | Enter the Oracle service port. |
+| Username | Set the username for Oracle connection. |
+| Password | Set the password for Oracle connection. |
+| Database Name | Enter the database name of the Oracle connection. |
+| jdbc connect parameters | Parameter settings for Oracle connection, in JSON format. |
+
+## Native Supported
+
+
Review Comment:
remove the unnessary blank line
##########
docs/docs/en/guide/datasource/oracle.md:
##########
@@ -0,0 +1,22 @@
+# Oracle
+
+
+
+## Datasource Parameters
+
+| **Datasource** | **Description** |
+| --- | --- |
+| Datasource | Select Oracle. |
+| Datasource Name | Enter the name of the datasource. |
+| Description | Enter a description of the datasource. |
+| IP/Host Name | Enter the Oracle service IP. |
+| Port | Enter the Oracle service port. |
+| Username | Set the username for Oracle connection. |
+| Password | Set the password for Oracle connection. |
+| Database Name | Enter the database name of the Oracle connection. |
+| jdbc connect parameters | Parameter settings for Oracle connection, in JSON format. |
+
+## Native Supported
+
+
Review Comment:
```suggestion
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org