You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by GitBox <gi...@apache.org> on 2020/02/27 02:05:39 UTC
[GitHub] [flink] JingsongLi opened a new pull request #11229:
[FLINK-16265][table][csv] CsvTableSinkFactoryBase should compare
LogicalTypes instead of TableSchema
JingsongLi opened a new pull request #11229: [FLINK-16265][table][csv] CsvTableSinkFactoryBase should compare LogicalTypes instead of TableSchema
URL: https://github.com/apache/flink/pull/11229
## What is the purpose of the change
```
- name: TableSourceSink
type: source-sink-table
schema:
- name: IntegerField
type: INT
- name: StringField
type: VARCHAR
- name: TimestampField
type: TIMESTAMP
connector:
type: filesystem
format:
type: csv
fields:
- name: IntegerField
type: INT
- name: StringField
type: VARCHAR
- name: TimestampField
type: TIMESTAMP
line-delimiter: "\n"
comment-prefix: "#"
```
Table like this will fail in SQL-CLI.
The root cause is we will convert the properties into CatalogTableImpl and then convert into properties again. The schema type properties will use new type systems then which is not equal to the legacy types due to conversion classes.
## Brief change log
We should avoid compare TableSchema in `CsvTableSinkFactoryBase.createTableSink`.
## Verifying this change
`LocalExecutorITCase`
## Does this pull request potentially affect one of the following parts:
- Dependencies (does it add or upgrade a dependency): (yes / **no**)
- The public API, i.e., is any changed class annotated with `@Public(Evolving)`: (yes / **no**)
- The serializers: (yes / **no** / don't know)
- The runtime per-record code paths (performance sensitive): (yes / **no** / don't know)
- Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Kubernetes/Yarn/Mesos, ZooKeeper: (yes / **no** / don't know)
- The S3 file system connector: (yes / **no** / don't know)
## Documentation
- Does this pull request introduce a new feature? (yes / **no**)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] flinkbot edited a comment on issue #11229:
[FLINK-16265][table][csv] CsvTableSinkFactoryBase should compare
LogicalTypes instead of TableSchema
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on issue #11229: [FLINK-16265][table][csv] CsvTableSinkFactoryBase should compare LogicalTypes instead of TableSchema
URL: https://github.com/apache/flink/pull/11229#issuecomment-591740777
Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help the community
to review your pull request. We will use this comment to track the progress of the review.
## Automated Checks
Last check on commit dbb73eabacff825c8c353a3196ffab14ecae4f53 (Fri Feb 28 21:48:35 UTC 2020)
**Warnings:**
* No documentation files were touched! Remember to keep the Flink docs up to date!
<sub>Mention the bot in a comment to re-run the automated checks.</sub>
## Review Progress
* ❓ 1. The [description] looks good.
* ❓ 2. There is [consensus] that the contribution should go into to Flink.
* ❓ 3. Needs [attention] from.
* ❓ 4. The change fits into the overall [architecture].
* ❓ 5. Overall code [quality] is good.
Please see the [Pull Request Review Guide](https://flink.apache.org/contributing/reviewing-prs.html) for a full explanation of the review process.<details>
The Bot is tracking the review progress through labels. Labels are applied according to the order of the review items. For consensus, approval by a Flink committer of PMC member is required <summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot approve description` to approve one or more aspects (aspects: `description`, `consensus`, `architecture` and `quality`)
- `@flinkbot approve all` to approve all aspects
- `@flinkbot approve-until architecture` to approve everything until `architecture`
- `@flinkbot attention @username1 [@username2 ..]` to require somebody's attention
- `@flinkbot disapprove architecture` to remove an approval you gave earlier
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] flinkbot edited a comment on issue #11229:
[FLINK-16265][table][csv] CsvTableSinkFactoryBase should compare
LogicalTypes instead of TableSchema
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on issue #11229: [FLINK-16265][table][csv] CsvTableSinkFactoryBase should compare LogicalTypes instead of TableSchema
URL: https://github.com/apache/flink/pull/11229#issuecomment-591745212
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "dbb73eabacff825c8c353a3196ffab14ecae4f53",
"status" : "FAILURE",
"url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=5659",
"triggerID" : "dbb73eabacff825c8c353a3196ffab14ecae4f53",
"triggerType" : "PUSH"
}, {
"hash" : "dbb73eabacff825c8c353a3196ffab14ecae4f53",
"status" : "SUCCESS",
"url" : "https://travis-ci.com/flink-ci/flink/builds/150764667",
"triggerID" : "dbb73eabacff825c8c353a3196ffab14ecae4f53",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* dbb73eabacff825c8c353a3196ffab14ecae4f53 Travis: [SUCCESS](https://travis-ci.com/flink-ci/flink/builds/150764667) Azure: [FAILURE](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=5659)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] flinkbot commented on issue #11229:
[FLINK-16265][table][csv] CsvTableSinkFactoryBase should compare
LogicalTypes instead of TableSchema
Posted by GitBox <gi...@apache.org>.
flinkbot commented on issue #11229: [FLINK-16265][table][csv] CsvTableSinkFactoryBase should compare LogicalTypes instead of TableSchema
URL: https://github.com/apache/flink/pull/11229#issuecomment-591740777
Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help the community
to review your pull request. We will use this comment to track the progress of the review.
## Automated Checks
Last check on commit 8500097aafb704a3c2643a504a1c799e11f1d8ac (Thu Feb 27 02:08:26 UTC 2020)
**Warnings:**
* No documentation files were touched! Remember to keep the Flink docs up to date!
<sub>Mention the bot in a comment to re-run the automated checks.</sub>
## Review Progress
* ❓ 1. The [description] looks good.
* ❓ 2. There is [consensus] that the contribution should go into to Flink.
* ❓ 3. Needs [attention] from.
* ❓ 4. The change fits into the overall [architecture].
* ❓ 5. Overall code [quality] is good.
Please see the [Pull Request Review Guide](https://flink.apache.org/contributing/reviewing-prs.html) for a full explanation of the review process.<details>
The Bot is tracking the review progress through labels. Labels are applied according to the order of the review items. For consensus, approval by a Flink committer of PMC member is required <summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot approve description` to approve one or more aspects (aspects: `description`, `consensus`, `architecture` and `quality`)
- `@flinkbot approve all` to approve all aspects
- `@flinkbot approve-until architecture` to approve everything until `architecture`
- `@flinkbot attention @username1 [@username2 ..]` to require somebody's attention
- `@flinkbot disapprove architecture` to remove an approval you gave earlier
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] flinkbot edited a comment on issue #11229:
[FLINK-16265][table][csv] CsvTableSinkFactoryBase should compare
LogicalTypes instead of TableSchema
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on issue #11229: [FLINK-16265][table][csv] CsvTableSinkFactoryBase should compare LogicalTypes instead of TableSchema
URL: https://github.com/apache/flink/pull/11229#issuecomment-591745212
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "dbb73eabacff825c8c353a3196ffab14ecae4f53",
"status" : "FAILURE",
"url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=5659",
"triggerID" : "dbb73eabacff825c8c353a3196ffab14ecae4f53",
"triggerType" : "PUSH"
}, {
"hash" : "dbb73eabacff825c8c353a3196ffab14ecae4f53",
"status" : "PENDING",
"url" : "https://travis-ci.com/flink-ci/flink/builds/150764667",
"triggerID" : "dbb73eabacff825c8c353a3196ffab14ecae4f53",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* dbb73eabacff825c8c353a3196ffab14ecae4f53 Travis: [PENDING](https://travis-ci.com/flink-ci/flink/builds/150764667) Azure: [FAILURE](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=5659)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] flinkbot edited a comment on issue #11229:
[FLINK-16265][table][csv] CsvTableSinkFactoryBase should compare
LogicalTypes instead of TableSchema
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on issue #11229: [FLINK-16265][table][csv] CsvTableSinkFactoryBase should compare LogicalTypes instead of TableSchema
URL: https://github.com/apache/flink/pull/11229#issuecomment-591745212
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "dbb73eabacff825c8c353a3196ffab14ecae4f53",
"status" : "PENDING",
"url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=5659",
"triggerID" : "dbb73eabacff825c8c353a3196ffab14ecae4f53",
"triggerType" : "PUSH"
}, {
"hash" : "dbb73eabacff825c8c353a3196ffab14ecae4f53",
"status" : "PENDING",
"url" : "https://travis-ci.com/flink-ci/flink/builds/150764667",
"triggerID" : "dbb73eabacff825c8c353a3196ffab14ecae4f53",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* dbb73eabacff825c8c353a3196ffab14ecae4f53 Travis: [PENDING](https://travis-ci.com/flink-ci/flink/builds/150764667) Azure: [PENDING](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=5659)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] flinkbot commented on issue #11229:
[FLINK-16265][table][csv] CsvTableSinkFactoryBase should compare
LogicalTypes instead of TableSchema
Posted by GitBox <gi...@apache.org>.
flinkbot commented on issue #11229: [FLINK-16265][table][csv] CsvTableSinkFactoryBase should compare LogicalTypes instead of TableSchema
URL: https://github.com/apache/flink/pull/11229#issuecomment-591745212
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "dbb73eabacff825c8c353a3196ffab14ecae4f53",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "dbb73eabacff825c8c353a3196ffab14ecae4f53",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* dbb73eabacff825c8c353a3196ffab14ecae4f53 UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] JingsongLi merged pull request #11229:
[FLINK-16265][table][csv] CsvTableSinkFactoryBase should compare
LogicalTypes instead of TableSchema
Posted by GitBox <gi...@apache.org>.
JingsongLi merged pull request #11229: [FLINK-16265][table][csv] CsvTableSinkFactoryBase should compare LogicalTypes instead of TableSchema
URL: https://github.com/apache/flink/pull/11229
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services