[GitHub] [arrow] nealrichardson commented on a diff in pull request #12973: ARROW-16297: [R] Improve detection of ARROW_*_URL variables for offline build

[GitBox <gi...@apache.org>]

nealrichardson commented on code in PR #12973:
URL: https://github.com/apache/arrow/pull/12973#discussion_r857605477


##########
r/tools/nixlibs.R:
##########
@@ -462,27 +471,41 @@ turn_off_all_optional_features <- function(env_var_list) {
   replace(env_var_list, names(turn_off), turn_off)
 }
 
+get_component_names <- function() {
+  if (!isTRUE(Sys.which("bash") != "")) {
+    stop("nixlibs.R requires bash to be installed and available in your PATH")
+  }
+  deps_bash <- normalizePath("tools/download_dependencies_R.sh", mustWork = TRUE)

Review Comment:
   Do you need to normalizePath? Relative path should be fine here



##########
r/tools/nixlibs.R:
##########
@@ -435,13 +435,22 @@ turn_off_all_optional_features <- function(env_var_list) {
   # Because these are done as environment variables (as opposed to build flags),
   # setting these to "OFF" overrides any previous setting. We don't need to
   # check the existing value.
+  # Some features turn on other features (e.g. engine -> substrait -> protobuf),

Review Comment:
   ```suggestion
     # Some features turn on other features (e.g. substrait -> protobuf),
   ```



##########
r/tools/nixlibs.R:
##########
@@ -435,13 +435,22 @@ turn_off_all_optional_features <- function(env_var_list) {
   # Because these are done as environment variables (as opposed to build flags),
   # setting these to "OFF" overrides any previous setting. We don't need to
   # check the existing value.
+  # Some features turn on other features (e.g. engine -> substrait -> protobuf),
+  # So the list of things to turn off is long. See:
+  # https://github.com/apache/arrow/blob/master/cpp/cmake_modules/ThirdpartyToolchain.cmake#L275
   turn_off <- c(
     "ARROW_MIMALLOC" = "OFF",
     "ARROW_JEMALLOC" = "OFF",
     "ARROW_JSON" = "OFF",
     "ARROW_PARQUET" = "OFF", # depends on thrift
     "ARROW_DATASET" = "OFF", # depends on parquet
     "ARROW_S3" = "OFF",
+    "ARROW_GCS" = "OFF",
+    "ARROW_WITH_GOOGLE_CLOUD_CPP" = "OFF",
+    "ARROW_WITH_NLOHMANN_JSON" = "OFF",
+    "ARROW_ENGINE" = "OFF",
+    "ARROW_WITH_SUBSTRAIT" = "OFF",

Review Comment:
   ARROW_ENGINE was just renamed
   
   ```suggestion
       "ARROW_SUBSTRAIT" = "OFF",
   ```



##########
r/tools/nixlibs.R:
##########
@@ -435,13 +435,22 @@ turn_off_all_optional_features <- function(env_var_list) {
   # Because these are done as environment variables (as opposed to build flags),
   # setting these to "OFF" overrides any previous setting. We don't need to
   # check the existing value.
+  # Some features turn on other features (e.g. engine -> substrait -> protobuf),
+  # So the list of things to turn off is long. See:
+  # https://github.com/apache/arrow/blob/master/cpp/cmake_modules/ThirdpartyToolchain.cmake#L275
   turn_off <- c(
     "ARROW_MIMALLOC" = "OFF",
     "ARROW_JEMALLOC" = "OFF",
     "ARROW_JSON" = "OFF",
     "ARROW_PARQUET" = "OFF", # depends on thrift
     "ARROW_DATASET" = "OFF", # depends on parquet
     "ARROW_S3" = "OFF",
+    "ARROW_GCS" = "OFF",

Review Comment:
   These already are OFF by default. Why do we need them OFF here too?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org