You are viewing a plain text version of this content. The canonical link for it is here.
Posted to jira@arrow.apache.org by "David Li (Jira)" <ji...@apache.org> on 2022/04/22 20:06:00 UTC
[jira] [Resolved] (ARROW-16280) [C++] Avoid copying shared_ptr in Expression::type()
[ https://issues.apache.org/jira/browse/ARROW-16280?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
David Li resolved ARROW-16280.
------------------------------
Fix Version/s: 8.0.0
Resolution: Fixed
Issue resolved by pull request 12957
[https://github.com/apache/arrow/pull/12957]
> [C++] Avoid copying shared_ptr in Expression::type()
> ----------------------------------------------------
>
> Key: ARROW-16280
> URL: https://issues.apache.org/jira/browse/ARROW-16280
> Project: Apache Arrow
> Issue Type: Sub-task
> Components: C++
> Reporter: Tobias Zagorni
> Assignee: Tobias Zagorni
> Priority: Major
> Labels: pull-request-available
> Fix For: 8.0.0
>
> Time Spent: 50m
> Remaining Estimate: 0h
>
> Split off from ARROW-16161, since this is a fairly straightforward fix and completely independent of ExecBatch.
> Expression::type() currently copies a shared_ptr<DataType>, while the return value is often used directly. We can avoid copying the shared_ptr, by returning a reference to it. This reduces thread contention on these shared_ptrs (ARROW-16161).
--
This message was sent by Atlassian Jira
(v8.20.7#820007)