You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by MaxGekk <gi...@git.apache.org> on 2018/04/17 19:23:22 UTC

[GitHub] spark pull request #21089: [SPARK-24004] Test of from_json for non-root MapT...

GitHub user MaxGekk opened a pull request:

    https://github.com/apache/spark/pull/21089

    [SPARK-24004] Test of from_json for non-root MapType

    ## What changes were proposed in this pull request?
    
    New test checks that from_json is able to parse json contains MapType as a value type of struct fields. The test required adding of the equals and hashCode methods to ArrayBasedMapData to compare returned result to expected value.
    
    ## How was this patch tested?
    
    Added comparison tests for ArrayBasedMapData and a test for from_json.


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/MaxGekk/spark-1 from_json-map-tests

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/spark/pull/21089.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #21089
    
----
commit d91d93936ce1c12765dffdbf2fe773585dd39eae
Author: Maxim Gekk <ma...@...>
Date:   2018-04-17T18:15:44Z

    Added a test for checking from_json: json -> struct of map

commit 428c6ba93202bf3235667794f9f8055c432733e1
Author: Maxim Gekk <ma...@...>
Date:   2018-04-17T18:16:54Z

    Added a test for comparison of ArrayBasedMapData

commit 58d1f7e41883b5e8924eca83bcf72deedadaf0ef
Author: Maxim Gekk <ma...@...>
Date:   2018-04-17T19:01:00Z

    Implemented the equals and hashCode methods of ArrayBasedMapData

commit 4391b0a94e7ddbf53043e6723b7e6e63655f5759
Author: Maxim Gekk <ma...@...>
Date:   2018-04-17T19:21:49Z

    Improving test title

----


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] spark issue #21089: [SPARK-24004] Test of from_json for non-root MapType

Posted by MaxGekk <gi...@git.apache.org>.
Github user MaxGekk commented on the issue:

    https://github.com/apache/spark/pull/21089
  
    @HyukjinKwon I cannot find tests for not-root map types in JsonFunctionsSuite and JsonExpressionsSuite. I am going to propose a PR for supporting the map type as root type in from_json. The tests for non-root map type are not related to the PR and I want to extract them to separate PR.  


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] spark issue #21089: [SPARK-24004] Test of from_json for non-root MapType

Posted by SparkQA <gi...@git.apache.org>.
Github user SparkQA commented on the issue:

    https://github.com/apache/spark/pull/21089
  
    **[Test build #89471 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/89471/testReport)** for PR 21089 at commit [`1458077`](https://github.com/apache/spark/commit/1458077cf6817701d74fcebd2e83ab6a62889fd8).


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] spark issue #21089: [SPARK-24004] Test of from_json for non-root MapType

Posted by SparkQA <gi...@git.apache.org>.
Github user SparkQA commented on the issue:

    https://github.com/apache/spark/pull/21089
  
    **[Test build #89471 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/89471/testReport)** for PR 21089 at commit [`1458077`](https://github.com/apache/spark/commit/1458077cf6817701d74fcebd2e83ab6a62889fd8).
     * This patch **fails Spark unit tests**.
     * This patch merges cleanly.
     * This patch adds no public classes.


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] spark issue #21089: [SPARK-24004] Test of from_json for non-root MapType

Posted by MaxGekk <gi...@git.apache.org>.
Github user MaxGekk commented on the issue:

    https://github.com/apache/spark/pull/21089
  
    The PR was closed because the equals and hashCode method were explicitly deleted in the commit: https://github.com/apache/spark/commit/3e4e868c850e6b6da2c0d005167316e1abdc7460


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] spark issue #21089: [SPARK-24004] Test of from_json for non-root MapType

Posted by AmplabJenkins <gi...@git.apache.org>.
Github user AmplabJenkins commented on the issue:

    https://github.com/apache/spark/pull/21089
  
    Merged build finished. Test FAILed.


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] spark issue #21089: [SPARK-24004] Test of from_json for non-root MapType

Posted by SparkQA <gi...@git.apache.org>.
Github user SparkQA commented on the issue:

    https://github.com/apache/spark/pull/21089
  
    **[Test build #89469 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/89469/testReport)** for PR 21089 at commit [`4391b0a`](https://github.com/apache/spark/commit/4391b0a94e7ddbf53043e6723b7e6e63655f5759).


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] spark issue #21089: [SPARK-24004] Test of from_json for non-root MapType

Posted by AmplabJenkins <gi...@git.apache.org>.
Github user AmplabJenkins commented on the issue:

    https://github.com/apache/spark/pull/21089
  
    Can one of the admins verify this patch?


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] spark issue #21089: [SPARK-24004] Test of from_json for non-root MapType

Posted by AmplabJenkins <gi...@git.apache.org>.
Github user AmplabJenkins commented on the issue:

    https://github.com/apache/spark/pull/21089
  
    Merged build finished. Test FAILed.


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] spark issue #21089: [SPARK-24004] Test of from_json for non-root MapType

Posted by HyukjinKwon <gi...@git.apache.org>.
Github user HyukjinKwon commented on the issue:

    https://github.com/apache/spark/pull/21089
  
    @MaxGekk, mind taking an action to the JIRA too?


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] spark issue #21089: [SPARK-24004] Test of from_json for non-root MapType

Posted by SparkQA <gi...@git.apache.org>.
Github user SparkQA commented on the issue:

    https://github.com/apache/spark/pull/21089
  
    **[Test build #89469 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/89469/testReport)** for PR 21089 at commit [`4391b0a`](https://github.com/apache/spark/commit/4391b0a94e7ddbf53043e6723b7e6e63655f5759).
     * This patch **fails Scala style tests**.
     * This patch merges cleanly.
     * This patch adds no public classes.


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] spark issue #21089: [SPARK-24004] Test of from_json for non-root MapType

Posted by AmplabJenkins <gi...@git.apache.org>.
Github user AmplabJenkins commented on the issue:

    https://github.com/apache/spark/pull/21089
  
    Test FAILed.
    Refer to this link for build results (access rights to CI server needed): 
    https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/89469/
    Test FAILed.


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] spark issue #21089: [SPARK-24004] Test of from_json for non-root MapType

Posted by AmplabJenkins <gi...@git.apache.org>.
Github user AmplabJenkins commented on the issue:

    https://github.com/apache/spark/pull/21089
  
    Test FAILed.
    Refer to this link for build results (access rights to CI server needed): 
    https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/89471/
    Test FAILed.


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] spark pull request #21089: [SPARK-24004] Test of from_json for non-root MapT...

Posted by MaxGekk <gi...@git.apache.org>.
Github user MaxGekk closed the pull request at:

    https://github.com/apache/spark/pull/21089


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org