You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@jackrabbit.apache.org by "Michael Neale (JIRA)" <ji...@apache.org> on 2007/05/24 08:23:16 UTC

[jira] Updated: (JCR-863) Patch to use FileLock for locking instead of empty file

     [ https://issues.apache.org/jira/browse/JCR-863?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Michael Neale updated JCR-863:
------------------------------

    Attachment: JCR-863.patch

Here is a patch with the constant fixed up the way it was (and license granted).

> Patch to use FileLock for locking instead of empty file
> -------------------------------------------------------
>
>                 Key: JCR-863
>                 URL: https://issues.apache.org/jira/browse/JCR-863
>             Project: Jackrabbit
>          Issue Type: Improvement
>          Components: query
>            Reporter: Michael Neale
>             Fix For: 1.4
>
>         Attachments: FSDirectory.patch, JCR-863.patch
>
>
> The FSDirectory uses File.createNewFile to effectively lock a directory (in makeLock), yet the Java Spec says explcitly not to use it for this purpose, and instead use FileLock from nio.
> The attached patch shows how this is/could be done (change is internal to the makeLock method only, and functionally equivalent, the same tests apply).

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.