You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@openwhisk.apache.org by GitBox <gi...@apache.org> on 2017/12/22 04:07:16 UTC

[GitHub] rabbah opened a new pull request #3130: Remove obsolete filter when determining container to remove.

rabbah opened a new pull request #3130: Remove obsolete filter when determining container to remove.
URL: https://github.com/apache/incubator-openwhisk/pull/3130
 
 
   While collecting a container to remove, the filter check the action and invocation namespace and excluded those from the candidate list. But this check is not necessary - any container in the free pool matching the action and namespace would be reused and the remove method should not be called in this case.
   
   We could keep these checks as defensive checks. Otherwise its deadcode and unnecessary overhead.
   
   Tentatively remove, update comment and tests.
   
   For historical context: https://github.com/apache/incubator-openwhisk/pull/2246 but this scheduling heuristic has changed since.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services