You are viewing a plain text version of this content. The canonical link for it is here.
Posted to torque-dev@db.apache.org by "Martin Goulet (JIRA)" <ji...@apache.org> on 2006/06/01 04:23:29 UTC
[jira] Created: (TORQUE-25) LimitHelper.java doesn't handle Sybase
DBMS
LimitHelper.java doesn't handle Sybase DBMS
-------------------------------------------
Key: TORQUE-25
URL: http://issues.apache.org/jira/browse/TORQUE-25
Project: Torque
Type: Improvement
Components: Runtime
Versions: 3.2
Environment: All
Reporter: Martin Goulet
Fix For: 3.2.1
> I've noticed that the DB.java class contains the constant to define
> limits (Criteria.setLimit() etc) for the Sybase database
> (LIMIT_STYLE_SYBASE). However the LimitHelper.java class doesn't make
> use of it (excerpt from the buidLimit method):
>
>
>
> ...
>
> if (offset > 0 || limit > 0)
> {
> // If we hit a database type, that is able to do native
> // limiting, we must set the criteria values to -1 and 0
> // afterwards. Reason is, that else theexecuteQuery
> // method tries to do the limiting using Village
> //
>
> switch (db.getLimitStyle())
> {
> case DB.LIMIT_STYLE_MYSQL :
> LimitHelper.generateMySQLLimits(query, offset, limit);
> break;
>
> case DB.LIMIT_STYLE_POSTGRES :
> LimitHelper.generatePostgreSQLLimits(query, offset, limit);
> break;
>
> case DB.LIMIT_STYLE_ORACLE :
> LimitHelper.generateOracleLimits(query, offset, limit);
> break;
>
> case DB.LIMIT_STYLE_DB2 :
> LimitHelper.generateDB2Limits(query, offset, limit);
> break;
>
> default:
> if (db.supportsNativeLimit())
> {
> query.setLimit(String.valueOf(limit));
> }
> break;
> }
>
> ...
>
>
>
> You notice that there is no case for Sybase (DB.LIMIT_STYLE_SYBASE).
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: torque-dev-unsubscribe@db.apache.org
For additional commands, e-mail: torque-dev-help@db.apache.org
[jira] Closed: (TORQUE-25) LimitHelper.java doesn't handle Sybase
DBMS
Posted by "Thomas Vandahl (JIRA)" <ji...@apache.org>.
[ http://issues.apache.org/jira/browse/TORQUE-25?page=all ]
Thomas Vandahl closed TORQUE-25.
--------------------------------
> LimitHelper.java doesn't handle Sybase DBMS
> -------------------------------------------
>
> Key: TORQUE-25
> URL: http://issues.apache.org/jira/browse/TORQUE-25
> Project: Torque
> Issue Type: Improvement
> Components: Runtime
> Affects Versions: 3.2
> Environment: All
> Reporter: Martin Goulet
> Assigned To: Thomas Fischer
> Fix For: 3.3
>
> Attachments: torque-25.patch.txt
>
>
> > I've noticed that the DB.java class contains the constant to define
> > limits (Criteria.setLimit() etc) for the Sybase database
> > (LIMIT_STYLE_SYBASE). However the LimitHelper.java class doesn't make
> > use of it (excerpt from the buidLimit method):
> >
> >
> >
> > ...
> >
> > if (offset > 0 || limit > 0)
> > {
> > // If we hit a database type, that is able to do native
> > // limiting, we must set the criteria values to -1 and 0
> > // afterwards. Reason is, that else theexecuteQuery
> > // method tries to do the limiting using Village
> > //
> >
> > switch (db.getLimitStyle())
> > {
> > case DB.LIMIT_STYLE_MYSQL :
> > LimitHelper.generateMySQLLimits(query, offset, limit);
> > break;
> >
> > case DB.LIMIT_STYLE_POSTGRES :
> > LimitHelper.generatePostgreSQLLimits(query, offset, limit);
> > break;
> >
> > case DB.LIMIT_STYLE_ORACLE :
> > LimitHelper.generateOracleLimits(query, offset, limit);
> > break;
> >
> > case DB.LIMIT_STYLE_DB2 :
> > LimitHelper.generateDB2Limits(query, offset, limit);
> > break;
> >
> > default:
> > if (db.supportsNativeLimit())
> > {
> > query.setLimit(String.valueOf(limit));
> > }
> > break;
> > }
> >
> > ...
> >
> >
> >
> > You notice that there is no case for Sybase (DB.LIMIT_STYLE_SYBASE).
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: torque-dev-unsubscribe@db.apache.org
For additional commands, e-mail: torque-dev-help@db.apache.org
[jira] Updated: (TORQUE-25) LimitHelper.java doesn't handle Sybase
DBMS
Posted by "Martin Goulet (JIRA)" <ji...@apache.org>.
[ http://issues.apache.org/jira/browse/TORQUE-25?page=all ]
Martin Goulet updated TORQUE-25:
--------------------------------
Attachment: torque-25.patch.txt
This is the patch to fix this issue.
> LimitHelper.java doesn't handle Sybase DBMS
> -------------------------------------------
>
> Key: TORQUE-25
> URL: http://issues.apache.org/jira/browse/TORQUE-25
> Project: Torque
> Type: Improvement
> Components: Runtime
> Versions: 3.2
> Environment: All
> Reporter: Martin Goulet
> Fix For: 3.2.1
> Attachments: torque-25.patch.txt
>
> > I've noticed that the DB.java class contains the constant to define
> > limits (Criteria.setLimit() etc) for the Sybase database
> > (LIMIT_STYLE_SYBASE). However the LimitHelper.java class doesn't make
> > use of it (excerpt from the buidLimit method):
> >
> >
> >
> > ...
> >
> > if (offset > 0 || limit > 0)
> > {
> > // If we hit a database type, that is able to do native
> > // limiting, we must set the criteria values to -1 and 0
> > // afterwards. Reason is, that else theexecuteQuery
> > // method tries to do the limiting using Village
> > //
> >
> > switch (db.getLimitStyle())
> > {
> > case DB.LIMIT_STYLE_MYSQL :
> > LimitHelper.generateMySQLLimits(query, offset, limit);
> > break;
> >
> > case DB.LIMIT_STYLE_POSTGRES :
> > LimitHelper.generatePostgreSQLLimits(query, offset, limit);
> > break;
> >
> > case DB.LIMIT_STYLE_ORACLE :
> > LimitHelper.generateOracleLimits(query, offset, limit);
> > break;
> >
> > case DB.LIMIT_STYLE_DB2 :
> > LimitHelper.generateDB2Limits(query, offset, limit);
> > break;
> >
> > default:
> > if (db.supportsNativeLimit())
> > {
> > query.setLimit(String.valueOf(limit));
> > }
> > break;
> > }
> >
> > ...
> >
> >
> >
> > You notice that there is no case for Sybase (DB.LIMIT_STYLE_SYBASE).
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: torque-dev-unsubscribe@db.apache.org
For additional commands, e-mail: torque-dev-help@db.apache.org
[jira] Resolved: (TORQUE-25) LimitHelper.java doesn't handle Sybase
DBMS
Posted by "Thomas Fischer (JIRA)" <ji...@apache.org>.
[ http://issues.apache.org/jira/browse/TORQUE-25?page=all ]
Thomas Fischer resolved TORQUE-25:
----------------------------------
Resolution: Fixed
Assign To: Thomas Fischer
> LimitHelper.java doesn't handle Sybase DBMS
> -------------------------------------------
>
> Key: TORQUE-25
> URL: http://issues.apache.org/jira/browse/TORQUE-25
> Project: Torque
> Type: Improvement
> Components: Runtime
> Versions: 3.2
> Environment: All
> Reporter: Martin Goulet
> Assignee: Thomas Fischer
> Fix For: 3.2.1
> Attachments: torque-25.patch.txt
>
> > I've noticed that the DB.java class contains the constant to define
> > limits (Criteria.setLimit() etc) for the Sybase database
> > (LIMIT_STYLE_SYBASE). However the LimitHelper.java class doesn't make
> > use of it (excerpt from the buidLimit method):
> >
> >
> >
> > ...
> >
> > if (offset > 0 || limit > 0)
> > {
> > // If we hit a database type, that is able to do native
> > // limiting, we must set the criteria values to -1 and 0
> > // afterwards. Reason is, that else theexecuteQuery
> > // method tries to do the limiting using Village
> > //
> >
> > switch (db.getLimitStyle())
> > {
> > case DB.LIMIT_STYLE_MYSQL :
> > LimitHelper.generateMySQLLimits(query, offset, limit);
> > break;
> >
> > case DB.LIMIT_STYLE_POSTGRES :
> > LimitHelper.generatePostgreSQLLimits(query, offset, limit);
> > break;
> >
> > case DB.LIMIT_STYLE_ORACLE :
> > LimitHelper.generateOracleLimits(query, offset, limit);
> > break;
> >
> > case DB.LIMIT_STYLE_DB2 :
> > LimitHelper.generateDB2Limits(query, offset, limit);
> > break;
> >
> > default:
> > if (db.supportsNativeLimit())
> > {
> > query.setLimit(String.valueOf(limit));
> > }
> > break;
> > }
> >
> > ...
> >
> >
> >
> > You notice that there is no case for Sybase (DB.LIMIT_STYLE_SYBASE).
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: torque-dev-unsubscribe@db.apache.org
For additional commands, e-mail: torque-dev-help@db.apache.org