[jira] [Commented] (MYFACES-4237) [perf] Performance update when checking for duplicate ids

["Thomas Andraschko (JIRA)" <de...@myfaces.apache.org>]

    [ https://issues.apache.org/jira/browse/MYFACES-4237?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16510074#comment-16510074 ] 

Thomas Andraschko commented on MYFACES-4237:
--------------------------------------------

Is the check used in production mode? AFAIR we have a flag for it.

> [perf] Performance update when checking for duplicate ids
> ---------------------------------------------------------
>
>                 Key: MYFACES-4237
>                 URL: https://issues.apache.org/jira/browse/MYFACES-4237
>             Project: MyFaces Core
>          Issue Type: Improvement
>          Components: JSR-372
>    Affects Versions: 2.2.12, 2.3.1
>            Reporter: Paul Nicolucci
>            Assignee: Paul Nicolucci
>            Priority: Minor
>             Fix For: 2.2.13, 2.3.2
>
>
> In org/apache/myfaces/view/facelets/compiler/CheckDuplicateIdFaceletUtils.java we currently do the following:
> {code:java}
> if (existingIds.contains (id)) {
> ....
> }
> {code}
> We can increase performance by doing the following:
> {code:java}
> if (!existingIds.add (id)) {
> ....
> }
> {code}



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)