You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@brooklyn.apache.org by GitBox <gi...@apache.org> on 2019/02/26 14:18:57 UTC

[GitHub] tbouron opened a new pull request #1049: Retry flaky unit tests

tbouron opened a new pull request #1049: Retry flaky unit tests
URL: https://github.com/apache/brooklyn-server/pull/1049
 
 
   We know that some of our unit tests are flaky. Testng has support for retrying tests by implementing `IRetryAnalyzer` interface, then reference that for selected tests.
   
   This does exactly that, and add the retry strategy to the usual suspects.
   
   As a side note, these flaky tests are because of races conditions, or test environments not being properly setup/cleanup. **We should definitely fix the root cause!** But for now, retrying maximum 3 times would eliminate false positive.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services