You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@felix.apache.org by "Valentin Valchev (JIRA)" <ji...@apache.org> on 2013/04/24 10:07:16 UTC

[jira] [Resolved] (FELIX-4032) UPnP Plugin small refactoring

     [ https://issues.apache.org/jira/browse/FELIX-4032?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Valentin Valchev resolved FELIX-4032.
-------------------------------------

    Resolution: Fixed
    
> UPnP Plugin small refactoring
> -----------------------------
>
>                 Key: FELIX-4032
>                 URL: https://issues.apache.org/jira/browse/FELIX-4032
>             Project: Felix
>          Issue Type: Bug
>          Components: Web Console
>    Affects Versions: webconsole-upnp-plugin-1.0.2
>            Reporter: Valentin Valchev
>            Assignee: Valentin Valchev
>             Fix For: webconsole-upnp-plugin-1.0.4
>
>
> UPnP Plugin needs small refactoring because now it's hard to read, and not efficient. Details:
> - ControlServlet.hex should go as Hex.encode()
> - static methods ControlServlet.<something>ToJson should go in separate Serializer class
> - now only icons are cached, we should also cache devices, now to render all device you do a loop through all service references. And when you open the plugin page, all devices are rendered. So if you have 80 devices you have 80 * 80 loops!

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira