You are viewing a plain text version of this content. The canonical link for it is here.

Posted to issues@maven.apache.org by "jira-importer (via GitHub)" <gi...@apache.org> on 2025/02/02 11:49:42 UTC

Re: [I] [MJLINK-62] Replace ByteArrayOutputStream with StringWriter [maven-jlink-plugin]

jira-importer commented on issue #331:
URL: https://github.com/apache/maven-jlink-plugin/issues/331#issuecomment-2629361143

   **[Herve Boutemy](https://issues.apache.org/jira/secure/ViewProfile.jspa?name=hboutemy)** commented
   
   yes, given we use the PrintWriter API of ToolProvider https://docs.oracle.com/javase/9/docs/api/java/util/spi/ToolProvider.html, it's better to keep the Character/String content as-is instead of butchering three times (once on `new PrintWriter(OutputStream)`, the second one on `baosOut.toString( "UTF-8" )` and the third one that is inconsistent with previous one `baosErr.toString()`)
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org