You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@spark.apache.org by "zhengruifeng (JIRA)" <ji...@apache.org> on 2016/11/01 11:03:58 UTC
[jira] [Comment Edited] (SPARK-16739) GBTClassifier should be a
Classifier, not Predictor
[ https://issues.apache.org/jira/browse/SPARK-16739?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15625133#comment-15625133 ]
zhengruifeng edited comment on SPARK-16739 at 11/1/16 11:03 AM:
----------------------------------------------------------------
Agreed. Since GBDT is not a {{Classifier}}, we can not use it via {{OneVsRest}} to support multi-class classification.
I think we may need to refactor {{GBTClassifier}} to be a subclass of {{Classifier}}. [~josephkb] [~yanboliang] [~sethah] [~sowen] What's your opinions?
{code}
scala> val gbt = new GBTClassifier
gbt: org.apache.spark.ml.classification.GBTClassifier = gbtc_506406adcf12
scala> val ovr = new OneVsRest().setClassifier(gbt)
<console>:39: error: type mismatch;
found : org.apache.spark.ml.classification.GBTClassifier
required: org.apache.spark.ml.classification.Classifier[_, _, _]
val ovr = new OneVsRest().setClassifier(gbt)
^
{code}
was (Author: podongfeng):
Agreed. Since GBDT is not a {{Classifier}}, we can not use it via {{OneVsRest}} to support multi-class classification.
I think we need to refactor {{GBTClassifier}} to be a subclass of {{Classifier}}. [~josephkb] [~yanboliang] What's your opinions?
{code}
scala> val gbt = new GBTClassifier
gbt: org.apache.spark.ml.classification.GBTClassifier = gbtc_506406adcf12
scala> val ovr = new OneVsRest().setClassifier(gbt)
<console>:39: error: type mismatch;
found : org.apache.spark.ml.classification.GBTClassifier
required: org.apache.spark.ml.classification.Classifier[_, _, _]
val ovr = new OneVsRest().setClassifier(gbt)
^
{code}
> GBTClassifier should be a Classifier, not Predictor
> ---------------------------------------------------
>
> Key: SPARK-16739
> URL: https://issues.apache.org/jira/browse/SPARK-16739
> Project: Spark
> Issue Type: Improvement
> Reporter: Vladimir Feinberg
> Priority: Minor
>
> Should probably wait for SPARK-4240 to be resolved first.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@spark.apache.org
For additional commands, e-mail: issues-help@spark.apache.org