[jira] [Comment Edited] (LUCENE-10459) Update smoke tester for 9.1

["Julie Tibshirani (Jira)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/LUCENE-10459?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17504547#comment-17504547 ] 

Julie Tibshirani edited comment on LUCENE-10459 at 3/10/22, 8:03 PM:
---------------------------------------------------------------------

I did some digging into previous commits.
* Before commit "LUCENE-10255: initial support for Java Modules (squashed)", the smoke tester basically works, there are no complaints about dependencies or folders.
* After LUCENE-10255, we start to get errors during the demo like "java.lang.module.FindException: Module com.carrotsearch.hppc not found, required by org.apache.lucene.facet"
* Then with commit "LUCENE-10301: Place test-framework into separated modules folder" we start to get errors around an unexpected folder "modules-test-framework".

I'm not really knowledgeable enough about the changes to attempt some fixes. [~dweiss] or [~tomoko] would you be able to dig into these failures? I encountered them by following the release wizard steps. Outside the release wizard, I think you could do this to reproduce:
* Check out branch_9_1
* Run {code}python3 -u dev-tools/scripts/buildAndPushRelease.py  --push-local <DIST-DIRECTORY>  --rc-num 1  --dev-mode{code}
* Run {code}python3 -u dev-tools/scripts/smokeTestRelease.py --not-signed --tmp-dir <TEMP-DIRECTORY> <DIST-DIRECTORY>/lucene-9.1.0-RC1-rev-<HASH>{code}

Let me know if I can help with anything.


was (Author: julietibs):
I did some digging into previous commits.
* Before commit "LUCENE-10255: initial support for Java Modules (squashed)", the smoke tester basically works, there are no complaints about dependencies or folders.
* After LUCENE-10255, we start to get errors during the demo like "java.lang.module.FindException: Module com.carrotsearch.hppc not found, required by org.apache.lucene.facet"
* Then with commit "LUCENE-10301: Place test-framework into separated modules folder" we start to get errors around an unexpected folder "modules-test-framework".

I'm not really knowledgeable enough about the changes to attempt some fixes. [~dweiss] or [~tomoko] would you be able to dig into these failures? I encountered them by following the release wizard steps. Outside the release wizard, I think you could do this to reproduce:
* Check out branch_9_1
* Run "python3 -u dev-tools/scripts/buildAndPushRelease.py  --push-local <DIST-DIRECTORY>  --rc-num 1  --dev-mode"
* Run "python3 -u dev-tools/scripts/smokeTestRelease.py --not-signed --tmp-dir <TEMP-DIRECTORY> <DIST-DIRECTORY>/lucene-9.1.0-RC1-rev-<HASH>"

Let me know if I can help with anything.

> Update smoke tester for 9.1
> ---------------------------
>
>                 Key: LUCENE-10459
>                 URL: https://issues.apache.org/jira/browse/LUCENE-10459
>             Project: Lucene - Core
>          Issue Type: Bug
>            Reporter: Julie Tibshirani
>            Priority: Major
>
> While working on the 9.1 release, I ran into several failures in the smoke tester that seem related to our move to the module system. At a high level, they include:
> * Including test directories in the binary distribution
> * Missing dependencies for the demo
> I opened this PR to show the details of the issues: https://github.com/apache/lucene/pull/739.



--
This message was sent by Atlassian Jira
(v8.20.1#820001)

---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org