You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@kafka.apache.org by Grant Henke <gr...@gmail.com> on 2015/07/17 17:27:45 UTC

Review Request 36570: Patch for KAFKA-2337

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36570/
-----------------------------------------------------------

Review request for kafka.


Bugs: KAFKA-2337
    https://issues.apache.org/jira/browse/KAFKA-2337


Repository: kafka


Description
-------

KAFKA-2337: Verify that metric names will not collide when creating new topics


Diffs
-----

  core/src/main/scala/kafka/admin/AdminUtils.scala f06edf41c732a7b794e496d0048b0ce6f897e72b 
  core/src/main/scala/kafka/admin/TopicCommand.scala a90aa8787ff21b963765a547980154363c1c93c6 
  core/src/main/scala/kafka/common/Topic.scala 32595d6fe432141119db26d3b5ebe229aac40805 
  core/src/test/scala/unit/kafka/admin/AdminTest.scala 252ac813c8df1780c2dc5fa9e698fb43bb6d5cf8 
  core/src/test/scala/unit/kafka/common/TopicTest.scala 79532c89c41572ba953c4dc3319a05354927e961 

Diff: https://reviews.apache.org/r/36570/diff/


Testing
-------


Thanks,

Grant Henke

Re: Review Request 36570: Patch for KAFKA-2337

Posted by Grant Henke <gr...@gmail.com>.

> On July 17, 2015, 4:05 p.m., Edward Ribeiro wrote:
> > core/src/main/scala/kafka/common/Topic.scala, lines 53-54
> > <https://reviews.apache.org/r/36570/diff/1/?file=1014515#file1014515line53>
> >
> >     This method name is sort of a misnomer is a it is checking for special characters that could lead to a collision, so *I* would suggest to rename it to ''hasCollisionChars'' or something like that. Or instead of ''couldCollide'' put it as ''maybeCollide'' as we use elswhere (e.g.: maybeFlushAndCommitOffsets, maybeLock, maybeComputeNext, etc).

I agree hasCollisionChars is more descriptive of the behavior. I will update.


- Grant


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36570/#review92092
-----------------------------------------------------------


On July 17, 2015, 3:27 p.m., Grant Henke wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/36570/
> -----------------------------------------------------------
> 
> (Updated July 17, 2015, 3:27 p.m.)
> 
> 
> Review request for kafka.
> 
> 
> Bugs: KAFKA-2337
>     https://issues.apache.org/jira/browse/KAFKA-2337
> 
> 
> Repository: kafka
> 
> 
> Description
> -------
> 
> KAFKA-2337: Verify that metric names will not collide when creating new topics
> 
> 
> Diffs
> -----
> 
>   core/src/main/scala/kafka/admin/AdminUtils.scala f06edf41c732a7b794e496d0048b0ce6f897e72b 
>   core/src/main/scala/kafka/admin/TopicCommand.scala a90aa8787ff21b963765a547980154363c1c93c6 
>   core/src/main/scala/kafka/common/Topic.scala 32595d6fe432141119db26d3b5ebe229aac40805 
>   core/src/test/scala/unit/kafka/admin/AdminTest.scala 252ac813c8df1780c2dc5fa9e698fb43bb6d5cf8 
>   core/src/test/scala/unit/kafka/common/TopicTest.scala 79532c89c41572ba953c4dc3319a05354927e961 
> 
> Diff: https://reviews.apache.org/r/36570/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Grant Henke
> 
>

Re: Review Request 36570: Patch for KAFKA-2337

Posted by Edward Ribeiro <ed...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36570/#review92092
-----------------------------------------------------------



core/src/main/scala/kafka/common/Topic.scala (lines 53 - 54)
<https://reviews.apache.org/r/36570/#comment146032>

    This method name is sort of a misnomer is a it is checking for special characters that could lead to a collision, so *I* would suggest to rename it to ''hasCollisionChars'' or something like that. Or instead of ''couldCollide'' put it as ''maybeCollide'' as we use elswhere (e.g.: maybeFlushAndCommitOffsets, maybeLock, maybeComputeNext, etc).


- Edward Ribeiro


On July 17, 2015, 3:27 p.m., Grant Henke wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/36570/
> -----------------------------------------------------------
> 
> (Updated July 17, 2015, 3:27 p.m.)
> 
> 
> Review request for kafka.
> 
> 
> Bugs: KAFKA-2337
>     https://issues.apache.org/jira/browse/KAFKA-2337
> 
> 
> Repository: kafka
> 
> 
> Description
> -------
> 
> KAFKA-2337: Verify that metric names will not collide when creating new topics
> 
> 
> Diffs
> -----
> 
>   core/src/main/scala/kafka/admin/AdminUtils.scala f06edf41c732a7b794e496d0048b0ce6f897e72b 
>   core/src/main/scala/kafka/admin/TopicCommand.scala a90aa8787ff21b963765a547980154363c1c93c6 
>   core/src/main/scala/kafka/common/Topic.scala 32595d6fe432141119db26d3b5ebe229aac40805 
>   core/src/test/scala/unit/kafka/admin/AdminTest.scala 252ac813c8df1780c2dc5fa9e698fb43bb6d5cf8 
>   core/src/test/scala/unit/kafka/common/TopicTest.scala 79532c89c41572ba953c4dc3319a05354927e961 
> 
> Diff: https://reviews.apache.org/r/36570/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Grant Henke
> 
>

Re: Review Request 36570: Patch for KAFKA-2337

Posted by Grant Henke <gr...@gmail.com>.

> On July 17, 2015, 4:01 p.m., Edward Ribeiro wrote:
> > core/src/main/scala/kafka/common/Topic.scala, line 64
> > <https://reviews.apache.org/r/36570/diff/1/?file=1014515#file1014515line64>
> >
> >     *Maybe* this method name could be renamed to 'collide' to make it more like a verb instead of a sustantive.
> 
> Grant Henke wrote:
>     I had a hard time naming this. Collide, to me, sounded like an action that should return a result. Like I was taking two topics and smashing them together in order to get something new.
> 
> Edward Ribeiro wrote:
>     Yeah, totally agree with you. Maybe ''hasCollision'' could be better. Makes it explicit it is a boolean method. wdyt?

Makes sense to me.


- Grant


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36570/#review92089
-----------------------------------------------------------


On July 17, 2015, 3:27 p.m., Grant Henke wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/36570/
> -----------------------------------------------------------
> 
> (Updated July 17, 2015, 3:27 p.m.)
> 
> 
> Review request for kafka.
> 
> 
> Bugs: KAFKA-2337
>     https://issues.apache.org/jira/browse/KAFKA-2337
> 
> 
> Repository: kafka
> 
> 
> Description
> -------
> 
> KAFKA-2337: Verify that metric names will not collide when creating new topics
> 
> 
> Diffs
> -----
> 
>   core/src/main/scala/kafka/admin/AdminUtils.scala f06edf41c732a7b794e496d0048b0ce6f897e72b 
>   core/src/main/scala/kafka/admin/TopicCommand.scala a90aa8787ff21b963765a547980154363c1c93c6 
>   core/src/main/scala/kafka/common/Topic.scala 32595d6fe432141119db26d3b5ebe229aac40805 
>   core/src/test/scala/unit/kafka/admin/AdminTest.scala 252ac813c8df1780c2dc5fa9e698fb43bb6d5cf8 
>   core/src/test/scala/unit/kafka/common/TopicTest.scala 79532c89c41572ba953c4dc3319a05354927e961 
> 
> Diff: https://reviews.apache.org/r/36570/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Grant Henke
> 
>

Re: Review Request 36570: Patch for KAFKA-2337

Posted by Edward Ribeiro <ed...@gmail.com>.

> On July 17, 2015, 4:01 p.m., Edward Ribeiro wrote:
> > core/src/main/scala/kafka/common/Topic.scala, line 64
> > <https://reviews.apache.org/r/36570/diff/1/?file=1014515#file1014515line64>
> >
> >     *Maybe* this method name could be renamed to 'collide' to make it more like a verb instead of a sustantive.
> 
> Grant Henke wrote:
>     I had a hard time naming this. Collide, to me, sounded like an action that should return a result. Like I was taking two topics and smashing them together in order to get something new.

Yeah, totally agree with you. Maybe ''hasCollision'' could be better. Makes it explicit it is a boolean method. wdyt?


- Edward


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36570/#review92089
-----------------------------------------------------------


On July 17, 2015, 3:27 p.m., Grant Henke wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/36570/
> -----------------------------------------------------------
> 
> (Updated July 17, 2015, 3:27 p.m.)
> 
> 
> Review request for kafka.
> 
> 
> Bugs: KAFKA-2337
>     https://issues.apache.org/jira/browse/KAFKA-2337
> 
> 
> Repository: kafka
> 
> 
> Description
> -------
> 
> KAFKA-2337: Verify that metric names will not collide when creating new topics
> 
> 
> Diffs
> -----
> 
>   core/src/main/scala/kafka/admin/AdminUtils.scala f06edf41c732a7b794e496d0048b0ce6f897e72b 
>   core/src/main/scala/kafka/admin/TopicCommand.scala a90aa8787ff21b963765a547980154363c1c93c6 
>   core/src/main/scala/kafka/common/Topic.scala 32595d6fe432141119db26d3b5ebe229aac40805 
>   core/src/test/scala/unit/kafka/admin/AdminTest.scala 252ac813c8df1780c2dc5fa9e698fb43bb6d5cf8 
>   core/src/test/scala/unit/kafka/common/TopicTest.scala 79532c89c41572ba953c4dc3319a05354927e961 
> 
> Diff: https://reviews.apache.org/r/36570/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Grant Henke
> 
>

Re: Review Request 36570: Patch for KAFKA-2337

Posted by Grant Henke <gr...@gmail.com>.

> On July 17, 2015, 4:01 p.m., Edward Ribeiro wrote:
> > core/src/main/scala/kafka/common/Topic.scala, line 64
> > <https://reviews.apache.org/r/36570/diff/1/?file=1014515#file1014515line64>
> >
> >     *Maybe* this method name could be renamed to 'collide' to make it more like a verb instead of a sustantive.

I had a hard time naming this. Collide, to me, sounded like an action that should return a result. Like I was taking two topics and smashing them together in order to get something new.


- Grant


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36570/#review92089
-----------------------------------------------------------


On July 17, 2015, 3:27 p.m., Grant Henke wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/36570/
> -----------------------------------------------------------
> 
> (Updated July 17, 2015, 3:27 p.m.)
> 
> 
> Review request for kafka.
> 
> 
> Bugs: KAFKA-2337
>     https://issues.apache.org/jira/browse/KAFKA-2337
> 
> 
> Repository: kafka
> 
> 
> Description
> -------
> 
> KAFKA-2337: Verify that metric names will not collide when creating new topics
> 
> 
> Diffs
> -----
> 
>   core/src/main/scala/kafka/admin/AdminUtils.scala f06edf41c732a7b794e496d0048b0ce6f897e72b 
>   core/src/main/scala/kafka/admin/TopicCommand.scala a90aa8787ff21b963765a547980154363c1c93c6 
>   core/src/main/scala/kafka/common/Topic.scala 32595d6fe432141119db26d3b5ebe229aac40805 
>   core/src/test/scala/unit/kafka/admin/AdminTest.scala 252ac813c8df1780c2dc5fa9e698fb43bb6d5cf8 
>   core/src/test/scala/unit/kafka/common/TopicTest.scala 79532c89c41572ba953c4dc3319a05354927e961 
> 
> Diff: https://reviews.apache.org/r/36570/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Grant Henke
> 
>

Re: Review Request 36570: Patch for KAFKA-2337

Posted by Edward Ribeiro <ed...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36570/#review92089
-----------------------------------------------------------



core/src/main/scala/kafka/common/Topic.scala (line 64)
<https://reviews.apache.org/r/36570/#comment146029>

    *Maybe* this method name could be renamed to 'collide' to make it more like a verb instead of a sustantive.


- Edward Ribeiro


On July 17, 2015, 3:27 p.m., Grant Henke wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/36570/
> -----------------------------------------------------------
> 
> (Updated July 17, 2015, 3:27 p.m.)
> 
> 
> Review request for kafka.
> 
> 
> Bugs: KAFKA-2337
>     https://issues.apache.org/jira/browse/KAFKA-2337
> 
> 
> Repository: kafka
> 
> 
> Description
> -------
> 
> KAFKA-2337: Verify that metric names will not collide when creating new topics
> 
> 
> Diffs
> -----
> 
>   core/src/main/scala/kafka/admin/AdminUtils.scala f06edf41c732a7b794e496d0048b0ce6f897e72b 
>   core/src/main/scala/kafka/admin/TopicCommand.scala a90aa8787ff21b963765a547980154363c1c93c6 
>   core/src/main/scala/kafka/common/Topic.scala 32595d6fe432141119db26d3b5ebe229aac40805 
>   core/src/test/scala/unit/kafka/admin/AdminTest.scala 252ac813c8df1780c2dc5fa9e698fb43bb6d5cf8 
>   core/src/test/scala/unit/kafka/common/TopicTest.scala 79532c89c41572ba953c4dc3319a05354927e961 
> 
> Diff: https://reviews.apache.org/r/36570/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Grant Henke
> 
>

Re: Review Request 36570: Patch for KAFKA-2337

Posted by Ashish Singh <as...@cloudera.com>.

> On July 20, 2015, 5:27 p.m., Ashish Singh wrote:
> >

LGTM, just a small comment.


- Ashish


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36570/#review92276
-----------------------------------------------------------


On July 17, 2015, 4:17 p.m., Grant Henke wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/36570/
> -----------------------------------------------------------
> 
> (Updated July 17, 2015, 4:17 p.m.)
> 
> 
> Review request for kafka.
> 
> 
> Bugs: KAFKA-2337
>     https://issues.apache.org/jira/browse/KAFKA-2337
> 
> 
> Repository: kafka
> 
> 
> Description
> -------
> 
> KAFKA-2337: Verify that metric names will not collide when creating new topics
> 
> 
> Diffs
> -----
> 
>   core/src/main/scala/kafka/admin/AdminUtils.scala f06edf41c732a7b794e496d0048b0ce6f897e72b 
>   core/src/main/scala/kafka/admin/TopicCommand.scala a90aa8787ff21b963765a547980154363c1c93c6 
>   core/src/main/scala/kafka/common/Topic.scala 32595d6fe432141119db26d3b5ebe229aac40805 
>   core/src/test/scala/unit/kafka/admin/AdminTest.scala 252ac813c8df1780c2dc5fa9e698fb43bb6d5cf8 
>   core/src/test/scala/unit/kafka/common/TopicTest.scala 79532c89c41572ba953c4dc3319a05354927e961 
> 
> Diff: https://reviews.apache.org/r/36570/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Grant Henke
> 
>

Re: Review Request 36570: Patch for KAFKA-2337

Posted by Ashish Singh <as...@cloudera.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36570/#review92276
-----------------------------------------------------------



core/src/main/scala/kafka/admin/TopicCommand.scala (line 89)
<https://reviews.apache.org/r/36570/#comment146340>

    Probably typo? "best to either"


- Ashish Singh


On July 17, 2015, 4:17 p.m., Grant Henke wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/36570/
> -----------------------------------------------------------
> 
> (Updated July 17, 2015, 4:17 p.m.)
> 
> 
> Review request for kafka.
> 
> 
> Bugs: KAFKA-2337
>     https://issues.apache.org/jira/browse/KAFKA-2337
> 
> 
> Repository: kafka
> 
> 
> Description
> -------
> 
> KAFKA-2337: Verify that metric names will not collide when creating new topics
> 
> 
> Diffs
> -----
> 
>   core/src/main/scala/kafka/admin/AdminUtils.scala f06edf41c732a7b794e496d0048b0ce6f897e72b 
>   core/src/main/scala/kafka/admin/TopicCommand.scala a90aa8787ff21b963765a547980154363c1c93c6 
>   core/src/main/scala/kafka/common/Topic.scala 32595d6fe432141119db26d3b5ebe229aac40805 
>   core/src/test/scala/unit/kafka/admin/AdminTest.scala 252ac813c8df1780c2dc5fa9e698fb43bb6d5cf8 
>   core/src/test/scala/unit/kafka/common/TopicTest.scala 79532c89c41572ba953c4dc3319a05354927e961 
> 
> Diff: https://reviews.apache.org/r/36570/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Grant Henke
> 
>

Re: Review Request 36570: Patch for KAFKA-2337

Posted by Gwen Shapira <gs...@cloudera.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36570/#review92323
-----------------------------------------------------------

Ship it!


LGTM.

Just a small nit.


core/src/main/scala/kafka/admin/AdminUtils.scala (lines 249 - 251)
<https://reviews.apache.org/r/36570/#comment146413>

    Nit: Our code standard includes not using curly brackets on a single line "if" block.



core/src/main/scala/kafka/admin/TopicCommand.scala (lines 88 - 90)
<https://reviews.apache.org/r/36570/#comment146412>

    Nit: Our code standard includes not using curly brackets on a single line "if" block.


- Gwen Shapira


On July 20, 2015, 5:37 p.m., Grant Henke wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/36570/
> -----------------------------------------------------------
> 
> (Updated July 20, 2015, 5:37 p.m.)
> 
> 
> Review request for kafka.
> 
> 
> Bugs: KAFKA-2337
>     https://issues.apache.org/jira/browse/KAFKA-2337
> 
> 
> Repository: kafka
> 
> 
> Description
> -------
> 
> KAFKA-2337: Verify that metric names will not collide when creating new topics
> 
> 
> Diffs
> -----
> 
>   core/src/main/scala/kafka/admin/AdminUtils.scala f06edf41c732a7b794e496d0048b0ce6f897e72b 
>   core/src/main/scala/kafka/admin/TopicCommand.scala a90aa8787ff21b963765a547980154363c1c93c6 
>   core/src/main/scala/kafka/common/Topic.scala 32595d6fe432141119db26d3b5ebe229aac40805 
>   core/src/test/scala/unit/kafka/admin/AdminTest.scala 252ac813c8df1780c2dc5fa9e698fb43bb6d5cf8 
>   core/src/test/scala/unit/kafka/common/TopicTest.scala 79532c89c41572ba953c4dc3319a05354927e961 
> 
> Diff: https://reviews.apache.org/r/36570/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Grant Henke
> 
>

Re: Review Request 36570: Patch for KAFKA-2337

Posted by Grant Henke <gr...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36570/#review92327
-----------------------------------------------------------

Ship it!


Ship It!

- Grant Henke


On July 20, 2015, 9:48 p.m., Grant Henke wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/36570/
> -----------------------------------------------------------
> 
> (Updated July 20, 2015, 9:48 p.m.)
> 
> 
> Review request for kafka.
> 
> 
> Bugs: KAFKA-2337
>     https://issues.apache.org/jira/browse/KAFKA-2337
> 
> 
> Repository: kafka
> 
> 
> Description
> -------
> 
> KAFKA-2337: Verify that metric names will not collide when creating new topics
> 
> 
> Diffs
> -----
> 
>   core/src/main/scala/kafka/admin/AdminUtils.scala f06edf41c732a7b794e496d0048b0ce6f897e72b 
>   core/src/main/scala/kafka/admin/TopicCommand.scala a90aa8787ff21b963765a547980154363c1c93c6 
>   core/src/main/scala/kafka/common/Topic.scala 32595d6fe432141119db26d3b5ebe229aac40805 
>   core/src/test/scala/unit/kafka/admin/AdminTest.scala 252ac813c8df1780c2dc5fa9e698fb43bb6d5cf8 
>   core/src/test/scala/unit/kafka/common/TopicTest.scala 79532c89c41572ba953c4dc3319a05354927e961 
> 
> Diff: https://reviews.apache.org/r/36570/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Grant Henke
> 
>

Re: Review Request 36570: Patch for KAFKA-2337

Posted by Grant Henke <gr...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36570/
-----------------------------------------------------------

(Updated July 20, 2015, 9:48 p.m.)


Review request for kafka.


Bugs: KAFKA-2337
    https://issues.apache.org/jira/browse/KAFKA-2337


Repository: kafka


Description
-------

KAFKA-2337: Verify that metric names will not collide when creating new topics


Diffs (updated)
-----

  core/src/main/scala/kafka/admin/AdminUtils.scala f06edf41c732a7b794e496d0048b0ce6f897e72b 
  core/src/main/scala/kafka/admin/TopicCommand.scala a90aa8787ff21b963765a547980154363c1c93c6 
  core/src/main/scala/kafka/common/Topic.scala 32595d6fe432141119db26d3b5ebe229aac40805 
  core/src/test/scala/unit/kafka/admin/AdminTest.scala 252ac813c8df1780c2dc5fa9e698fb43bb6d5cf8 
  core/src/test/scala/unit/kafka/common/TopicTest.scala 79532c89c41572ba953c4dc3319a05354927e961 

Diff: https://reviews.apache.org/r/36570/diff/


Testing
-------


Thanks,

Grant Henke

Re: Review Request 36570: Patch for KAFKA-2337

Posted by Ashish Singh <as...@cloudera.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36570/#review92296
-----------------------------------------------------------

Ship it!


Ship It!

- Ashish Singh


On July 20, 2015, 5:37 p.m., Grant Henke wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/36570/
> -----------------------------------------------------------
> 
> (Updated July 20, 2015, 5:37 p.m.)
> 
> 
> Review request for kafka.
> 
> 
> Bugs: KAFKA-2337
>     https://issues.apache.org/jira/browse/KAFKA-2337
> 
> 
> Repository: kafka
> 
> 
> Description
> -------
> 
> KAFKA-2337: Verify that metric names will not collide when creating new topics
> 
> 
> Diffs
> -----
> 
>   core/src/main/scala/kafka/admin/AdminUtils.scala f06edf41c732a7b794e496d0048b0ce6f897e72b 
>   core/src/main/scala/kafka/admin/TopicCommand.scala a90aa8787ff21b963765a547980154363c1c93c6 
>   core/src/main/scala/kafka/common/Topic.scala 32595d6fe432141119db26d3b5ebe229aac40805 
>   core/src/test/scala/unit/kafka/admin/AdminTest.scala 252ac813c8df1780c2dc5fa9e698fb43bb6d5cf8 
>   core/src/test/scala/unit/kafka/common/TopicTest.scala 79532c89c41572ba953c4dc3319a05354927e961 
> 
> Diff: https://reviews.apache.org/r/36570/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Grant Henke
> 
>

Re: Review Request 36570: Patch for KAFKA-2337

Posted by Edward Ribeiro <ed...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36570/#review92282
-----------------------------------------------------------

Ship it!


Ship It!

- Edward Ribeiro


On Julho 20, 2015, 5:37 p.m., Grant Henke wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/36570/
> -----------------------------------------------------------
> 
> (Updated Julho 20, 2015, 5:37 p.m.)
> 
> 
> Review request for kafka.
> 
> 
> Bugs: KAFKA-2337
>     https://issues.apache.org/jira/browse/KAFKA-2337
> 
> 
> Repository: kafka
> 
> 
> Description
> -------
> 
> KAFKA-2337: Verify that metric names will not collide when creating new topics
> 
> 
> Diffs
> -----
> 
>   core/src/main/scala/kafka/admin/AdminUtils.scala f06edf41c732a7b794e496d0048b0ce6f897e72b 
>   core/src/main/scala/kafka/admin/TopicCommand.scala a90aa8787ff21b963765a547980154363c1c93c6 
>   core/src/main/scala/kafka/common/Topic.scala 32595d6fe432141119db26d3b5ebe229aac40805 
>   core/src/test/scala/unit/kafka/admin/AdminTest.scala 252ac813c8df1780c2dc5fa9e698fb43bb6d5cf8 
>   core/src/test/scala/unit/kafka/common/TopicTest.scala 79532c89c41572ba953c4dc3319a05354927e961 
> 
> Diff: https://reviews.apache.org/r/36570/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Grant Henke
> 
>

Re: Review Request 36570: Patch for KAFKA-2337

Posted by Grant Henke <gr...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36570/
-----------------------------------------------------------

(Updated July 20, 2015, 5:37 p.m.)


Review request for kafka.


Bugs: KAFKA-2337
    https://issues.apache.org/jira/browse/KAFKA-2337


Repository: kafka


Description
-------

KAFKA-2337: Verify that metric names will not collide when creating new topics


Diffs (updated)
-----

  core/src/main/scala/kafka/admin/AdminUtils.scala f06edf41c732a7b794e496d0048b0ce6f897e72b 
  core/src/main/scala/kafka/admin/TopicCommand.scala a90aa8787ff21b963765a547980154363c1c93c6 
  core/src/main/scala/kafka/common/Topic.scala 32595d6fe432141119db26d3b5ebe229aac40805 
  core/src/test/scala/unit/kafka/admin/AdminTest.scala 252ac813c8df1780c2dc5fa9e698fb43bb6d5cf8 
  core/src/test/scala/unit/kafka/common/TopicTest.scala 79532c89c41572ba953c4dc3319a05354927e961 

Diff: https://reviews.apache.org/r/36570/diff/


Testing
-------


Thanks,

Grant Henke

Re: Review Request 36570: Patch for KAFKA-2337

Posted by Grant Henke <gr...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36570/
-----------------------------------------------------------

(Updated July 17, 2015, 4:17 p.m.)


Review request for kafka.


Bugs: KAFKA-2337
    https://issues.apache.org/jira/browse/KAFKA-2337


Repository: kafka


Description
-------

KAFKA-2337: Verify that metric names will not collide when creating new topics


Diffs (updated)
-----

  core/src/main/scala/kafka/admin/AdminUtils.scala f06edf41c732a7b794e496d0048b0ce6f897e72b 
  core/src/main/scala/kafka/admin/TopicCommand.scala a90aa8787ff21b963765a547980154363c1c93c6 
  core/src/main/scala/kafka/common/Topic.scala 32595d6fe432141119db26d3b5ebe229aac40805 
  core/src/test/scala/unit/kafka/admin/AdminTest.scala 252ac813c8df1780c2dc5fa9e698fb43bb6d5cf8 
  core/src/test/scala/unit/kafka/common/TopicTest.scala 79532c89c41572ba953c4dc3319a05354927e961 

Diff: https://reviews.apache.org/r/36570/diff/


Testing
-------


Thanks,

Grant Henke