You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@couchdb.apache.org by kxepal <gi...@git.apache.org> on 2015/10/14 18:49:51 UTC
[GitHub] couchdb-couch pull request: Use couch_log for startup notification...
GitHub user kxepal opened a pull request:
https://github.com/apache/couchdb-couch/pull/122
Use couch_log for startup notifications
lager, couch_log and friends starts long before couch_sup, so it seems safe to use couch_log instead of io:format here. Thoughts? @eiri @rnewson
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/kxepal/couchdb-couch use-couch-log-for-startup-notifications
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/couchdb-couch/pull/122.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #122
----
commit b43fcef0fbd4524457e083d3d93f020424f2bee4
Author: Alexander Shorin <kx...@apache.org>
Date: 2015-10-14T16:46:35Z
Use couch_log for startup notifications
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] couchdb-couch pull request: Use couch_log for startup notification...
Posted by kxepal <gi...@git.apache.org>.
Github user kxepal commented on the pull request:
https://github.com/apache/couchdb-couch/pull/122#issuecomment-148121476
From what I see in logs and startup order (with the patch):
```
2015-10-14 19:43:23.407 [info] Undefined <0.7.0> Application lager started on node 'node1@127.0.0.1'
2015-10-14 19:43:23.407 [info] Undefined <0.7.0> Application couch_log_lager started on node 'node1@127.0.0.1'
2015-10-14 19:43:23.408 [info] Undefined <0.7.0> Application couch_log started on node 'node1@127.0.0.1'
2015-10-14 19:43:23.408 [info] Undefined <0.7.0> Application folsom started on node 'node1@127.0.0.1'
2015-10-14 19:43:23.422 [info] Undefined <0.7.0> Application couch_stats started on node 'node1@127.0.0.1'
2015-10-14 19:43:23.430 [info] Undefined <0.7.0> Application config started on node 'node1@127.0.0.1'
2015-10-14 19:43:23.430 [info] Undefined <0.7.0> Application crypto started on node 'node1@127.0.0.1'
2015-10-14 19:43:23.431 [info] Undefined <0.7.0> Application sasl started on node 'node1@127.0.0.1'
2015-10-14 19:43:23.432 [info] Undefined <0.7.0> Application inets started on node 'node1@127.0.0.1'
2015-10-14 19:43:23.432 [info] Undefined <0.7.0> Application asn1 started on node 'node1@127.0.0.1'
2015-10-14 19:43:23.432 [info] Undefined <0.7.0> Application public_key started on node 'node1@127.0.0.1'
2015-10-14 19:43:23.433 [info] Undefined <0.7.0> Application ssl started on node 'node1@127.0.0.1'
2015-10-14 19:43:23.435 [info] Undefined <0.7.0> Application os_mon started on node 'node1@127.0.0.1'
2015-10-14 19:43:23.438 [info] Undefined <0.7.0> Application ibrowse started on node 'node1@127.0.0.1'
2015-10-14 19:43:23.438 [info] Undefined <0.173.0> alarm_handler: {set,{system_memory_high_watermark,[]}}
2015-10-14 19:43:23.438 [info] Undefined <0.7.0> Application xmerl started on node 'node1@127.0.0.1'
2015-10-14 19:43:23.439 [info] Undefined <0.7.0> Application mochiweb started on node 'node1@127.0.0.1'
2015-10-14 19:43:23.439 [info] Undefined <0.7.0> Application oauth started on node 'node1@127.0.0.1'
2015-10-14 19:43:23.439 [info] Undefined <0.7.0> Application b64url started on node 'node1@127.0.0.1'
2015-10-14 19:43:23.439 [info] Undefined <0.7.0> Application khash started on node 'node1@127.0.0.1'
2015-10-14 19:43:23.439 [info] Undefined <0.7.0> Application couch_event started on node 'node1@127.0.0.1'
2015-10-14 19:43:23.440 [info] Undefined <0.7.0> Application ioq started on node 'node1@127.0.0.1'
2015-10-14 19:43:23.440 [info] node1@127.0.0.1 <0.231.0> Apache CouchDB c0bf9d6 is starting.
2015-10-14 19:43:23.440 [info] node1@127.0.0.1 <0.232.0> Starting couch_sup
2015-10-14 19:43:23.443 [info] Undefined <0.173.0> alarm_handler: {set,{{disk_almost_full,"/usr/local"},[]}}
2015-10-14 19:43:23.443 [info] Undefined <0.173.0> alarm_handler: {set,{{disk_almost_full,"/mnt/usb"},[]}}
2015-10-14 19:43:23.457 [info] node1@127.0.0.1 <0.231.0> Apache CouchDB has started. Time to relax.
2015-10-14 19:43:23.457 [info] node1@127.0.0.1 <0.231.0> Apache CouchDB has started on http://127.0.0.1:15986/
```
Looks safe.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] couchdb-couch pull request: Use couch_log for startup notification...
Posted by eiri <gi...@git.apache.org>.
Github user eiri commented on the pull request:
https://github.com/apache/couchdb-couch/pull/122#issuecomment-148133836
and stats' aggregator loads metrics on init and as I read in the code it seems to be synchronous. Cool, good with me, +1
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] couchdb-couch pull request: Use couch_log for startup notification...
Posted by eiri <gi...@git.apache.org>.
Github user eiri commented on the pull request:
https://github.com/apache/couchdb-couch/pull/122#issuecomment-148119125
It should be fine, but we need to be sure that if `couch_stats` started by this point it also loaded couch_log's stats definitions, otherwise we'll have a lock.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] couchdb-couch pull request: Use couch_log for startup notification...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/couchdb-couch/pull/122
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---