You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pulsar.apache.org by GitBox <gi...@apache.org> on 2019/03/26 00:32:07 UTC
[GitHub] [pulsar] srkukarni commented on a change in pull request #3868:
[Issue 3867] Provide the description of sink/source command for better usage
srkukarni commented on a change in pull request #3868: [Issue 3867] Provide the description of sink/source command for better usage
URL: https://github.com/apache/pulsar/pull/3868#discussion_r268905703
##########
File path: pulsar-client-tools/src/main/java/org/apache/pulsar/admin/cli/CmdSinks.java
##########
@@ -212,10 +220,6 @@ void runCmd() throws Exception {
}
print("Updated successfully");
}
-
- protected void validateSinkConfigs(SinkConfig sinkConfig) {
Review comment:
for create requests, all parameters that are required need to be set. However for update, only a subset will do.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services