You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@activemq.apache.org by franz1981 <gi...@git.apache.org> on 2017/08/02 09:43:20 UTC
[GitHub] activemq-artemis pull request #1436: ARTEMIS-1318 Uses unbuffered MAPPED Jou...
GitHub user franz1981 opened a pull request:
https://github.com/apache/activemq-artemis/pull/1436
ARTEMIS-1318 Uses unbuffered MAPPED Journal if no data-sync is required
In order to reduce memory footprint, CPU usage and reduce latencies it avoid to use the TimedBuffer on the MAPPED journal if no datasync is required.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/franz1981/activemq-artemis mapped_timed_buffer_fix
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/activemq-artemis/pull/1436.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #1436
----
commit 77c2f61ffee363b437ad4e39d4b4ed74ebb3c651
Author: Francesco Nigro <ni...@gmail.com>
Date: 2017-07-27T08:47:08Z
ARTEMIS-1318 Uses unbuffered MAPPED Journal if no data-sync is required
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] activemq-artemis pull request #1436: ARTEMIS-1318 Uses unbuffered MAPPED Jou...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/activemq-artemis/pull/1436
---
[GitHub] activemq-artemis issue #1436: ARTEMIS-1318 Uses unbuffered MAPPED Journal if...
Posted by clebertsuconic <gi...@git.apache.org>.
Github user clebertsuconic commented on the issue:
https://github.com/apache/activemq-artemis/pull/1436
@franz1981 what about replacing the TimedBuffer from another delegating buffer that would call the callbacks?
Now, you have to make sure that callbacks from replication would still be used, as in this mode you would need it to work.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] activemq-artemis issue #1436: ARTEMIS-1318 Uses unbuffered MAPPED Journal if...
Posted by franz1981 <gi...@git.apache.org>.
Github user franz1981 commented on the issue:
https://github.com/apache/activemq-artemis/pull/1436
@clebertsuconic
Yes I need to run the whole test suite, add some others tests to see if it is working as expected plus provides the NIO version too.
What I'm not understanding is what is happening here: https://github.com/franz1981/activemq-artemis/blob/31d5758885214ff65aebfdeb6024f7b275397bff/artemis-journal/src/main/java/org/apache/activemq/artemis/core/journal/impl/JournalImpl.java#L2646-L2646
Seems the only visible difference when the TimedBuffer is not enable (on NIO too)...
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] activemq-artemis issue #1436: ARTEMIS-1318 Uses unbuffered MAPPED Journal if...
Posted by clebertsuconic <gi...@git.apache.org>.
Github user clebertsuconic commented on the issue:
https://github.com/apache/activemq-artemis/pull/1436
@franz1981 I feel like you should do more tests before merging this Franz.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] activemq-artemis issue #1436: ARTEMIS-1318 Uses unbuffered MAPPED Journal if...
Posted by franz1981 <gi...@git.apache.org>.
Github user franz1981 commented on the issue:
https://github.com/apache/activemq-artemis/pull/1436
@clebertsuconic I'm just concerned about the callbacks behaviour...do you have any advices?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---