You are viewing a plain text version of this content. The canonical link for it is here.
Posted to pr@cassandra.apache.org by GitBox <gi...@apache.org> on 2020/04/06 08:32:13 UTC
[GitHub] [cassandra-builds] smiklosovic opened a new pull request #18: added
Docker image for Debian Buster
smiklosovic opened a new pull request #18: added Docker image for Debian Buster
URL: https://github.com/apache/cassandra-builds/pull/18
@michaelsembwever I ve created Buster Docker file as you suggested.
Do you think we should make this in such way that it is possible to build it either with Java 8 or Java 11 via some build args? I _think_ that debs are compiled with Java 8 in mind in the first place but having this possibility would be nice.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: pr-unsubscribe@cassandra.apache.org
For additional commands, e-mail: pr-help@cassandra.apache.org
[GitHub] [cassandra-builds] smiklosovic commented on issue #18: added Docker
image for Debian Buster
Posted by GitBox <gi...@apache.org>.
smiklosovic commented on issue #18: added Docker image for Debian Buster
URL: https://github.com/apache/cassandra-builds/pull/18#issuecomment-609814279
@michaelsembwever one thing might be problematic here, there is this file (1).
If this is built with Java 8, it has to be run with Java 8 and more. If it is built with Java 11, it has to be run with Java 11 and more.
I do not see any _simple_ way how to reflect this into that `control` file. I would say that this should be changed to be dependable on Java 11 as by that way, we can run it with Java 8 too if one really wants that to be the case as he would configure it manually via alternatives afterwards.
Should I take this path with trying to patch `debian/control` in Cassandra?
Other solution would be to make two `control` files and we would overwrite the main with the "control-11" in case we detect the build should be done with Java 11. I am not strong in Debian package creation so there might be other way but after merely looking I dont see any option.
When it comes to this PR, args would be just propagated to build_debs.sh script and based on that, there would be set env property `CASSANDRA_USE_JDK11=true` so debs scripts would invoke ant jar with this (and ant would run implicitly with Java 11 too as we would make that switch in build_deps.sh script).
(1) https://github.com/apache/cassandra/blob/trunk/debian/control#L14
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: pr-unsubscribe@cassandra.apache.org
For additional commands, e-mail: pr-help@cassandra.apache.org
[GitHub] [cassandra-builds] smiklosovic commented on issue #18: added Docker
image for Debian Buster
Posted by GitBox <gi...@apache.org>.
smiklosovic commented on issue #18: added Docker image for Debian Buster
URL: https://github.com/apache/cassandra-builds/pull/18#issuecomment-613420225
@michaelsembwever it is done, could you please go over it and give me a feedback, if any?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: pr-unsubscribe@cassandra.apache.org
For additional commands, e-mail: pr-help@cassandra.apache.org
[GitHub] [cassandra-builds] smiklosovic edited a comment on issue #18: added
Docker image for Debian Buster
Posted by GitBox <gi...@apache.org>.
smiklosovic edited a comment on issue #18: added Docker image for Debian Buster
URL: https://github.com/apache/cassandra-builds/pull/18#issuecomment-609814279
@michaelsembwever one thing might be problematic here, there is this file (1).
If this is built with Java 8, it has to be run with Java 8 and more. If it is built with Java 11, it has to be run with Java 11 and more.
I do not see any _simple_ way how to reflect this into that `control` file. I would say that this should be changed to be dependable on Java 11 as by that way, we can run it even it was built with Java 8.
Should I take this path with trying to patch `debian/control` in Cassandra?
Other solution would be to make two `control` files and we would overwrite the main with the "control-11" in case we detect the build should be done with Java 11. I am not strong in Debian package creation so there might be other way but after merely looking I dont see any option. I think this way is more of a hack than doing things properly.
When it comes to this PR, args would be just propagated to build_debs.sh script and based on that, there would be set env property `CASSANDRA_USE_JDK11=true` so debs scripts would invoke ant jar with this (and ant would run implicitly with Java 11 too as we would make that switch in build_deps.sh script).
(1) https://github.com/apache/cassandra/blob/trunk/debian/control#L14
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: pr-unsubscribe@cassandra.apache.org
For additional commands, e-mail: pr-help@cassandra.apache.org
[GitHub] [cassandra-builds] smiklosovic edited a comment on issue #18: added
Docker image for Debian Buster
Posted by GitBox <gi...@apache.org>.
smiklosovic edited a comment on issue #18: added Docker image for Debian Buster
URL: https://github.com/apache/cassandra-builds/pull/18#issuecomment-609814279
@michaelsembwever one thing might be problematic here, there is this file (1).
If this is built with Java 8, it has to be run with Java 8 and more. If it is built with Java 11, it has to be run with Java 11 and more.
I do not see any _simple_ way how to reflect this into that `control` file. I would say that this should be changed to be dependable on Java 11 as by that way, we can run it even it was built with Java 8.
Should I take this path with trying to patch `debian/control` in Cassandra?
Other solution would be to make two `control` files and we would overwrite the main with the "control-11" in case we detect the build should be done with Java 11. I am not strong in Debian package creation so there might be other way but after merely looking I dont see any option.
When it comes to this PR, args would be just propagated to build_debs.sh script and based on that, there would be set env property `CASSANDRA_USE_JDK11=true` so debs scripts would invoke ant jar with this (and ant would run implicitly with Java 11 too as we would make that switch in build_deps.sh script).
(1) https://github.com/apache/cassandra/blob/trunk/debian/control#L14
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: pr-unsubscribe@cassandra.apache.org
For additional commands, e-mail: pr-help@cassandra.apache.org
[GitHub] [cassandra-builds] michaelsembwever commented on issue #18: added
Docker image for Debian Buster
Posted by GitBox <gi...@apache.org>.
michaelsembwever commented on issue #18: added Docker image for Debian Buster
URL: https://github.com/apache/cassandra-builds/pull/18#issuecomment-609654091
> Do you think we should make this in such way that it is possible to build it either with Java 8 or Java 11 via some build args?
Yes 👍
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: pr-unsubscribe@cassandra.apache.org
For additional commands, e-mail: pr-help@cassandra.apache.org
[GitHub] [cassandra-builds] michaelsembwever merged pull request #18: added
Docker image for Debian Buster
Posted by GitBox <gi...@apache.org>.
michaelsembwever merged pull request #18: added Docker image for Debian Buster
URL: https://github.com/apache/cassandra-builds/pull/18
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: pr-unsubscribe@cassandra.apache.org
For additional commands, e-mail: pr-help@cassandra.apache.org
[GitHub] [cassandra-builds] michaelsembwever commented on issue #18: added
Docker image for Debian Buster
Posted by GitBox <gi...@apache.org>.
michaelsembwever commented on issue #18: added Docker image for Debian Buster
URL: https://github.com/apache/cassandra-builds/pull/18#issuecomment-610900172
Cassandra 4.0 published artifacts will be cut and published for now compiling with JDK 1.8
According to our support matrix: http://cassandra.apache.org/doc/latest/new/java11.html
that means either JDK 1.8 or JDK 11 are supported for runtime.
And it means that building with JDK 11 is for devs only. Which I guess means it's ok if the control file supports either JDK 1.8 or JDK 11 even if the former won't actually work, as devs should know this.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: pr-unsubscribe@cassandra.apache.org
For additional commands, e-mail: pr-help@cassandra.apache.org
[GitHub] [cassandra-builds] smiklosovic edited a comment on issue #18: added
Docker image for Debian Buster
Posted by GitBox <gi...@apache.org>.
smiklosovic edited a comment on issue #18: added Docker image for Debian Buster
URL: https://github.com/apache/cassandra-builds/pull/18#issuecomment-609814279
@michaelsembwever one thing might be problematic here, there is this file (1).
If this is built with Java 8, it has to be run with Java 8 and more. If it is built with Java 11, it has to be run with Java 11 and more.
I do not see any _simple_ way how to reflect this into that `control` file. I would say that this should be changed to be dependable on Java 11 as by that way, we can run it with Java 8 too if one really wants that to be the case as he would configure it manually via alternatives afterwards (but he would have to have Cassandra built with Java 8, obviously).
Should I take this path with trying to patch `debian/control` in Cassandra?
Other solution would be to make two `control` files and we would overwrite the main with the "control-11" in case we detect the build should be done with Java 11. I am not strong in Debian package creation so there might be other way but after merely looking I dont see any option.
When it comes to this PR, args would be just propagated to build_debs.sh script and based on that, there would be set env property `CASSANDRA_USE_JDK11=true` so debs scripts would invoke ant jar with this (and ant would run implicitly with Java 11 too as we would make that switch in build_deps.sh script).
(1) https://github.com/apache/cassandra/blob/trunk/debian/control#L14
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: pr-unsubscribe@cassandra.apache.org
For additional commands, e-mail: pr-help@cassandra.apache.org