You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@kudu.apache.org by "Alexey Serbin (Code Review)" <ge...@cloudera.org> on 2024/04/12 21:28:34 UTC
[kudu-CR](branch-1.17.x) KUDU-3495 Initialize the bitmap while decoding insert/upsert
Alexey Serbin has uploaded this change for review. ( http://gerrit.cloudera.org:8080/21296
Change subject: KUDU-3495 Initialize the bitmap while decoding insert/upsert
......................................................................
KUDU-3495 Initialize the bitmap while decoding insert/upsert
The upsert request with an old client schema might lead to
unexpected result eventually.
If client A opens a table first and then client B add a column
to the table, the upsert request of client A might set the
newly added column to default value.
The reason is that we did not initialize the tablet_isset_bitmap
while decoding the insert or upsert requests.
A user does not want to change the column which he did not request
to even if the client schema is not correct, so initialize the bitmap.
Change-Id: I38a33cb58a085bc83854c5145e904c8ed51092a8
Reviewed-on: http://gerrit.cloudera.org:8080/20327
Tested-by: Kudu Jenkins
Reviewed-by: Alexey Serbin <al...@apache.org>
(cherry picked from commit f1f3c907fc6f012b6d7a72f0103e1db4f56f0e7d)
---
M src/kudu/common/row_operations-test.cc
M src/kudu/common/row_operations.cc
2 files changed, 31 insertions(+), 0 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/96/21296/1
--
To view, visit http://gerrit.cloudera.org:8080/21296
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: branch-1.17.x
Gerrit-MessageType: newchange
Gerrit-Change-Id: I38a33cb58a085bc83854c5145e904c8ed51092a8
Gerrit-Change-Number: 21296
Gerrit-PatchSet: 1
Gerrit-Owner: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Song Jiacheng <so...@thinkingdata.cn>
[kudu-CR](branch-1.17.x) KUDU-3495 Initialize the bitmap while decoding insert/upsert
Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Alexey Serbin has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/21296 )
Change subject: KUDU-3495 Initialize the bitmap while decoding insert/upsert
......................................................................
KUDU-3495 Initialize the bitmap while decoding insert/upsert
The upsert request with an old client schema might lead to
unexpected result eventually.
If client A opens a table first and then client B add a column
to the table, the upsert request of client A might set the
newly added column to default value.
The reason is that we did not initialize the tablet_isset_bitmap
while decoding the insert or upsert requests.
A user does not want to change the column which he did not request
to even if the client schema is not correct, so initialize the bitmap.
Change-Id: I38a33cb58a085bc83854c5145e904c8ed51092a8
Reviewed-on: http://gerrit.cloudera.org:8080/20327
Tested-by: Kudu Jenkins
Reviewed-by: Alexey Serbin <al...@apache.org>
(cherry picked from commit f1f3c907fc6f012b6d7a72f0103e1db4f56f0e7d)
Reviewed-on: http://gerrit.cloudera.org:8080/21296
Reviewed-by: Yingchun Lai <la...@apache.org>
Tested-by: Alexey Serbin <al...@apache.org>
---
M src/kudu/common/row_operations-test.cc
M src/kudu/common/row_operations.cc
2 files changed, 31 insertions(+), 0 deletions(-)
Approvals:
Yingchun Lai: Looks good to me, approved
Alexey Serbin: Verified
--
To view, visit http://gerrit.cloudera.org:8080/21296
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: branch-1.17.x
Gerrit-MessageType: merged
Gerrit-Change-Id: I38a33cb58a085bc83854c5145e904c8ed51092a8
Gerrit-Change-Number: 21296
Gerrit-PatchSet: 2
Gerrit-Owner: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Abhishek Chennaka <ac...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Song Jiacheng <so...@thinkingdata.cn>
Gerrit-Reviewer: Yingchun Lai <la...@apache.org>
[kudu-CR](branch-1.17.x) KUDU-3495 Initialize the bitmap while decoding insert/upsert
Posted by "Yingchun Lai (Code Review)" <ge...@cloudera.org>.
Yingchun Lai has posted comments on this change. ( http://gerrit.cloudera.org:8080/21296 )
Change subject: KUDU-3495 Initialize the bitmap while decoding insert/upsert
......................................................................
Patch Set 1: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/21296
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: branch-1.17.x
Gerrit-MessageType: comment
Gerrit-Change-Id: I38a33cb58a085bc83854c5145e904c8ed51092a8
Gerrit-Change-Number: 21296
Gerrit-PatchSet: 1
Gerrit-Owner: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Abhishek Chennaka <ac...@cloudera.com>
Gerrit-Reviewer: Song Jiacheng <so...@thinkingdata.cn>
Gerrit-Reviewer: Yingchun Lai <la...@apache.org>
Gerrit-Comment-Date: Sun, 14 Apr 2024 15:50:17 +0000
Gerrit-HasComments: No
[kudu-CR](branch-1.17.x) KUDU-3495 Initialize the bitmap while decoding insert/upsert
Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/21296 )
Change subject: KUDU-3495 Initialize the bitmap while decoding insert/upsert
......................................................................
Patch Set 1: Verified+1
--
To view, visit http://gerrit.cloudera.org:8080/21296
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: branch-1.17.x
Gerrit-MessageType: comment
Gerrit-Change-Id: I38a33cb58a085bc83854c5145e904c8ed51092a8
Gerrit-Change-Number: 21296
Gerrit-PatchSet: 1
Gerrit-Owner: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Abhishek Chennaka <ac...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Song Jiacheng <so...@thinkingdata.cn>
Gerrit-Reviewer: Yingchun Lai <la...@apache.org>
Gerrit-Comment-Date: Tue, 16 Apr 2024 15:08:29 +0000
Gerrit-HasComments: No