You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@jclouds.apache.org by Ignasi Barrera <no...@github.com> on 2014/10/01 21:59:14 UTC

[jclouds-site] Force Jekyll 1.5.1 (#132)

This commit forces Jekyll 1.5.1 to deploy the site. Different versions of Jekyll render the site with small differences, and that makes almost every commit to the SVN site repository contain many files that are unrelated to the change being committed.

To avoid this, we should make sure we all generate the site using the same version of Jekyll when deploying it. This commit forces version 1.5.1, which is the one used by the CI system to validate the pull requests,
You can merge this Pull Request by running:

  git pull https://github.com/nacx/jclouds-site jekyll-version

Or you can view, comment on it, or merge it online at:

  https://github.com/jclouds/jclouds-site/pull/132

-- Commit Summary --

  * Force Jekyll 1.5.1

-- File Changes --

    M README.md (2)
    M deploy-site.sh (17)

-- Patch Links --

https://github.com/jclouds/jclouds-site/pull/132.patch
https://github.com/jclouds/jclouds-site/pull/132.diff

---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-site/pull/132

Re: [jclouds-site] Force Jekyll 1.5.1 (#132)

Posted by Ignasi Barrera <no...@github.com>.
After this PR is merged we should publish the site, with all unrelated minor changes, to the SVN, so it serves as a starting point for clean commits.
/cc @everett-toews @demobox 

---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-site/pull/132#issuecomment-57528941

Re: [jclouds-site] Force Jekyll 1.5.1 (#132)

Posted by Ignasi Barrera <no...@github.com>.
@everett-toews @demobox Any input on this? I plan to merge it and upload the site, as there are still commits to be published. That would generate some unrelated changes, but hopefully enforcing all of us use the same version of Jekyll will prevent this from happening again.

---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-site/pull/132#issuecomment-58021722

Re: [jclouds-site] Force Jekyll 1.5.1 (#132)

Posted by CloudBees pull request builder plugin <no...@github.com>.
[jclouds-site-pull-requests #404](https://jclouds.ci.cloudbees.com/job/jclouds-site-pull-requests/404/) SUCCESS
This pull request looks good

---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-site/pull/132#issuecomment-57528398

Re: [jclouds-site] Force Jekyll 1.5.1 (#132)

Posted by Adrian Cole <ad...@gmail.com>.
+1

Outsider, but thing change seems completely sensible and follows how we try
to treat dependency and plugin versions. It other words, let's merge this
so we can focus on work, not debuggint lib differences!

Re: [jclouds-site] Force Jekyll 1.5.1 (#132)

Posted by jclouds-commentator <no...@github.com>.
  Go to http://078146b4f59b54b74afe-c1a695f95c6532b02b76177d250620ed.r37.cf5.rackcdn.com/ to review your changes.

---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-site/pull/132#issuecomment-57528690

Re: [jclouds-site] Force Jekyll 1.5.1 (#132)

Posted by Everett Toews <no...@github.com>.
+1 

Sorry about the delayed review. Still getting unburied after JavaOne.

---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-site/pull/132#issuecomment-58066324

Re: [jclouds-site] Force Jekyll 1.5.1 (#132)

Posted by Andrew Phillips <no...@github.com>.
+1, looks good to me too. Thanks, @nacx - and apologies for the delayed review ;-)

---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-site/pull/132#issuecomment-58045994

Re: [jclouds-site] Force Jekyll 1.5.1 (#132)

Posted by Ignasi Barrera <no...@github.com>.
Merged and deployed the site with all pending commits.

---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-site/pull/132#issuecomment-58038011