You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@kie.apache.org by "porcelli (via GitHub)" <gi...@apache.org> on 2024/04/19 18:50:01 UTC
[PR] Quarkus LTS Upgrade to 3.8.4 [incubator-kie-drools]
porcelli opened a new pull request, #5853:
URL: https://github.com/apache/incubator-kie-drools/pull/5853
Related https://github.com/apache/incubator-kie-issues/issues/958
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@kie.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@kie.apache.org
For additional commands, e-mail: commits-help@kie.apache.org
Re: [PR] Quarkus LTS Upgrade to 3.8.4 [incubator-kie-drools]
Posted by "porcelli (via GitHub)" <gi...@apache.org>.
porcelli commented on code in PR #5853:
URL: https://github.com/apache/incubator-kie-drools/pull/5853#discussion_r1574840550
##########
drools-util/src/main/java/org/drools/util/RemoveCommentsMain.java:
##########
@@ -1,51 +0,0 @@
-package org.drools.util;
-
-import org.slf4j.Logger;
-import org.slf4j.LoggerFactory;
-
-import java.io.IOException;
-import java.nio.file.Files;
-import java.nio.file.NoSuchFileException;
-import java.nio.file.Path;
-import java.util.stream.Collectors;
-
-public class RemoveCommentsMain {
Review Comment:
@baldimir fyi
##########
drools-util/src/test/java/org/drools/util/RemoveCommentsTest.java:
##########
@@ -1,15 +0,0 @@
-package org.drools.util;
-
Review Comment:
@baldimir fyi
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@kie.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@kie.apache.org
For additional commands, e-mail: commits-help@kie.apache.org
Re: [PR] Quarkus LTS Upgrade to 3.8.4 [incubator-kie-drools]
Posted by "porcelli (via GitHub)" <gi...@apache.org>.
porcelli merged PR #5853:
URL: https://github.com/apache/incubator-kie-drools/pull/5853
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@kie.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@kie.apache.org
For additional commands, e-mail: commits-help@kie.apache.org
Re: [PR] Quarkus LTS Upgrade to 3.8.4 [incubator-kie-drools]
Posted by "porcelli (via GitHub)" <gi...@apache.org>.
porcelli commented on code in PR #5853:
URL: https://github.com/apache/incubator-kie-drools/pull/5853#discussion_r1574840093
##########
drools-quarkus-extension/drools-quarkus-deployment/pom.xml:
##########
@@ -178,29 +178,6 @@
</execution>
</executions>
</plugin>
- <plugin>
- <!-- Remove comments from META-INF/quarkus-javadoc.properties -->
- <!-- This is needed because the file generated by quarkus contains a timestamp in a comment that makes the build not reproducible -->
- <!-- This workaround can be removed when drools will be migrated to quarkus release containing this fix https://github.com/quarkusio/quarkus/pull/38365 -->
- <groupId>org.codehaus.mojo</groupId>
- <artifactId>exec-maven-plugin</artifactId>
- <version>3.1.1</version>
- <executions>
- <execution>
- <id>Run Script</id>
- <phase>prepare-package</phase>
- <goals>
- <goal>java</goal>
- </goals>
- <configuration>
- <mainClass>org.drools.util.RemoveCommentsMain</mainClass>
Review Comment:
just pushed the change for that
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@kie.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@kie.apache.org
For additional commands, e-mail: commits-help@kie.apache.org
Re: [PR] Quarkus LTS Upgrade to 3.8.4 [incubator-kie-drools]
Posted by "jstastny-cz (via GitHub)" <gi...@apache.org>.
jstastny-cz commented on PR #5853:
URL: https://github.com/apache/incubator-kie-drools/pull/5853#issuecomment-2072094292
Change in build-chain config won't take effect in the jenkins PR check, so it will keep failing, GHA PR checks to be considered here.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@kie.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@kie.apache.org
For additional commands, e-mail: commits-help@kie.apache.org
Re: [PR] Quarkus LTS Upgrade to 3.8.4 [incubator-kie-drools]
Posted by "jstastny-cz (via GitHub)" <gi...@apache.org>.
jstastny-cz commented on PR #5853:
URL: https://github.com/apache/incubator-kie-drools/pull/5853#issuecomment-2074042648
A note here - due to length of the build the jenkins PR runs downstream projects in "quickly" mode, so it's rather a compile downstream build - that's why there's fail in kogito-apps GHA, but jenkins PR check is green. The GHA failure is relevant and should be considered.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@kie.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@kie.apache.org
For additional commands, e-mail: commits-help@kie.apache.org
Re: [PR] Quarkus LTS Upgrade to 3.8.4 [incubator-kie-drools]
Posted by "baldimir (via GitHub)" <gi...@apache.org>.
baldimir commented on code in PR #5853:
URL: https://github.com/apache/incubator-kie-drools/pull/5853#discussion_r1574584313
##########
drools-quarkus-extension/drools-quarkus-deployment/pom.xml:
##########
@@ -178,29 +178,6 @@
</execution>
</executions>
</plugin>
- <plugin>
- <!-- Remove comments from META-INF/quarkus-javadoc.properties -->
- <!-- This is needed because the file generated by quarkus contains a timestamp in a comment that makes the build not reproducible -->
- <!-- This workaround can be removed when drools will be migrated to quarkus release containing this fix https://github.com/quarkusio/quarkus/pull/38365 -->
- <groupId>org.codehaus.mojo</groupId>
- <artifactId>exec-maven-plugin</artifactId>
- <version>3.1.1</version>
- <executions>
- <execution>
- <id>Run Script</id>
- <phase>prepare-package</phase>
- <goals>
- <goal>java</goal>
- </goals>
- <configuration>
- <mainClass>org.drools.util.RemoveCommentsMain</mainClass>
Review Comment:
If this workaround is removed, the class RemoveCommentsMain could be removed from the drools-util too, as I expect the workaround will be removed also from other repositories, where used.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@kie.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@kie.apache.org
For additional commands, e-mail: commits-help@kie.apache.org
Re: [PR] Quarkus LTS Upgrade to 3.8.4 [incubator-kie-drools]
Posted by "porcelli (via GitHub)" <gi...@apache.org>.
porcelli commented on code in PR #5853:
URL: https://github.com/apache/incubator-kie-drools/pull/5853#discussion_r1574704385
##########
drools-quarkus-extension/drools-quarkus-deployment/pom.xml:
##########
@@ -178,29 +178,6 @@
</execution>
</executions>
</plugin>
- <plugin>
- <!-- Remove comments from META-INF/quarkus-javadoc.properties -->
- <!-- This is needed because the file generated by quarkus contains a timestamp in a comment that makes the build not reproducible -->
- <!-- This workaround can be removed when drools will be migrated to quarkus release containing this fix https://github.com/quarkusio/quarkus/pull/38365 -->
- <groupId>org.codehaus.mojo</groupId>
- <artifactId>exec-maven-plugin</artifactId>
- <version>3.1.1</version>
- <executions>
- <execution>
- <id>Run Script</id>
- <phase>prepare-package</phase>
- <goals>
- <goal>java</goal>
- </goals>
- <configuration>
- <mainClass>org.drools.util.RemoveCommentsMain</mainClass>
Review Comment:
good point, I'll remove and update the PR
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@kie.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@kie.apache.org
For additional commands, e-mail: commits-help@kie.apache.org