You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@lucene.apache.org by rm...@apache.org on 2022/12/02 01:32:48 UTC

[lucene] branch main updated: fix wrong serialization by ShapeDocValues (#11974)

This is an automated email from the ASF dual-hosted git repository.

rmuir pushed a commit to branch main
in repository https://gitbox.apache.org/repos/asf/lucene.git


The following commit(s) were added to refs/heads/main by this push:
     new fad3108b27b fix wrong serialization by ShapeDocValues (#11974)
fad3108b27b is described below

commit fad3108b27b7c9b9514a5b96e26295da3f7c8723
Author: Robert Muir <rm...@apache.org>
AuthorDate: Thu Dec 1 20:32:42 2022 -0500

    fix wrong serialization by ShapeDocValues (#11974)
    
    Closes #11973
---
 gradle/validation/error-prone.gradle                                | 2 +-
 lucene/core/src/java/org/apache/lucene/document/ShapeDocValues.java | 2 +-
 2 files changed, 2 insertions(+), 2 deletions(-)

diff --git a/gradle/validation/error-prone.gradle b/gradle/validation/error-prone.gradle
index 97db9e2cae6..7c2aecc8cd9 100644
--- a/gradle/validation/error-prone.gradle
+++ b/gradle/validation/error-prone.gradle
@@ -377,7 +377,7 @@ allprojects { prj ->
             // '-Xep:LiteEnumValueOf:OFF', // we don't use protobuf
             // '-Xep:LiteProtoToString:OFF', // we don't use protobuf
             // '-Xep:LockNotBeforeTry:OFF', // TODO: there are problems
-            // '-Xep:LogicalAssignment:OFF', // TODO: there are problems
+            '-Xep:LogicalAssignment:WARN',
             // '-Xep:LongDoubleConversion:OFF', // TODO: there are problems
             '-Xep:LongFloatConversion:WARN',
             '-Xep:LoopOverCharArray:WARN',
diff --git a/lucene/core/src/java/org/apache/lucene/document/ShapeDocValues.java b/lucene/core/src/java/org/apache/lucene/document/ShapeDocValues.java
index 0f9651607c7..6756f370d64 100644
--- a/lucene/core/src/java/org/apache/lucene/document/ShapeDocValues.java
+++ b/lucene/core/src/java/org/apache/lucene/document/ShapeDocValues.java
@@ -550,7 +550,7 @@ abstract class ShapeDocValues {
       if (node.triangle.bc == true) {
         header |= 0x20;
       }
-      if (node.triangle.ca = true) {
+      if (node.triangle.ca == true) {
         header |= 0x40;
       }