You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by "stefankandic (via GitHub)" <gi...@apache.org> on 2025/01/21 14:52:35 UTC
[PR] [SPARK-50904][SQL] Fix collation expression walker query execution [spark]
stefankandic opened a new pull request, #49586:
URL: https://github.com/apache/spark/pull/49586
### What changes were proposed in this pull request?
Changing when we collect results in `CollationExpressionWalkerSuite` on borders of changing session default collation.
### Why are the changes needed?
Because we are analyzing the query and then setting a different default collation, this leads to problems for runtime replaceable expressions which will only be resolved when we call `collect` and by then the session default collation is changed. This is blocking the change in #49576.
### Does this PR introduce _any_ user-facing change?
No
### How was this patch tested?
This is a test-only change.
### Was this patch authored or co-authored using generative AI tooling?
No
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
Re: [PR] [SPARK-50904][SQL] Fix collation expression walker query execution [spark]
Posted by "MaxGekk (via GitHub)" <gi...@apache.org>.
MaxGekk closed pull request #49586: [SPARK-50904][SQL] Fix collation expression walker query execution
URL: https://github.com/apache/spark/pull/49586
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
Re: [PR] [SPARK-50904][SQL] Fix collation expression walker query execution [spark]
Posted by "MaxGekk (via GitHub)" <gi...@apache.org>.
MaxGekk commented on PR #49586:
URL: https://github.com/apache/spark/pull/49586#issuecomment-2605237204
+1, LGTM. Merging to master/4.0.
Thank you, @stefankandic.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org