You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@wicket.apache.org by "Dan Retzlaff (Created) (JIRA)" <ji...@apache.org> on 2012/03/07 20:25:02 UTC
[jira] [Created] (WICKET-4442) UrlEncoder does not encode colons in
path segments
UrlEncoder does not encode colons in path segments
--------------------------------------------------
Key: WICKET-4442
URL: https://issues.apache.org/jira/browse/WICKET-4442
Project: Wicket
Issue Type: Bug
Components: wicket
Affects Versions: 1.5.4
Reporter: Dan Retzlaff
Priority: Minor
UrlEncoder adds the colon (":") to its "dontNeedEncoding" set. This breaks redirect for stateful mounts with colons in path segments, and appears to contradict the rules in the preceding comment. Moving the exception to only apply to query parameters may be more appropriate.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (WICKET-4442) UrlEncoder does not encode colons in
path segments
Posted by "Dan Retzlaff (Updated) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/WICKET-4442?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Dan Retzlaff updated WICKET-4442:
---------------------------------
Attachment: encoding-quickstart.zip
> UrlEncoder does not encode colons in path segments
> --------------------------------------------------
>
> Key: WICKET-4442
> URL: https://issues.apache.org/jira/browse/WICKET-4442
> Project: Wicket
> Issue Type: Bug
> Components: wicket
> Affects Versions: 1.5.4
> Reporter: Dan Retzlaff
> Priority: Minor
> Attachments: encoding-quickstart.zip
>
>
> UrlEncoder adds the colon (":") to its "dontNeedEncoding" set. This breaks redirect for stateful mounts with colons in path segments, and appears to contradict the rules in the preceding comment. Moving the exception to only apply to query parameters may be more appropriate.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Resolved] (WICKET-4442) UrlEncoder does not encode colons
in path segments
Posted by "Martin Grigorov (Resolved) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/WICKET-4442?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Martin Grigorov resolved WICKET-4442.
-------------------------------------
Resolution: Duplicate
Duplicate of WICKET-4260.
> UrlEncoder does not encode colons in path segments
> --------------------------------------------------
>
> Key: WICKET-4442
> URL: https://issues.apache.org/jira/browse/WICKET-4442
> Project: Wicket
> Issue Type: Bug
> Components: wicket
> Affects Versions: 1.5.4
> Reporter: Dan Retzlaff
> Priority: Minor
> Attachments: encoding-quickstart.zip
>
>
> UrlEncoder adds the colon (":") to its "dontNeedEncoding" set. This breaks redirect for stateful mounts with colons in path segments, and appears to contradict the rules in the preceding comment. Moving the exception to only apply to query parameters may be more appropriate.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (WICKET-4442) UrlEncoder does not encode colons
in path segments
Posted by "Sven Meier (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/WICKET-4442?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13224832#comment-13224832 ]
Sven Meier commented on WICKET-4442:
------------------------------------
On " abc:def" Wicket redirects to "abc:def?0" to add the page id, but the request doesn't even seem to arrive at my Jetty server?
> UrlEncoder does not encode colons in path segments
> --------------------------------------------------
>
> Key: WICKET-4442
> URL: https://issues.apache.org/jira/browse/WICKET-4442
> Project: Wicket
> Issue Type: Bug
> Components: wicket
> Affects Versions: 1.5.4
> Reporter: Dan Retzlaff
> Priority: Minor
> Attachments: encoding-quickstart.zip
>
>
> UrlEncoder adds the colon (":") to its "dontNeedEncoding" set. This breaks redirect for stateful mounts with colons in path segments, and appears to contradict the rules in the preceding comment. Moving the exception to only apply to query parameters may be more appropriate.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (WICKET-4442) UrlEncoder does not encode colons
in path segments
Posted by "Dan Retzlaff (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/WICKET-4442?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13224841#comment-13224841 ]
Dan Retzlaff commented on WICKET-4442:
--------------------------------------
Thanks for pointing me to the RFC: http://tools.ietf.org/html/rfc3986. From section 3.3: In addition, a URI reference (Section 4.1) may be a relative-path reference, in which case the first path segment cannot contain a colon (":") character.
In this failing case, the redirect is relative-path to "abc:def" which indeed contains a colon. If I mount the page as "mount/${s}/extra" it works.
When I sniff the TCP traffic, I see the 302 getting back to the browser but the browser ignoring it. Tested with Chrome and IE.
> UrlEncoder does not encode colons in path segments
> --------------------------------------------------
>
> Key: WICKET-4442
> URL: https://issues.apache.org/jira/browse/WICKET-4442
> Project: Wicket
> Issue Type: Bug
> Components: wicket
> Affects Versions: 1.5.4
> Reporter: Dan Retzlaff
> Priority: Minor
> Attachments: encoding-quickstart.zip
>
>
> UrlEncoder adds the colon (":") to its "dontNeedEncoding" set. This breaks redirect for stateful mounts with colons in path segments, and appears to contradict the rules in the preceding comment. Moving the exception to only apply to query parameters may be more appropriate.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (WICKET-4442) UrlEncoder does not encode colons
in path segments
Posted by "Sven Meier (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/WICKET-4442?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13224851#comment-13224851 ]
Sven Meier commented on WICKET-4442:
------------------------------------
Good catch, you always have to wonder what they squeeze into these RFCs ;).
4.2 has a good explanation:
A path segment that contains a colon character (e.g., "this:that")
cannot be used as the first segment of a relative-path reference, as
it would be mistaken for a scheme name. Such a segment must be
preceded by a dot-segment (e.g., "./this:that") to make a relative-
path reference.
We could change relative urls to always start with "./", we'll have to investigate whether this breaks something.
> UrlEncoder does not encode colons in path segments
> --------------------------------------------------
>
> Key: WICKET-4442
> URL: https://issues.apache.org/jira/browse/WICKET-4442
> Project: Wicket
> Issue Type: Bug
> Components: wicket
> Affects Versions: 1.5.4
> Reporter: Dan Retzlaff
> Priority: Minor
> Attachments: encoding-quickstart.zip
>
>
> UrlEncoder adds the colon (":") to its "dontNeedEncoding" set. This breaks redirect for stateful mounts with colons in path segments, and appears to contradict the rules in the preceding comment. Moving the exception to only apply to query parameters may be more appropriate.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira