[GitHub] [arrow-datafusion] jayzhan211 commented on a diff in pull request #6990: Replace `array_contains` with SQL array functions: `array_has`, `array_has_any`, `array_has_all`

["jayzhan211 (via GitHub)" <gi...@apache.org>]

jayzhan211 commented on code in PR #6990:
URL: https://github.com/apache/arrow-datafusion/pull/6990#discussion_r1270107470


##########
datafusion/core/tests/sqllogictests/test_files/array.slt:
##########
@@ -1009,48 +1063,117 @@ NULL 1 1
 2 NULL 1
 2 1 NULL
 
-## array_contains

Review Comment:
   No, I `array_contains` is deprecated, the logic is not the same as `array_has_all` or `array_has`.



##########
datafusion/core/tests/sqllogictests/test_files/array.slt:
##########
@@ -1009,48 +1063,117 @@ NULL 1 1
 2 NULL 1
 2 1 NULL
 
-## array_contains

Review Comment:
   No, `array_contains` is deprecated, the logic is not the same as `array_has_all` or `array_has`.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org