[GitHub] [kafka] dajac commented on a diff in pull request #14120: KAFKA-14499: [4/N] Implement OffsetFetch API

["dajac (via GitHub)" <gi...@apache.org>]

dajac commented on code in PR #14120:
URL: https://github.com/apache/kafka/pull/14120#discussion_r1302268054


##########
group-coordinator/src/main/java/org/apache/kafka/coordinator/group/GroupCoordinatorService.java:
##########
@@ -480,9 +482,35 @@ public CompletableFuture<List<OffsetFetchResponseData.OffsetFetchResponseTopics>
             return FutureUtils.failedFuture(Errors.COORDINATOR_NOT_AVAILABLE.exception());
         }
 
-        return FutureUtils.failedFuture(Errors.UNSUPPORTED_VERSION.exception(
-            "This API is not implemented yet."
-        ));
+        // For backwards compatibility, we support fetch commits for the empty groupId.

Review Comment:
   No. It means that you can actually commit offsets to a group names with an empty group id. I was not aware of this until I rewrote this code.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org