[GitHub] [hadoop] bibinchundatt commented on a change in pull request #2674: YARN-10476. Queue metrics for Unmanaged applications

[GitBox <gi...@apache.org>]

bibinchundatt commented on a change in pull request #2674:
URL: https://github.com/apache/hadoop/pull/2674#discussion_r576748078



##########
File path: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/main/java/org/apache/hadoop/yarn/server/resourcemanager/scheduler/capacity/CapacityScheduler.java
##########
@@ -1091,9 +1094,10 @@ private void addApplication(ApplicationId applicationId, String queueName,
         return;
       }
       // update the metrics
-      queue.getMetrics().submitApp(user);
+      queue.getMetrics().submitApp(user, isAppOnUAM);
       SchedulerApplication<FiCaSchedulerApp> application =
-          new SchedulerApplication<FiCaSchedulerApp>(queue, user, priority);
+          new SchedulerApplication<FiCaSchedulerApp>(queue, user, priority,
+              isAppOnUAM);

Review comment:
       Variable name  could be unmanagedAM and isUnmanagedAM as method name for all files.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: common-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: common-issues-help@hadoop.apache.org