You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@sqoop.apache.org by Ying Cao <an...@gmail.com> on 2017/06/04 16:38:07 UTC
Re: Review Request 58600: add --schema option for import-all-tables
and list-tables against db2
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58600/
-----------------------------------------------------------
(Updated 六月 4, 2017, 4:38 p.m.)
Review request for Sqoop, Abraham Elmahrek, Boglarka Egyed, Jarek Cecho, Attila Szabo, and Szabolcs Vasas.
Bugs: SQOOP-1905
https://issues.apache.org/jira/browse/SQOOP-1905
Repository: sqoop-trunk
Description
-------
SQOOP-1905 : add --schema option for import-all-tables and list-tables against db2
Diffs (updated)
-----
src/java/org/apache/sqoop/manager/Db2Manager.java 52ab05ef
src/java/org/apache/sqoop/manager/GenericJdbcManager.java 2113a5f5
src/test/org/apache/sqoop/manager/db2/DB2ImportAllTableWithSchemaManual.java PRE-CREATION
Diff: https://reviews.apache.org/r/58600/diff/3/
Changes: https://reviews.apache.org/r/58600/diff/2-3/
Testing
-------
Mannual UT is passed
Thanks,
Ying Cao
Re: Review Request 58600: add --schema option for import-all-tables
and list-tables against db2
Posted by Attila Szabo <ma...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58600/#review181105
-----------------------------------------------------------
Ship it!
Ship It!
- Attila Szabo
On June 5, 2017, 3:01 p.m., Ying Cao wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/58600/
> -----------------------------------------------------------
>
> (Updated June 5, 2017, 3:01 p.m.)
>
>
> Review request for Sqoop, Abraham Elmahrek, Boglarka Egyed, Jarek Cecho, Attila Szabo, and Szabolcs Vasas.
>
>
> Bugs: SQOOP-1905
> https://issues.apache.org/jira/browse/SQOOP-1905
>
>
> Repository: sqoop-trunk
>
>
> Description
> -------
>
> SQOOP-1905 : add --schema option for import-all-tables and list-tables against db2
>
>
> Diffs
> -----
>
> src/java/org/apache/sqoop/manager/Db2Manager.java 52ab05ef
> src/java/org/apache/sqoop/manager/GenericJdbcManager.java 2113a5f5
> src/test/org/apache/sqoop/manager/db2/DB2ImportAllTableWithSchemaManualTest.java PRE-CREATION
>
>
> Diff: https://reviews.apache.org/r/58600/diff/4/
>
>
> Testing
> -------
>
> Mannual UT is passed
>
>
> Thanks,
>
> Ying Cao
>
>
Re: Review Request 58600: add --schema option for import-all-tables
and list-tables against db2
Posted by Ying Cao <an...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58600/
-----------------------------------------------------------
(Updated 六月 5, 2017, 3:01 p.m.)
Review request for Sqoop, Abraham Elmahrek, Boglarka Egyed, Jarek Cecho, Attila Szabo, and Szabolcs Vasas.
Changes
-------
Fix base on Bogi's comments
Bugs: SQOOP-1905
https://issues.apache.org/jira/browse/SQOOP-1905
Repository: sqoop-trunk
Description
-------
SQOOP-1905 : add --schema option for import-all-tables and list-tables against db2
Diffs (updated)
-----
src/java/org/apache/sqoop/manager/Db2Manager.java 52ab05ef
src/java/org/apache/sqoop/manager/GenericJdbcManager.java 2113a5f5
src/test/org/apache/sqoop/manager/db2/DB2ImportAllTableWithSchemaManualTest.java PRE-CREATION
Diff: https://reviews.apache.org/r/58600/diff/4/
Changes: https://reviews.apache.org/r/58600/diff/3-4/
Testing
-------
Mannual UT is passed
Thanks,
Ying Cao
Re: Review Request 58600: add --schema option for import-all-tables
and list-tables against db2
Posted by Ying Cao <an...@gmail.com>.
> On 六月 5, 2017, 11:09 a.m., Boglarka Egyed wrote:
> > src/test/org/apache/sqoop/manager/db2/DB2ImportAllTableWithSchemaManual.java
> > Lines 76 (patched)
> > <https://reviews.apache.org/r/58600/diff/3/?file=1741029#file1741029line76>
> >
> > Please use ManualTest at the end so that the related ant task for manual tests will find it.
Hi Bogi,
Thanks for your remind, I have update fix, please help review it again.
Regards,
Angela
- Ying
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58600/#review176905
-----------------------------------------------------------
On 六月 5, 2017, 3:01 p.m., Ying Cao wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/58600/
> -----------------------------------------------------------
>
> (Updated 六月 5, 2017, 3:01 p.m.)
>
>
> Review request for Sqoop, Abraham Elmahrek, Boglarka Egyed, Jarek Cecho, Attila Szabo, and Szabolcs Vasas.
>
>
> Bugs: SQOOP-1905
> https://issues.apache.org/jira/browse/SQOOP-1905
>
>
> Repository: sqoop-trunk
>
>
> Description
> -------
>
> SQOOP-1905 : add --schema option for import-all-tables and list-tables against db2
>
>
> Diffs
> -----
>
> src/java/org/apache/sqoop/manager/Db2Manager.java 52ab05ef
> src/java/org/apache/sqoop/manager/GenericJdbcManager.java 2113a5f5
> src/test/org/apache/sqoop/manager/db2/DB2ImportAllTableWithSchemaManualTest.java PRE-CREATION
>
>
> Diff: https://reviews.apache.org/r/58600/diff/4/
>
>
> Testing
> -------
>
> Mannual UT is passed
>
>
> Thanks,
>
> Ying Cao
>
>
Re: Review Request 58600: add --schema option for import-all-tables
and list-tables against db2
Posted by Boglarka Egyed <eg...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58600/#review176905
-----------------------------------------------------------
Fix it, then Ship it!
Hi Angela,
Build and ant clean test were successful with your patch.
I have left one last finding, please correct it before committing this change.
Thanks for your contribution!
Cheers,
Bogi
src/test/org/apache/sqoop/manager/db2/DB2ImportAllTableWithSchemaManual.java
Lines 76 (patched)
<https://reviews.apache.org/r/58600/#comment250457>
Please use ManualTest at the end so that the related ant task for manual tests will find it.
- Boglarka Egyed
On June 4, 2017, 4:38 p.m., Ying Cao wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/58600/
> -----------------------------------------------------------
>
> (Updated June 4, 2017, 4:38 p.m.)
>
>
> Review request for Sqoop, Abraham Elmahrek, Boglarka Egyed, Jarek Cecho, Attila Szabo, and Szabolcs Vasas.
>
>
> Bugs: SQOOP-1905
> https://issues.apache.org/jira/browse/SQOOP-1905
>
>
> Repository: sqoop-trunk
>
>
> Description
> -------
>
> SQOOP-1905 : add --schema option for import-all-tables and list-tables against db2
>
>
> Diffs
> -----
>
> src/java/org/apache/sqoop/manager/Db2Manager.java 52ab05ef
> src/java/org/apache/sqoop/manager/GenericJdbcManager.java 2113a5f5
> src/test/org/apache/sqoop/manager/db2/DB2ImportAllTableWithSchemaManual.java PRE-CREATION
>
>
> Diff: https://reviews.apache.org/r/58600/diff/3/
>
>
> Testing
> -------
>
> Mannual UT is passed
>
>
> Thanks,
>
> Ying Cao
>
>