You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@tomcat.apache.org by bu...@apache.org on 2001/09/28 06:24:32 UTC

DO NOT REPLY [Bug 3863] New: - BufferedServletInputStream doesn't buffer

DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG 
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
<http://nagoya.apache.org/bugzilla/show_bug.cgi?id=3863>.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND 
INSERTED IN THE BUG DATABASE.

http://nagoya.apache.org/bugzilla/show_bug.cgi?id=3863

BufferedServletInputStream doesn't buffer

           Summary: BufferedServletInputStream doesn't buffer
           Product: Tomcat 3
           Version: 3.2.3 Final
          Platform: All
        OS/Version: All
            Status: NEW
          Severity: Enhancement
          Priority: Other
         Component: Servlet
        AssignedTo: tomcat-dev@jakarta.apache.org
        ReportedBy: hideo-t@bisd.hitachi.co.jp


I was looking for performance bottlenecks in 3.2.1 and found that the buffering 
in this class was omitted.  It is still omitted in 3.2.3.  The logic is easy 
enough so I added the buffering.  Along with some other tweaks (inhibit 
JSP file modification check per call, calling interceptors that really 
implement callbacks only--an idea found in 3.3--, and using the sentinel 
algorithm for request line parsing), the performance increased quite 
dramatically.  I guess buffering had the greatest impact.

If someone is still maintaining this branch, I think it is well worth the 
effort to implement the buffering.