[jira] [Commented] (DRILL-6696) IOBE in Operator Metric Registry

["ASF GitHub Bot (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/DRILL-6696?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16583920#comment-16583920 ] 

ASF GitHub Bot commented on DRILL-6696:
---------------------------------------

vdiravka commented on a change in pull request #1436: DRILL-6696: IOBE in Operator Metric Registry
URL: https://github.com/apache/drill/pull/1436#discussion_r210902578
 
 

 ##########
 File path: exec/java-exec/src/test/java/org/apache/drill/TestOperatorMetrics.java
 ##########
 @@ -0,0 +1,48 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements.  See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership.  The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License.  You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+package org.apache.drill;
+
+import org.apache.drill.categories.OperatorTest;
+import org.apache.drill.exec.ops.OperatorMetricRegistry;
+import org.apache.drill.exec.proto.UserBitShared;
+import org.apache.drill.test.BaseTestQuery;
+import org.junit.Test;
+import org.junit.experimental.categories.Category;
+
+
+import static org.junit.Assert.assertEquals;
+import static org.junit.Assert.assertNull;
+
+@Category(OperatorTest.class)
+public class TestOperatorMetrics extends BaseTestQuery {
+
+  @Test
+  public void testMetricNames() {
 
 Review comment:
   It makes sense. Done

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


> IOBE in Operator Metric Registry
> --------------------------------
>
>                 Key: DRILL-6696
>                 URL: https://issues.apache.org/jira/browse/DRILL-6696
>             Project: Apache Drill
>          Issue Type: Bug
>    Affects Versions: 1.14.0
>            Reporter: Vitalii Diravka
>            Assignee: Vitalii Diravka
>            Priority: Major
>             Fix For: 1.15.0
>
>
> There is an issue in _{{OperatorMetricRegistry}}_, OPERATOR_METRICS two-dimensional array doesn't check the index of element. If operator type value isn't a number in order - _{{ArrayIndexOutOfBoundsException}}_ will happen.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)