You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@beam.apache.org by GitBox <gi...@apache.org> on 2021/05/11 15:45:38 UTC
[GitHub] [beam] TheNeuralBit commented on a change in pull request #14777: [BEAM-11055] Don't add log4j to library
TheNeuralBit commented on a change in pull request #14777:
URL: https://github.com/apache/beam/pull/14777#discussion_r630299985
##########
File path: sdks/java/io/hadoop-format/build.gradle
##########
@@ -96,7 +96,6 @@ dependencies {
testCompile library.java.hamcrest_library
testCompile library.java.testcontainers_postgresql
testCompile library.java.netty_all
- testRuntimeOnly library.java.log4j_core
Review comment:
It seems adding log4j-api to the library was the root cause of this issue. This forced dependency resolution to go to 2.14.1 for the runtime dependency in GrpcVendoring, which was reflected in any downstream shaded jars (e.g. the SDK harness).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org