You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@harmony.apache.org by "spark shen (JIRA)" <ji...@apache.org> on 2007/11/19 02:49:43 UTC
[jira] Created: (HARMONY-5144) [classlib][ldap] Add scenario test
for ldap service provider
[classlib][ldap] Add scenario test for ldap service provider
------------------------------------------------------------
Key: HARMONY-5144
URL: https://issues.apache.org/jira/browse/HARMONY-5144
Project: Harmony
Issue Type: New Feature
Components: build - test - ci
Reporter: spark shen
Add scenario tests and the required infrastructure. Scenario test is a necessity for guarantee the quality of service provider implementation.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Closed: (HARMONY-5144) [classlib][ldap] Add scenario test
infrastructure for ldap service provider
Posted by "spark shen (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HARMONY-5144?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
spark shen closed HARMONY-5144.
-------------------------------
Stepan, thanks very much for applying the patch!
>>>>>>>>>>>>>>
So I added the support class to BTI at r597650 to make the scenario compile and run.
<<<<<<<<<<<<<<
I think its a much better choice, thanks.
As far as the 'test fail, notification pass' problem, I think that's because I have other ldap JIRAs ongoing in parallel. You may refer to HY 5153.
In that JIRA, the close method is completed.
So, if you update your class library trunk now, and compile it, I think the problem will go away.
Thanks again, for helping me to apply this premature patch.
> [classlib][ldap] Add scenario test infrastructure for ldap service provider
> ---------------------------------------------------------------------------
>
> Key: HARMONY-5144
> URL: https://issues.apache.org/jira/browse/HARMONY-5144
> Project: Harmony
> Issue Type: New Feature
> Components: build - test - ci
> Reporter: spark shen
> Assignee: Stepan Mishura
> Attachments: adaptor.xml, ldap_adaptor.diff, parameters.xml, Support_LdapTest.diff
>
>
> Add the required scenario infrastructure. Scenario test is a necessity for guarantee the quality of service provider implementation.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (HARMONY-5144) [classlib][ldap] Add scenario test
infrastructure for ldap service provider
Posted by "Stepan Mishura (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HARMONY-5144?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12544922 ]
Stepan Mishura commented on HARMONY-5144:
-----------------------------------------
Hi Spark,
I've commited build files for the scneario at r597546.
But I left the JIRA open - I can not complie and run the scenario. Setup target worked fine. But 'run--cc' failed with:
$ ant -Dtest.suites="classlib,drlvm,ldap_scenario" run-cc
<SNIP>
setup:
[echo] ============= Adaptor for ldap_scenario: Set Up ...
[echo] Tested JVM: /export/users/smishura/buildtest/branches/2.0/build/checkouts/drlvm/build/deploy/jdk/jre/bin/java
[mkdir] Created dir: /export/users/smishura/buildtest/branches/2.0/build/results/ldap_scenario/results
[echo] Compiling LDAP scenario tests
[mkdir] Created dir: /export/users/smishura/buildtest/branches/2.0/build/classes/ldap_scenario
[javac] Compiling 1 source file to /export/users/smishura/buildtest/branches/2.0/build/classes/ldap_scenario
[javac] /export/users/smishura/buildtest/branches/2.0/tests/ldap_scenario/src/org/apache/harmony/jndi/provider/ldap/scenario/SchemaApacheDSTest.java:37: package tests.support does not exist
[javac] import tests.support.Support_LdapTest;
[javac] ^
[javac] /export/users/smishura/buildtest/branches/2.0/tests/ldap_scenario/src/org/apache/harmony/jndi/provider/ldap/scenario/SchemaApacheDSTest.java:39: cannot find symbol
[javac] symbol: class Support_LdapTest
[javac] public class SchemaApacheDSTest extends Support_LdapTest {
[javac] ^
[javac] /export/users/smishura/buildtest/branches/2.0/tests/ldap_scenario/src/org/apache/harmony/jndi/provider/ldap/scenario/SchemaApacheDSTest.java:324: cannot find symbol
[javac] symbol : method assertTrue(boolean)
[javac] location: class org.apache.harmony.jndi.provider.ldap.scenario.SchemaApacheDSTest
[javac] assertTrue(ldapSchemaDef.contains(next.getName()));
<SNIP>
I can not find Support_LdapTest class. Also junit.jar should be added. Could you provide the patch to fix scenario automation?
Thanks,
Stepan.
> [classlib][ldap] Add scenario test infrastructure for ldap service provider
> ---------------------------------------------------------------------------
>
> Key: HARMONY-5144
> URL: https://issues.apache.org/jira/browse/HARMONY-5144
> Project: Harmony
> Issue Type: New Feature
> Components: build - test - ci
> Reporter: spark shen
> Assignee: Stepan Mishura
> Attachments: adaptor.xml, parameters.xml
>
>
> Add the required scenario infrastructure. Scenario test is a necessity for guarantee the quality of service provider implementation.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (HARMONY-5144) [classlib][ldap] Add scenario test
infrastructure for ldap service provider
Posted by "spark shen (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HARMONY-5144?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
spark shen updated HARMONY-5144:
--------------------------------
Attachment: (was: adaptor.xml)
> [classlib][ldap] Add scenario test infrastructure for ldap service provider
> ---------------------------------------------------------------------------
>
> Key: HARMONY-5144
> URL: https://issues.apache.org/jira/browse/HARMONY-5144
> Project: Harmony
> Issue Type: New Feature
> Components: build - test - ci
> Reporter: spark shen
> Attachments: parameters.xml
>
>
> Add the required scenario infrastructure. Scenario test is a necessity for guarantee the quality of service provider implementation.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (HARMONY-5144) [classlib][ldap] Add scenario test
infrastructure for ldap service provider
Posted by "spark shen (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HARMONY-5144?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
spark shen updated HARMONY-5144:
--------------------------------
Attachment: adaptor.xml
> [classlib][ldap] Add scenario test infrastructure for ldap service provider
> ---------------------------------------------------------------------------
>
> Key: HARMONY-5144
> URL: https://issues.apache.org/jira/browse/HARMONY-5144
> Project: Harmony
> Issue Type: New Feature
> Components: build - test - ci
> Reporter: spark shen
> Attachments: adaptor.xml, parameters.xml
>
>
> Add the required scenario infrastructure. Scenario test is a necessity for guarantee the quality of service provider implementation.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (HARMONY-5144) [classlib][ldap] Add scenario test
infrastructure for ldap service provider
Posted by "spark shen (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HARMONY-5144?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
spark shen updated HARMONY-5144:
--------------------------------
Description: Add the required scenario infrastructure. Scenario test is a necessity for guarantee the quality of service provider implementation. (was: Add scenario tests and the required infrastructure. Scenario test is a necessity for guarantee the quality of service provider implementation.)
Summary: [classlib][ldap] Add scenario test infrastructure for ldap service provider (was: [classlib][ldap] Add scenario test for ldap service provider)
> [classlib][ldap] Add scenario test infrastructure for ldap service provider
> ---------------------------------------------------------------------------
>
> Key: HARMONY-5144
> URL: https://issues.apache.org/jira/browse/HARMONY-5144
> Project: Harmony
> Issue Type: New Feature
> Components: build - test - ci
> Reporter: spark shen
>
> Add the required scenario infrastructure. Scenario test is a necessity for guarantee the quality of service provider implementation.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (HARMONY-5144) [classlib][ldap] Add scenario test
infrastructure for ldap service provider
Posted by "spark shen (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HARMONY-5144?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12544923 ]
spark shen commented on HARMONY-5144:
-------------------------------------
Thanks, stepan. Sorry for the inconvenience caused. I will upload Support_LdapTest and Junit in a minute.
> [classlib][ldap] Add scenario test infrastructure for ldap service provider
> ---------------------------------------------------------------------------
>
> Key: HARMONY-5144
> URL: https://issues.apache.org/jira/browse/HARMONY-5144
> Project: Harmony
> Issue Type: New Feature
> Components: build - test - ci
> Reporter: spark shen
> Assignee: Stepan Mishura
> Attachments: adaptor.xml, parameters.xml
>
>
> Add the required scenario infrastructure. Scenario test is a necessity for guarantee the quality of service provider implementation.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (HARMONY-5144) [classlib][ldap] Add scenario test
infrastructure for ldap service provider
Posted by "spark shen (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HARMONY-5144?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
spark shen updated HARMONY-5144:
--------------------------------
Attachment: adaptor.xml
> [classlib][ldap] Add scenario test infrastructure for ldap service provider
> ---------------------------------------------------------------------------
>
> Key: HARMONY-5144
> URL: https://issues.apache.org/jira/browse/HARMONY-5144
> Project: Harmony
> Issue Type: New Feature
> Components: build - test - ci
> Reporter: spark shen
> Attachments: adaptor.xml, parameters.xml
>
>
> Add the required scenario infrastructure. Scenario test is a necessity for guarantee the quality of service provider implementation.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (HARMONY-5144) [classlib][ldap] Add scenario test
infrastructure for ldap service provider
Posted by "spark shen (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HARMONY-5144?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
spark shen updated HARMONY-5144:
--------------------------------
Attachment: (was: adaptor.xml)
> [classlib][ldap] Add scenario test infrastructure for ldap service provider
> ---------------------------------------------------------------------------
>
> Key: HARMONY-5144
> URL: https://issues.apache.org/jira/browse/HARMONY-5144
> Project: Harmony
> Issue Type: New Feature
> Components: build - test - ci
> Reporter: spark shen
> Attachments: parameters.xml
>
>
> Add the required scenario infrastructure. Scenario test is a necessity for guarantee the quality of service provider implementation.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (HARMONY-5144) [classlib][ldap] Add scenario test
infrastructure for ldap service provider
Posted by "spark shen (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HARMONY-5144?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
spark shen updated HARMONY-5144:
--------------------------------
Attachment: ldap_adaptor.diff
This patch should be applied at https://svn.apache.org/repos/asf/harmony/enhanced/buildtest/branches/2.0.
> [classlib][ldap] Add scenario test infrastructure for ldap service provider
> ---------------------------------------------------------------------------
>
> Key: HARMONY-5144
> URL: https://issues.apache.org/jira/browse/HARMONY-5144
> Project: Harmony
> Issue Type: New Feature
> Components: build - test - ci
> Reporter: spark shen
> Assignee: Stepan Mishura
> Attachments: adaptor.xml, ldap_adaptor.diff, parameters.xml, Support_LdapTest.diff
>
>
> Add the required scenario infrastructure. Scenario test is a necessity for guarantee the quality of service provider implementation.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (HARMONY-5144) [classlib][ldap] Add scenario test
infrastructure for ldap service provider
Posted by "spark shen (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HARMONY-5144?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
spark shen updated HARMONY-5144:
--------------------------------
Attachment: parameters.xml
> [classlib][ldap] Add scenario test infrastructure for ldap service provider
> ---------------------------------------------------------------------------
>
> Key: HARMONY-5144
> URL: https://issues.apache.org/jira/browse/HARMONY-5144
> Project: Harmony
> Issue Type: New Feature
> Components: build - test - ci
> Reporter: spark shen
> Attachments: adaptor.xml, parameters.xml
>
>
> Add the required scenario infrastructure. Scenario test is a necessity for guarantee the quality of service provider implementation.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Resolved: (HARMONY-5144) [classlib][ldap] Add scenario test
infrastructure for ldap service provider
Posted by "Stepan Mishura (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HARMONY-5144?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Stepan Mishura resolved HARMONY-5144.
-------------------------------------
Resolution: Fixed
Spark, I applied the patch that adds junit.jar to the BTI at r597645.
But if I apply your patch to classlibrary then its build fails with:
compile-support:
[hy.javac] Compiling 1 source file to C:\Apache\Harmony\ClassLib\build\test_support
[hy.javac] ----------
[hy.javac] 1. ERROR in C:\Apache\Harmony\ClassLib\support\src\test\java\tests\support\Support_LdapTest.java
[hy.javac] (at line 30)
[hy.javac] import org.apache.ldap.server.configuration.MutableServerStartupConfiguration;
[hy.javac] ^^^^^^^^^^^^^^^
<SNIP>
So I added the support class to BTI at r597650 to make the scenario compile and run.
See <bti_root>/tests/ldap_scenario/src/tests
IMHO it should be there to avoid tight coupling scenario with classlib. If you disagree please feel free to raise discussion on dev-list
Also I noticed that the scenario failed but I got notification that it passed. Please file a separate JIRA to fix it.
Subject was: [build-test alert] PASSED Linux x86: ldap_scenario
And the log was:
BUILD COMPLETE: build.1
Date of build: 2007-11-23 17:16:45 +0600
Time to build: 15 seconds
***********************************************************
Errors/Warnings: (4)
Test org.apache.harmony.jndi.provider.ldap.scenario.SchemaApacheDSTest FAILED
dir attribute ignored if running in the same VM
dir attribute ignored if running in the same VM
***********************************************************
Unit Tests: (2)
error: test_schema_search_String org.apache.harmony.jndi.provider.ldap.scenario.SchemaApacheDSTest
failure: warning tests.support.Support_LdapTest
Unit Test Error Details: (2)
Test: test_schema_search_StringClass: org.apache.harmony.jndi.provider.ldap.scenario.SchemaApacheDSTestorg.apache.harmony.jndi.provider.ldap.NotYetImplementedException
at org.apache.harmony.jndi.provider.ldap.LdapContextImpl.close(LdapContextImpl.java:784)
at javax.naming.InitialContext.close(InitialContext.java:490)
at org.apache.harmony.jndi.provider.ldap.scenario.SchemaApacheDSTest.tearDown(Unknown Source)
at net.sf.antcontrib.logic.TryCatchTask.execute(TryCatchTask.java:207)
Test: warningClass: tests.support.Support_LdapTestjunit.framework.AssertionFailedError: No tests found in tests.support.Support_LdapTest
at net.sf.antcontrib.logic.TryCatchTask.execute(TryCatchTask.java:207)
Thanks,
Stepan.
> [classlib][ldap] Add scenario test infrastructure for ldap service provider
> ---------------------------------------------------------------------------
>
> Key: HARMONY-5144
> URL: https://issues.apache.org/jira/browse/HARMONY-5144
> Project: Harmony
> Issue Type: New Feature
> Components: build - test - ci
> Reporter: spark shen
> Assignee: Stepan Mishura
> Attachments: adaptor.xml, ldap_adaptor.diff, parameters.xml, Support_LdapTest.diff
>
>
> Add the required scenario infrastructure. Scenario test is a necessity for guarantee the quality of service provider implementation.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Assigned: (HARMONY-5144) [classlib][ldap] Add scenario test
infrastructure for ldap service provider
Posted by "Stepan Mishura (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HARMONY-5144?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Stepan Mishura reassigned HARMONY-5144:
---------------------------------------
Assignee: Stepan Mishura
> [classlib][ldap] Add scenario test infrastructure for ldap service provider
> ---------------------------------------------------------------------------
>
> Key: HARMONY-5144
> URL: https://issues.apache.org/jira/browse/HARMONY-5144
> Project: Harmony
> Issue Type: New Feature
> Components: build - test - ci
> Reporter: spark shen
> Assignee: Stepan Mishura
> Attachments: adaptor.xml, parameters.xml
>
>
> Add the required scenario infrastructure. Scenario test is a necessity for guarantee the quality of service provider implementation.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (HARMONY-5144) [classlib][ldap] Add scenario test
infrastructure for ldap service provider
Posted by "spark shen (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HARMONY-5144?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
spark shen updated HARMONY-5144:
--------------------------------
Attachment: adaptor.xml
> [classlib][ldap] Add scenario test infrastructure for ldap service provider
> ---------------------------------------------------------------------------
>
> Key: HARMONY-5144
> URL: https://issues.apache.org/jira/browse/HARMONY-5144
> Project: Harmony
> Issue Type: New Feature
> Components: build - test - ci
> Reporter: spark shen
> Attachments: adaptor.xml
>
>
> Add the required scenario infrastructure. Scenario test is a necessity for guarantee the quality of service provider implementation.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (HARMONY-5144) [classlib][ldap] Add scenario test
infrastructure for ldap service provider
Posted by "spark shen (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HARMONY-5144?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
spark shen updated HARMONY-5144:
--------------------------------
Attachment: Support_LdapTest.diff
The Support_LdapTest, should be applied at https://svn.apache.org/repos/asf/harmony/enhanced/classlib/trunk/support.
Support module of class library part should be recompiled to ensure Support_LdapTest.class be included.
> [classlib][ldap] Add scenario test infrastructure for ldap service provider
> ---------------------------------------------------------------------------
>
> Key: HARMONY-5144
> URL: https://issues.apache.org/jira/browse/HARMONY-5144
> Project: Harmony
> Issue Type: New Feature
> Components: build - test - ci
> Reporter: spark shen
> Assignee: Stepan Mishura
> Attachments: adaptor.xml, parameters.xml, Support_LdapTest.diff
>
>
> Add the required scenario infrastructure. Scenario test is a necessity for guarantee the quality of service provider implementation.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.