[jira] [Created] (SPARK-23447) Cleanup codegen template for Literal

["Kris Mok (JIRA)" <ji...@apache.org>]

Kris Mok created SPARK-23447:
--------------------------------

             Summary: Cleanup codegen template for Literal
                 Key: SPARK-23447
                 URL: https://issues.apache.org/jira/browse/SPARK-23447
             Project: Spark
          Issue Type: Improvement
          Components: SQL
    Affects Versions: 2.2.1, 2.2.0
            Reporter: Kris Mok


Ideally, the codegen templates for {{Literal}} should emit literals in the {{isNull}} and {{value}} fields of {{ExprCode}} so that they can be effectively inlined into their use sites.
But currently there are a couple of paths where {{Literal.doGenCode()}} return {{ExprCode}} that has non-trivial {{code}} field, and all of those are actually unnecessary.

We can make a simple refactoring to make sure all codegen templates for {{Literal}} return empty {{code}} and simple literal/constant expressions in {{isNull}} and {{value}}.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@spark.apache.org
For additional commands, e-mail: issues-help@spark.apache.org