You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@fineract.apache.org by GitBox <gi...@apache.org> on 2020/07/27 07:31:34 UTC

[GitHub] [fineract] vorburger commented on a change in pull request #1206: FINERACT-838 Added Swagger Codegen Support

vorburger commented on a change in pull request #1206:
URL: https://github.com/apache/fineract/pull/1206#discussion_r460697195



##########
File path: fineract-provider/config/swagger/config.json
##########
@@ -0,0 +1,12 @@
+{
+   "library": "retrofit2",
+   "modelPackage": "org.mifos.models",

Review comment:
       We shouldn't use "org.mifos" for Java package names that are code generated in an Apache project... how about making this e.g. org.apache.fineract.client?




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org