You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2021/06/19 15:33:28 UTC
[GitHub] [airflow] Sanchit112 opened a new issue #16544: Redshift postgres hook usage
Sanchit112 opened a new issue #16544:
URL: https://github.com/apache/airflow/issues/16544
**Description:** While using the Postgres hook for redshift connection, I couldn't find anything on docs if we can do this.
**To do:** Add instructions for using Postgres hook with a redshift connection.
**Are you willing to submit a PR?** Yes
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] josh-fell commented on issue #16544: Redshift postgres hook usage
Posted by GitBox <gi...@apache.org>.
josh-fell commented on issue #16544:
URL: https://github.com/apache/airflow/issues/16544#issuecomment-929793487
To close the loop and make this group aware (for those who aren't already), #18447 has been created to add a `RedshiftSQLHook` and `RedshiftSQLOperator` which captures the functionality described in this issue.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] Sanchit112 commented on issue #16544: Redshift postgres hook usage
Posted by GitBox <gi...@apache.org>.
Sanchit112 commented on issue #16544:
URL: https://github.com/apache/airflow/issues/16544#issuecomment-864740458
Hey, I was thinking of adding a line over [here](https://airflow.apache.org/docs/apache-airflow-providers-postgres/stable/_api/airflow/providers/postgres/hooks/postgres/index.html) that suggests we can use this for redshift connections too, in the class description.
If you have any other idea let me know @turbaszek
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] Sanchit112 commented on issue #16544: Redshift postgres hook usage
Posted by GitBox <gi...@apache.org>.
Sanchit112 commented on issue #16544:
URL: https://github.com/apache/airflow/issues/16544#issuecomment-864865941
Yes, @uranusjr, we can add the SQL note on the **airflow.providers.amazon.aws.hooks.redshift** page and another note in the **Postgres hook** page
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] Sanchit112 commented on issue #16544: Redshift postgres hook usage
Posted by GitBox <gi...@apache.org>.
Sanchit112 commented on issue #16544:
URL: https://github.com/apache/airflow/issues/16544#issuecomment-864865941
Yes, @uranusjr, we can add the SQL note on the **airflow.providers.amazon.aws.hooks.redshift** page and another note in the **Postgres hook** page
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] uranusjr commented on issue #16544: Redshift postgres hook usage
Posted by GitBox <gi...@apache.org>.
uranusjr commented on issue #16544:
URL: https://github.com/apache/airflow/issues/16544#issuecomment-864812061
I feel most Redshift users should end up on `airflow.providers.amazon.aws.hooks.redshift` first, so we should probably also add a note there telling them the SQL commands should use `PostgresHook`?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] boring-cyborg[bot] commented on issue #16544: Redshift postgres hook usage
Posted by GitBox <gi...@apache.org>.
boring-cyborg[bot] commented on issue #16544:
URL: https://github.com/apache/airflow/issues/16544#issuecomment-864421265
Thanks for opening your first issue here! Be sure to follow the issue template!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] uranusjr commented on issue #16544: Redshift postgres hook usage
Posted by GitBox <gi...@apache.org>.
uranusjr commented on issue #16544:
URL: https://github.com/apache/airflow/issues/16544#issuecomment-864812061
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] eladkal commented on issue #16544: Redshift postgres hook usage
Posted by GitBox <gi...@apache.org>.
eladkal commented on issue #16544:
URL: https://github.com/apache/airflow/issues/16544#issuecomment-864888396
> I feel most Redshift users should end up on `airflow.providers.amazon.aws.hooks.redshift` first, so we should probably also add a note there telling them the SQL commands should use `PostgresHook`?
I agree but would like also to raise a thought. Is it a documentation issue or a functionality issue?
Should we have a`RedshiftSqlHook` that just expose all `PostgreSQLHook` methods?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] uranusjr commented on issue #16544: Redshift postgres hook usage
Posted by GitBox <gi...@apache.org>.
uranusjr commented on issue #16544:
URL: https://github.com/apache/airflow/issues/16544#issuecomment-864898263
> specifically should we have a `RedshiftSqlHook`
That’s a good idea as well
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] eladkal commented on issue #16544: Redshift postgres hook usage
Posted by GitBox <gi...@apache.org>.
eladkal commented on issue #16544:
URL: https://github.com/apache/airflow/issues/16544#issuecomment-871884608
@Sanchit112 are you willing to submit PR?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] frankcash edited a comment on issue #16544: Redshift postgres hook usage
Posted by GitBox <gi...@apache.org>.
frankcash edited a comment on issue #16544:
URL: https://github.com/apache/airflow/issues/16544#issuecomment-894504354
I'd be more than happy to grab this. Is it just to create a hook in the AWS provider along the lines of `RedshiftSqlHook` that essentially utilizes the `PostgresHook`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] eladkal commented on issue #16544: Redshift postgres hook usage
Posted by GitBox <gi...@apache.org>.
eladkal commented on issue #16544:
URL: https://github.com/apache/airflow/issues/16544#issuecomment-864888396
> I feel most Redshift users should end up on `airflow.providers.amazon.aws.hooks.redshift` first, so we should probably also add a note there telling them the SQL commands should use `PostgresHook`?
I agree but would like also to raise a thought. Is it a documentation issue or a functionality issue?
Should we have a`RedshiftSqlHook` that just expose all `PostgreSQLHook` methods?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] eladkal edited a comment on issue #16544: Redshift postgres hook usage
Posted by GitBox <gi...@apache.org>.
eladkal edited a comment on issue #16544:
URL: https://github.com/apache/airflow/issues/16544#issuecomment-864888396
> I feel most Redshift users should end up on `airflow.providers.amazon.aws.hooks.redshift` first, so we should probably also add a note there telling them the SQL commands should use `PostgresHook`?
I agree but would like also to raise a thought. Is it a documentation issue or a functionality issue? If users expect to find all relevant hooks/operators in the amazon provider maybe we should consider that? specifically should we have a`RedshiftSqlHook` that just expose all `PostgreSQLHook` methods?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] potiuk commented on issue #16544: Redshift postgres hook usage
Posted by GitBox <gi...@apache.org>.
potiuk commented on issue #16544:
URL: https://github.com/apache/airflow/issues/16544#issuecomment-882052230
Happy to help if you need some :)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] Sanchit112 commented on issue #16544: Redshift postgres hook usage
Posted by GitBox <gi...@apache.org>.
Sanchit112 commented on issue #16544:
URL: https://github.com/apache/airflow/issues/16544#issuecomment-873353056
Hey, I'm willing to submit the PR, but I will need some help from you guys.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] eladkal edited a comment on issue #16544: Redshift postgres hook usage
Posted by GitBox <gi...@apache.org>.
eladkal edited a comment on issue #16544:
URL: https://github.com/apache/airflow/issues/16544#issuecomment-864888396
> I feel most Redshift users should end up on `airflow.providers.amazon.aws.hooks.redshift` first, so we should probably also add a note there telling them the SQL commands should use `PostgresHook`?
I agree but would like also to raise a thought. Is it a documentation issue or a functionality issue? If users expect to find all relevant hooks/operators in the amazon provider maybe we should consider that? specifically should we have a`RedshiftSqlHook` that just expose all `PostgreSQLHook` methods?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] josh-fell commented on issue #16544: Redshift postgres hook usage
Posted by GitBox <gi...@apache.org>.
josh-fell commented on issue #16544:
URL: https://github.com/apache/airflow/issues/16544#issuecomment-929793487
To close the loop and make this group aware (for those who aren't already), #18447 has been created to add a `RedshiftSQLHook` and `RedshiftSQLOperator` which captures the functionality described in this issue.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] potiuk commented on issue #16544: Redshift postgres hook usage
Posted by GitBox <gi...@apache.org>.
potiuk commented on issue #16544:
URL: https://github.com/apache/airflow/issues/16544#issuecomment-877862925
What help do you need @Sanchit112 ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] turbaszek commented on issue #16544: Redshift postgres hook usage
Posted by GitBox <gi...@apache.org>.
turbaszek commented on issue #16544:
URL: https://github.com/apache/airflow/issues/16544#issuecomment-864552856
@Sanchit112 let us know if you would like some help with opening the PR 👌
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] frankcash commented on issue #16544: Redshift postgres hook usage
Posted by GitBox <gi...@apache.org>.
frankcash commented on issue #16544:
URL: https://github.com/apache/airflow/issues/16544#issuecomment-894504354
I'd be more than happy to grab this. Is it just to create a hook in the AWS provider along the lines of `RedshiftSqlHook` that essentially utilizes the PostgresHook
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] potiuk closed issue #16544: Redshift postgres hook usage
Posted by GitBox <gi...@apache.org>.
potiuk closed issue #16544:
URL: https://github.com/apache/airflow/issues/16544
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] JavierLopezT commented on issue #16544: Redshift postgres hook usage
Posted by GitBox <gi...@apache.org>.
JavierLopezT commented on issue #16544:
URL: https://github.com/apache/airflow/issues/16544#issuecomment-868470746
> > I feel most Redshift users should end up on `airflow.providers.amazon.aws.hooks.redshift` first, so we should probably also add a note there telling them the SQL commands should use `PostgresHook`?
>
> specifically should we have a`RedshiftSqlHook` that just expose all `PostgreSQLHook` methods?
I agree with that
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org