Re: [PR] [HUDI-7413] Fix schema exception types and error messages thrown with schema exceptions [hudi]

["yihua (via GitHub)" <gi...@apache.org>]

yihua commented on code in PR #10677:
URL: https://github.com/apache/hudi/pull/10677#discussion_r1508098539


##########
hudi-common/src/main/java/org/apache/hudi/exception/SchemaBackwardsCompatibilityException.java:
##########
@@ -0,0 +1,42 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements.  See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership.  The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License.  You may obtain a copy of the License at
+ *
+ *   http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied.  See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+
+package org.apache.hudi.exception;
+
+import org.apache.hudi.avro.AvroSchemaCompatibility;
+
+import java.util.stream.Collectors;
+
+/**
+ * Thrown when there is a backwards compatibility issue with the incoming schema.
+ * i.e. when the incoming schema cannot be used to read older data files
+ */
+public class SchemaBackwardsCompatibilityException extends SchemaCompatibilityException {

Review Comment:
   In that case, name this as sth like `IncompatibleWriterSchemaOnReadException` to be more specific, to highlight that this is incompatibility between schema and data? Right now by looking at the class name it's hard to tell what this covers.  So either you can make the name more specific, or just use the general `SchemaCompatibilityException` with a util method to generate the exception instance.



##########
hudi-common/src/main/java/org/apache/hudi/exception/SchemaUnbalancedUnionException.java:
##########
@@ -0,0 +1,33 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements.  See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership.  The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License.  You may obtain a copy of the License at
+ *
+ *   http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied.  See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+
+package org.apache.hudi.exception;
+
+/**
+ * Thrown when a field is a union and at least one of the following is true:
+ * <ul>
+ *   <li>the incoming union and the latest table union have differing numbers of types</li>
+ *   <li>the incoming union has more than two types</li>
+ * </ul>
+ */
+public class SchemaUnbalancedUnionException extends SchemaCompatibilityException {

Review Comment:
   Still not sure what `Unbalanced` means in the naming.  Use `Invalid` is better?  Or do we need this specific exception (again going back to the point if you can directly throw `SchemaCompatibilityException` with a specific message)?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org