You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@superset.apache.org by "rusackas (via GitHub)" <gi...@apache.org> on 2026/07/28 04:40:15 UTC
[PR] ci: cache apt packages with awalsh128/cache-apt-pkgs-action [superset]
rusackas opened a new pull request, #42499:
URL: https://github.com/apache/superset/pull/42499
### SUMMARY
Stacked on #42498 (base branch is `ci/setup-uv`, not `master`) -- rebase onto `master` once that merges, at which point this diff will shrink to just the apt-caching change.
`setup-backend` runs `sudo apt-get update && sudo apt-get -y install libldap2-dev libsasl2-dev` unconditionally, on every one of its 17 call sites, on every push. `apt-get update` alone is real per-job network/registry-sync tax that gets paid regardless of whether the package list has ever changed.
[awalsh128/cache-apt-pkgs-action](https://github.com/awalsh128/cache-apt-pkgs-action) caches the resolved `.deb` archives (keyed on the package list + version + architecture) and reinstalls straight from the GitHub Actions cache on a hit, skipping `apt-get update` and the download entirely.
Same shape, same fix, applied to two other one-off `apt-get` installs that had the identical unconditional-update pattern:
- `gettext` in `superset-translations.yml`
- `graphviz` in `superset-docs-deploy.yml`
Didn't touch `setup-docker`'s `docker-compose-plugin` install -- that one adds a whole new apt repository (with a GPG key import) before installing, which doesn't map cleanly onto this action's package-cache model, and felt like a separate, riskier change to bundle in here.
### TESTING INSTRUCTIONS
- `pre-commit run` (`action-validator` via the GHA schema check, `zizmor` GHA security audit) passes on all three touched files.
- CI on this PR exercises `setup-backend` across its call sites -- green CI here is the validation that package installation still behaves identically (just faster on a cache hit).
### ADDITIONAL INFORMATION
- [ ] Has associated issue:
- [ ] Required feature flags:
- [ ] Changes UI
- [ ] Includes DB Migration (follow approval process in [SIP-59](https://github.com/apache/superset/issues/13351))
- [ ] Migration is atomic, supports rollback & is backwards-compatible
- [ ] Confirm DB migration upgrade and downgrade tested
- [ ] Runtime estimates and downtime expectations provided
- [ ] Introduces new feature or API
- [ ] Removes existing feature or API
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
Re: [PR] ci: cache apt packages with awalsh128/cache-apt-pkgs-action [superset]
Posted by "rusackas (via GitHub)" <gi...@apache.org>.
rusackas merged PR #42499:
URL: https://github.com/apache/superset/pull/42499
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
Re: [PR] ci: cache apt packages with awalsh128/cache-apt-pkgs-action [superset]
Posted by "bito-code-review[bot] (via GitHub)" <gi...@apache.org>.
bito-code-review[bot] commented on PR #42499:
URL: https://github.com/apache/superset/pull/42499#issuecomment-5100034986
AI Code Review is in progress (usually takes 3 to 15 minutes unless it's a very large PR).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org