You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2020/06/09 20:23:23 UTC

[GitHub] [airflow] ashb commented on pull request #9195: Update pre-commit-hooks repo version

ashb commented on pull request #9195:
URL: https://github.com/apache/airflow/pull/9195#issuecomment-641549005


   isort seems to be wreaking havok with the UPDATING.md -- we might have to not pick the latest version (or else turn it tune it down):
   
   ```diff
   diff --git a/docs/howto/operator/gcp/gcs_to_gcs.rst b/docs/howto/operator/gcp/gcs_to_gcs.rst
   index e17bedf..bb3fda1 100644
   --- a/docs/howto/operator/gcp/gcs_to_gcs.rst
   +++ b/docs/howto/operator/gcp/gcs_to_gcs.rst
   @@ -40,11 +40,9 @@ perform this task faster and more economically. The economic effects are especia
    Airflow is not hosted in Google Cloud Platform, because these operators reduce egress traffic.
    
    These operators modify source objects if the option that specifies whether objects should be deleted
   -from the source after they are transferred to the sink is enabled.
    
    When you use the Google Cloud Data Transfer service, you can specify whether overwriting objects that already exist in
    the sink is allowed, whether objects that exist only in the sink should be deleted, or whether objects should be deleted
   -from the source after they are transferred to the sink.
    
    Source objects can be specified using include and exclusion prefixes, as well as based on the file
    modification date.
   ```
   
   It seems to think _any_ line starting with `from` is an import line! We need to only have it operate on .py files


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org