[GitHub] [airflow] eladkal commented on a diff in pull request #27784: Allow waiter to be configured via EmrServerless Operators

[GitBox <gi...@apache.org>]

eladkal commented on code in PR #27784:
URL: https://github.com/apache/airflow/pull/27784#discussion_r1039340404


##########
airflow/providers/amazon/aws/operators/emr.py:
##########
@@ -502,6 +503,10 @@ class EmrServerlessCreateApplicationOperator(BaseOperator):
       Its value must be unique for each request.
     :param config: Optional dictionary for arbitrary parameters to the boto API create_application call.
     :param aws_conn_id: AWS connection to use
+    :param waiter_countdown: Total amount of time, in seconds, the operator will wait for
+        the application to start. Defaults to 25 minutes.
+    :param waiter_check_interval_seconds: Number of seconds between polling the state of the application.
+        Defaults to 60 seconds.

Review Comment:
   Wonder about
   ```
   EmrServerlessCreateApplicationOperator(
   ...,
   wait_for_completion=False,
   waiter_countdown=40,
   waiter_check_interval_seconds=70
   )
   ```
   In this case the `waiter_countdown`, `waiter_check_interval_seconds` will not be used.
   I think we should notify the user by log entry that parameters passed are ignored.
   Or we can do the other way around, if user passes `waiter_countdown` or `waiter_check_interval_seconds` we can force `wait_for_completion` to True even if user override this (We have similar case is in BaseOperator with `wait_for_downstream` and `depends_on_past` as far as I remember)



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org