svn commit: r1375114 - /jmeter/trunk/src/protocol/java/org/apache/jmeter/protocol/java/test/JavaTest.java

[se...@apache.org]

Author: sebb
Date: Mon Aug 20 17:24:08 2012
New Revision: 1375114

URL: http://svn.apache.org/viewvc?rev=1375114&view=rev
Log:
Don't check isDebugEnabled unnecessarily, but do check it before building the string param

Modified:
    jmeter/trunk/src/protocol/java/org/apache/jmeter/protocol/java/test/JavaTest.java

Modified: jmeter/trunk/src/protocol/java/org/apache/jmeter/protocol/java/test/JavaTest.java
URL: http://svn.apache.org/viewvc/jmeter/trunk/src/protocol/java/org/apache/jmeter/protocol/java/test/JavaTest.java?rev=1375114&r1=1375113&r2=1375114&view=diff
==============================================================================
--- jmeter/trunk/src/protocol/java/org/apache/jmeter/protocol/java/test/JavaTest.java (original)
+++ jmeter/trunk/src/protocol/java/org/apache/jmeter/protocol/java/test/JavaTest.java Mon Aug 20 17:24:08 2012
@@ -190,8 +190,10 @@ public class JavaTest extends AbstractJa
      */
     @Override
     public void setupTest(JavaSamplerContext context) {
-        getLogger().debug(whoAmI() + "\tsetupTest()");
-        listParameters(context);
+        if (getLogger().isDebugEnabled()) {
+            getLogger().debug(whoAmI() + "\tsetupTest()");
+            listParameters(context);
+        }
     }
 
     /**
@@ -323,23 +325,24 @@ public class JavaTest extends AbstractJa
      */
     @Override
     public void teardownTest(JavaSamplerContext context) {
-        getLogger().debug(whoAmI() + "\tteardownTest()");
-        listParameters(context);
+        if (getLogger().isDebugEnabled()) {
+            getLogger().debug(whoAmI() + "\tteardownTest()");
+            listParameters(context);
+        }
     }
 
     /**
      * Dump a list of the parameters in this context to the debug log.
+     * Should only be called if debug is enabled.
      *
      * @param context
      *            the context which contains the initialization parameters.
      */
     private void listParameters(JavaSamplerContext context) {
-        if (getLogger().isDebugEnabled()) {
-            Iterator<String> argsIt = context.getParameterNamesIterator();
-            while (argsIt.hasNext()) {
-                String name = argsIt.next();
-                getLogger().debug(name + "=" + context.getParameter(name));
-            }
+        Iterator<String> argsIt = context.getParameterNamesIterator();
+        while (argsIt.hasNext()) {
+            String name = argsIt.next();
+            getLogger().debug(name + "=" + context.getParameter(name));
         }
     }