You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@nuttx.apache.org by GitBox <gi...@apache.org> on 2020/10/22 16:43:59 UTC
[GitHub] [incubator-nuttx] daniel-p-carvalho opened a new pull request #2068: STM32L4: Improvements on ADC driver
daniel-p-carvalho opened a new pull request #2068:
URL: https://github.com/apache/incubator-nuttx/pull/2068
## Summary
* Add option to start adc at setup
* Add option to cofigure ADC resolution
* Add option to cofigure ADC sample time
* Add option to cofigure ADC DMA
* Add suport for low level operations.
## Impact
## Testing
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] acassis commented on a change in pull request #2068: STM32L4: Improvements on ADC driver
Posted by GitBox <gi...@apache.org>.
acassis commented on a change in pull request #2068:
URL: https://github.com/apache/incubator-nuttx/pull/2068#discussion_r510364585
##########
File path: arch/arm/src/stm32l4/stm32l4_adc.c
##########
@@ -1,4 +1,4 @@
-/****************************************************************************
+/*****************************************************************************
Review comment:
Please remove the BSD License and replace it with Apache License!
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] daniel-p-carvalho commented on pull request #2068: STM32L4: Improvements on ADC driver
Posted by GitBox <gi...@apache.org>.
daniel-p-carvalho commented on pull request #2068:
URL: https://github.com/apache/incubator-nuttx/pull/2068#issuecomment-714771098
@acassis I don't know what is the problem with defconfig file. It was generated by menuconfig.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] acassis commented on pull request #2068: STM32L4: Improvements on ADC driver
Posted by GitBox <gi...@apache.org>.
acassis commented on pull request #2068:
URL: https://github.com/apache/incubator-nuttx/pull/2068#issuecomment-717271387
It passed now! LGTM
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] acassis commented on pull request #2068: STM32L4: Improvements on ADC driver
Posted by GitBox <gi...@apache.org>.
acassis commented on pull request #2068:
URL: https://github.com/apache/incubator-nuttx/pull/2068#issuecomment-714710040
Hi @daniel-p-carvalho please update your defconfig, it is reporting error
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] davids5 commented on pull request #2068: STM32L4: Improvements on ADC driver
Posted by GitBox <gi...@apache.org>.
davids5 commented on pull request #2068:
URL: https://github.com/apache/incubator-nuttx/pull/2068#issuecomment-716696141
@daniel-p-carvalho - there are new CI failures. Please fix them and force push.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] acassis commented on pull request #2068: STM32L4: Improvements on ADC driver
Posted by GitBox <gi...@apache.org>.
acassis commented on pull request #2068:
URL: https://github.com/apache/incubator-nuttx/pull/2068#issuecomment-716488736
Hi @daniel-p-carvalho it still with BSD license.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] acassis merged pull request #2068: STM32L4: Improvements on ADC driver
Posted by GitBox <gi...@apache.org>.
acassis merged pull request #2068:
URL: https://github.com/apache/incubator-nuttx/pull/2068
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org