[GitHub] [incubator-pinot] npawar commented on issue #4159: Add multiple locks which can be obtained based on segment name in lookupOrCreateFSM

[GitBox <gi...@apache.org>]

npawar commented on issue #4159: Add multiple locks which can be obtained based on segment name in lookupOrCreateFSM
URL: https://github.com/apache/incubator-pinot/pull/4159#issuecomment-486357929
 
 
   > I might be wrong here. Cant parse the indentation properly on phone.
   > 
   > There is possibility that fsm can be null in the end rt? I thought it’s better to lookup the fsmmap in the end.
   
   The idea is to lookup in the fsmMap, and use that if not null. If it is null, then create a new instance of fsm and put it in the map. The fsm cannot be null after the if-else if-else block. Which place are you referring to?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org