You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@commons.apache.org by Marc Paquette <mp...@covansys.com> on 2002/02/13 15:43:07 UTC

[httpclient] patch to build.xml for passing jvmargs (httpclient.test properties)

Many unit tests assume the test webapp is available at 
http://127.0.0.1:80/httpclienttest.  Some (e.g. those that extends 
TestWebappBase) have the necessary provision to take host, port, context 
from system properties.  However, the build target test-local does not 
pass these to the test runner.  Here is a patch that passes the 3 
properties to the test runner.

*** build.xml    6 Oct 2001 01:07:15 -0000    1.9
--- build.xml    13 Feb 2002 14:38:38 -0000
***************
*** 261,266 ****
--- 261,269 ----
        <java classname="${test.runner}" fork="yes" 
failonerror="${test.failonerror}">
          <jvmarg 
value="-Djava.protocol.handler.pkgs=${java.protocol.handler.pkgs}"/>
          <jvmarg value="-Dhttpclient.log=${httpclient.log}"/>
+         <jvmarg 
value="-Dhttpclient.test.localHost=${httpclient.test.localHost}"/>
+         <jvmarg 
value="-Dhttpclient.test.localPort=${httpclient.test.localPort}" />
+         <jvmarg 
value="-Dhttpclient.test.webappContext=${httpclient.test.webappContext}" />
          <arg value="${test-local.entry}"/>
          <classpath refid="test.classpath"/>
        </java>




--
To unsubscribe, e-mail:   <ma...@jakarta.apache.org>
For additional commands, e-mail: <ma...@jakarta.apache.org>


Re: [httpclient] patch to build.xml for passing jvmargs (httpclient.test properties)

Posted by dIon Gillard <di...@multitask.com.au>.
Applied.

Before this patch, three tests failed when running tests-local. The same 
three tests still fail afterward.

Thanks for the patch,

Marc Paquette wrote:

> Many unit tests assume the test webapp is available at 
> http://127.0.0.1:80/httpclienttest.  Some (e.g. those that extends 
> TestWebappBase) have the necessary provision to take host, port, 
> context from system properties.  However, the build target test-local 
> does not pass these to the test runner.  Here is a patch that passes 
> the 3 properties to the test runner.
>
> *** build.xml    6 Oct 2001 01:07:15 -0000    1.9
> --- build.xml    13 Feb 2002 14:38:38 -0000
> ***************
> *** 261,266 ****
> --- 261,269 ----
>        <java classname="${test.runner}" fork="yes" 
> failonerror="${test.failonerror}">
>          <jvmarg 
> value="-Djava.protocol.handler.pkgs=${java.protocol.handler.pkgs}"/>
>          <jvmarg value="-Dhttpclient.log=${httpclient.log}"/>
> +         <jvmarg 
> value="-Dhttpclient.test.localHost=${httpclient.test.localHost}"/>
> +         <jvmarg 
> value="-Dhttpclient.test.localPort=${httpclient.test.localPort}" />
> +         <jvmarg 
> value="-Dhttpclient.test.webappContext=${httpclient.test.webappContext}" 
> />
>          <arg value="${test-local.entry}"/>
>          <classpath refid="test.classpath"/>
>        </java>



-- 
dIon Gillard, Multitask Consulting
http://www.multitask.com.au/developers




--
To unsubscribe, e-mail:   <ma...@jakarta.apache.org>
For additional commands, e-mail: <ma...@jakarta.apache.org>