You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2021/03/23 12:06:39 UTC
[GitHub] [airflow] ecerulm opened a new pull request #14954: Update kubernetes.rst
ecerulm opened a new pull request #14954:
URL: https://github.com/apache/airflow/pull/14954
<!--
Thank you for contributing! Please make sure that your code changes
are covered with tests. And in case of new features or big changes
remember to adjust the documentation.
Feel free to ping committers for the review!
In case of existing issue, reference it using one of the following:
closes: #ISSUE
related: #ISSUE
How to write a good git commit message:
http://chris.beams.io/posts/git-commit/
-->
---
**^ Add meaningful description above**
Read the **[Pull Request Guidelines](https://github.com/apache/airflow/blob/master/CONTRIBUTING.rst#pull-request-guidelines)** for more information.
In case of fundamental code change, Airflow Improvement Proposal ([AIP](https://cwiki.apache.org/confluence/display/AIRFLOW/Airflow+Improvements+Proposals)) is needed.
In case of a new dependency, check compliance with the [ASF 3rd Party License Policy](https://www.apache.org/legal/resolved.html#category-x).
In case of backwards incompatible changes please leave a note in [UPDATING.md](https://github.com/apache/airflow/blob/master/UPDATING.md).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] kaxil commented on pull request #14954: Update kubernetes.rst
Posted by GitBox <gi...@apache.org>.
kaxil commented on pull request #14954:
URL: https://github.com/apache/airflow/pull/14954#issuecomment-809727414
Should be fixed after https://github.com/apache/airflow/pull/15076 is merged and the PR is rebased on master
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] github-actions[bot] commented on pull request #14954: Update kubernetes.rst
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on pull request #14954:
URL: https://github.com/apache/airflow/pull/14954#issuecomment-809140296
[The Workflow run](https://github.com/apache/airflow/actions/runs/696959168) is cancelling this PR. Building images for the PR has failed. Follow the workflow link to check the reason.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] github-actions[bot] commented on pull request #14954: Update kubernetes.rst
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on pull request #14954:
URL: https://github.com/apache/airflow/pull/14954#issuecomment-809962514
[The Workflow run](https://github.com/apache/airflow/actions/runs/700419347) is cancelling this PR. Building images for the PR has failed. Follow the workflow link to check the reason.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] jedcunningham commented on a change in pull request #14954: Update kubernetes.rst
Posted by GitBox <gi...@apache.org>.
jedcunningham commented on a change in pull request #14954:
URL: https://github.com/apache/airflow/pull/14954#discussion_r602634348
##########
File path: docs/apache-airflow-providers-cncf-kubernetes/connections/kubernetes.rst
##########
@@ -20,7 +20,8 @@
Kubernetes cluster Connection
=============================
-The Kubernetes cluster Connection type enables connection to Kubernetes cluster.
+The Kubernetes cluster Connection type enables connection to Kubernetes cluster by SparkOperator only.
+This has nothing to do with KubernetesPodOperator.
Review comment:
```suggestion
The Kubernetes cluster Connection type enables connection to a Kubernetes cluster by ``SparkKubernetesOperator`` tasks. They are not used by ``KubernetesPodOperator`` tasks.
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] mik-laj commented on a change in pull request #14954: Update kubernetes.rst
Posted by GitBox <gi...@apache.org>.
mik-laj commented on a change in pull request #14954:
URL: https://github.com/apache/airflow/pull/14954#discussion_r604524938
##########
File path: docs/apache-airflow-providers-cncf-kubernetes/connections/kubernetes.rst
##########
@@ -20,7 +20,7 @@
Kubernetes cluster Connection
=============================
-The Kubernetes cluster Connection type enables connection to Kubernetes cluster.
+The Kubernetes cluster Connection type enables connection to a Kubernetes cluster by ``SparkKubernetesOperator`` tasks. They are not used by ``KubernetesPodOperator`` tasks.
Review comment:
```suggestion
The Kubernetes cluster Connection type enables connection to a Kubernetes cluster by :class:`~airflow.providers.cncf.kubernetes.operators.spark_kubernetes.SparkKubernetesOperator` tasks. They are not used by ``KubernetesPodOperator`` tasks.
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] kaxil merged pull request #14954: Update kubernetes.rst
Posted by GitBox <gi...@apache.org>.
kaxil merged pull request #14954:
URL: https://github.com/apache/airflow/pull/14954
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org