[GitHub] [helix] NealSun96 commented on a diff in pull request #2357: Enable MSDS auto refresh for DedicatedZkClient

["NealSun96 (via GitHub)" <gi...@apache.org>]

NealSun96 commented on code in PR #2357:
URL: https://github.com/apache/helix/pull/2357#discussion_r1093808509


##########
zookeeper-api/src/main/java/org/apache/helix/zookeeper/routing/RoutingDataManager.java:
##########
@@ -59,6 +61,9 @@ public class RoutingDataManager {
   // Tracks the time at which reset() was called last. Used to throttle reset()
   private volatile long _lastResetTimestamp;
 
+  // Interval value used to throttle reset()
+  private long _routingDataUpdateInterval;
+
   // Singleton instance
   private static RoutingDataManager _instance;

Review Comment:
   I'm curious, why does singleton pattern need volatile again? Once the object is created, the reference will never be changed, right? 



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@helix.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@helix.apache.org
For additional commands, e-mail: reviews-help@helix.apache.org