You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by GitBox <gi...@apache.org> on 2022/07/14 14:33:04 UTC
[GitHub] [arrow-datafusion] andygrove opened a new pull request, #2909: Optimizer should skip failing rules
andygrove opened a new pull request, #2909:
URL: https://github.com/apache/arrow-datafusion/pull/2909
# Which issue does this PR close?
<!--
We generally require a GitHub issue to be filed for all bug fixes and enhancements and this helps us generate change logs for our releases. You can link an issue to this PR using the GitHub syntax. For example `Closes #123` indicates that this PR will close issue #123.
-->
Closes https://github.com/apache/arrow-datafusion/issues/2908
# Rationale for this change
<!--
Why are you proposing this change? If this is already explained clearly in the issue then this section is not needed.
Explaining clearly why changes are proposed helps reviewers understand your changes and offer better suggestions for fixes.
-->
I often see queries fail due to bugs in individual optimizer rules. I would rather just skip the buggy optimizations rather than have the query fail.
# What changes are included in this PR?
<!--
There is no need to duplicate the description in the issue here but it is sometimes worth providing a summary of the individual changes in this PR.
-->
Check result from each rule and skip or fail depending on the configuration.
# Are there any user-facing changes?
<!--
If there are user-facing changes then we may require documentation to be updated before approving the PR.
-->
No
<!--
If there are any breaking changes to public APIs, please add the `api change` label.
-->
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-datafusion] andygrove merged pull request #2909: Optimizer should have option to skip failing rules
Posted by GitBox <gi...@apache.org>.
andygrove merged PR #2909:
URL: https://github.com/apache/arrow-datafusion/pull/2909
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-datafusion] andygrove commented on a diff in pull request #2909: Optimizer should skip failing rules
Posted by GitBox <gi...@apache.org>.
andygrove commented on code in PR #2909:
URL: https://github.com/apache/arrow-datafusion/pull/2909#discussion_r921346443
##########
datafusion/optimizer/src/optimizer.rs:
##########
@@ -97,13 +106,85 @@ impl Optimizer {
debug!("Input logical plan:\n{}\n", plan.display_indent());
trace!("Full input logical plan:\n{:?}", plan);
for rule in &self.rules {
- new_plan = rule.optimize(&new_plan, optimizer_config)?;
- observer(&new_plan, rule.as_ref());
- debug!("After apply {} rule:\n", rule.name());
- debug!("Optimized logical plan:\n{}\n", new_plan.display_indent());
+ let result = rule.optimize(&new_plan, optimizer_config);
+ match result {
+ Ok(plan) => {
+ new_plan = plan;
+ observer(&new_plan, rule.as_ref());
+ debug!("After apply {} rule:\n", rule.name());
+ debug!("Optimized logical plan:\n{}\n", new_plan.display_indent());
+ }
+ Err(ref e) => {
+ if optimizer_config.skip_failing_rules {
Review Comment:
This is the main change here - we now have the option to ignore optimization rules that fail
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-datafusion] ursabot commented on pull request #2909: Optimizer should have option to skip failing rules
Posted by GitBox <gi...@apache.org>.
ursabot commented on PR #2909:
URL: https://github.com/apache/arrow-datafusion/pull/2909#issuecomment-1184854174
Benchmark runs are scheduled for baseline = 034678b67a154c3ece2b34b687e151ca0c5cfa5e and contender = 8ad3df54f54acd801d81485d7bb9678bf4727e7c. 8ad3df54f54acd801d81485d7bb9678bf4727e7c is a master commit associated with this PR. Results will be available as each benchmark for each run completes.
Conbench compare runs links:
[Skipped :warning: Benchmarking of arrow-datafusion-commits is not supported on ec2-t3-xlarge-us-east-2] [ec2-t3-xlarge-us-east-2](https://conbench.ursa.dev/compare/runs/c6cf27de49da4c1c9f4f6bcf51cd6cf5...e8a8f11ce60c4ba8b0a3f1573dab87b6/)
[Skipped :warning: Benchmarking of arrow-datafusion-commits is not supported on test-mac-arm] [test-mac-arm](https://conbench.ursa.dev/compare/runs/e04df079186049f1a49b28a62ddfdfda...154a56d6bed248398e7f864bc453cf59/)
[Skipped :warning: Benchmarking of arrow-datafusion-commits is not supported on ursa-i9-9960x] [ursa-i9-9960x](https://conbench.ursa.dev/compare/runs/55491cf01ed44d5eb5f33559f400dda9...3e87a1edaf414a0c83fc9a82f176a46c/)
[Skipped :warning: Benchmarking of arrow-datafusion-commits is not supported on ursa-thinkcentre-m75q] [ursa-thinkcentre-m75q](https://conbench.ursa.dev/compare/runs/da1c2b5c52a9463181b14cdce042d04d...8788f5bcdfdc43be9fe2573807cb50f4/)
Buildkite builds:
Supported benchmarks:
ec2-t3-xlarge-us-east-2: Supported benchmark langs: Python, R. Runs only benchmarks with cloud = True
test-mac-arm: Supported benchmark langs: C++, Python, R
ursa-i9-9960x: Supported benchmark langs: Python, R, JavaScript
ursa-thinkcentre-m75q: Supported benchmark langs: C++, Java
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-datafusion] codecov-commenter commented on pull request #2909: Optimizer should skip failing rules
Posted by GitBox <gi...@apache.org>.
codecov-commenter commented on PR #2909:
URL: https://github.com/apache/arrow-datafusion/pull/2909#issuecomment-1184618736
# [Codecov](https://codecov.io/gh/apache/arrow-datafusion/pull/2909?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#2909](https://codecov.io/gh/apache/arrow-datafusion/pull/2909?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (8f0c3e4) into [master](https://codecov.io/gh/apache/arrow-datafusion/commit/9401d6d80bfdd4e02869f7722efdd02a733de272?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (9401d6d) will **increase** coverage by `0.01%`.
> The diff coverage is `96.11%`.
```diff
@@ Coverage Diff @@
## master #2909 +/- ##
==========================================
+ Coverage 85.29% 85.31% +0.01%
==========================================
Files 274 274
Lines 49229 49266 +37
==========================================
+ Hits 41991 42029 +38
+ Misses 7238 7237 -1
```
| [Impacted Files](https://codecov.io/gh/apache/arrow-datafusion/pull/2909?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [datafusion/optimizer/src/optimizer.rs](https://codecov.io/gh/apache/arrow-datafusion/pull/2909/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZGF0YWZ1c2lvbi9vcHRpbWl6ZXIvc3JjL29wdGltaXplci5ycw==) | `82.69% <88.88%> (+7.69%)` | :arrow_up: |
| [datafusion/expr/src/logical\_plan/builder.rs](https://codecov.io/gh/apache/arrow-datafusion/pull/2909/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZGF0YWZ1c2lvbi9leHByL3NyYy9sb2dpY2FsX3BsYW4vYnVpbGRlci5ycw==) | `89.64% <100.00%> (-0.22%)` | :arrow_down: |
| [datafusion/expr/src/logical\_plan/plan.rs](https://codecov.io/gh/apache/arrow-datafusion/pull/2909/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZGF0YWZ1c2lvbi9leHByL3NyYy9sb2dpY2FsX3BsYW4vcGxhbi5ycw==) | `77.32% <100.00%> (+1.29%)` | :arrow_up: |
| [datafusion/expr/src/utils.rs](https://codecov.io/gh/apache/arrow-datafusion/pull/2909/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZGF0YWZ1c2lvbi9leHByL3NyYy91dGlscy5ycw==) | `90.76% <100.00%> (ø)` | |
| [...tafusion/optimizer/src/common\_subexpr\_eliminate.rs](https://codecov.io/gh/apache/arrow-datafusion/pull/2909/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZGF0YWZ1c2lvbi9vcHRpbWl6ZXIvc3JjL2NvbW1vbl9zdWJleHByX2VsaW1pbmF0ZS5ycw==) | `94.11% <100.00%> (ø)` | |
| [datafusion/optimizer/src/limit\_push\_down.rs](https://codecov.io/gh/apache/arrow-datafusion/pull/2909/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZGF0YWZ1c2lvbi9vcHRpbWl6ZXIvc3JjL2xpbWl0X3B1c2hfZG93bi5ycw==) | `99.67% <100.00%> (ø)` | |
| [datafusion/optimizer/src/projection\_push\_down.rs](https://codecov.io/gh/apache/arrow-datafusion/pull/2909/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZGF0YWZ1c2lvbi9vcHRpbWl6ZXIvc3JjL3Byb2plY3Rpb25fcHVzaF9kb3duLnJz) | `98.06% <100.00%> (-0.03%)` | :arrow_down: |
| [...fusion/optimizer/src/single\_distinct\_to\_groupby.rs](https://codecov.io/gh/apache/arrow-datafusion/pull/2909/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZGF0YWZ1c2lvbi9vcHRpbWl6ZXIvc3JjL3NpbmdsZV9kaXN0aW5jdF90b19ncm91cGJ5LnJz) | `98.81% <100.00%> (ø)` | |
| [datafusion/expr/src/window\_frame.rs](https://codecov.io/gh/apache/arrow-datafusion/pull/2909/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZGF0YWZ1c2lvbi9leHByL3NyYy93aW5kb3dfZnJhbWUucnM=) | `93.27% <0.00%> (+0.84%)` | :arrow_up: |
| ... and [1 more](https://codecov.io/gh/apache/arrow-datafusion/pull/2909/diff?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/arrow-datafusion/pull/2909?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/arrow-datafusion/pull/2909?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [9401d6d...8f0c3e4](https://codecov.io/gh/apache/arrow-datafusion/pull/2909?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-datafusion] jdye64 commented on a diff in pull request #2909: Optimizer should skip failing rules
Posted by GitBox <gi...@apache.org>.
jdye64 commented on code in PR #2909:
URL: https://github.com/apache/arrow-datafusion/pull/2909#discussion_r921417500
##########
datafusion/core/src/config.rs:
##########
@@ -43,6 +43,10 @@ pub const OPT_COALESCE_BATCHES: &str = "datafusion.execution.coalesce_batches";
pub const OPT_COALESCE_TARGET_BATCH_SIZE: &str =
"datafusion.execution.coalesce_target_batch_size";
+/// Configuration option "datafusion.optimizer.skip_failed_rules"
Review Comment:
Yeah I love this too! There are a few places I would want our product to fail in case of an error here but others I would not. so the configuration is great
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-datafusion] andygrove commented on pull request #2909: Optimizer should skip failing rules
Posted by GitBox <gi...@apache.org>.
andygrove commented on PR #2909:
URL: https://github.com/apache/arrow-datafusion/pull/2909#issuecomment-1184647367
@jdye64 This is part 2 of the index out of bounds fix
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-datafusion] andygrove commented on pull request #2909: Optimizer should skip failing rules
Posted by GitBox <gi...@apache.org>.
andygrove commented on PR #2909:
URL: https://github.com/apache/arrow-datafusion/pull/2909#issuecomment-1184681492
@alamb Thanks for the review on https://github.com/apache/arrow-datafusion/pull/2900 ... this is the follow-on that leverages those new error checks and allows the optimizer to gracefully handle such failures
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-datafusion] alamb commented on a diff in pull request #2909: Optimizer should skip failing rules
Posted by GitBox <gi...@apache.org>.
alamb commented on code in PR #2909:
URL: https://github.com/apache/arrow-datafusion/pull/2909#discussion_r921411558
##########
datafusion/optimizer/src/optimizer.rs:
##########
@@ -97,13 +106,85 @@ impl Optimizer {
debug!("Input logical plan:\n{}\n", plan.display_indent());
trace!("Full input logical plan:\n{:?}", plan);
for rule in &self.rules {
- new_plan = rule.optimize(&new_plan, optimizer_config)?;
- observer(&new_plan, rule.as_ref());
- debug!("After apply {} rule:\n", rule.name());
- debug!("Optimized logical plan:\n{}\n", new_plan.display_indent());
+ let result = rule.optimize(&new_plan, optimizer_config);
+ match result {
+ Ok(plan) => {
+ new_plan = plan;
+ observer(&new_plan, rule.as_ref());
+ debug!("After apply {} rule:\n", rule.name());
+ debug!("Optimized logical plan:\n{}\n", new_plan.display_indent());
+ }
+ Err(ref e) => {
+ if optimizer_config.skip_failing_rules {
+ error!(
Review Comment:
```suggestion
warn!(
```
A warning might be a more appropriate level (as the query will likely succeed but it is serious enough to warrant investigation)
##########
datafusion/core/src/config.rs:
##########
@@ -43,6 +43,10 @@ pub const OPT_COALESCE_BATCHES: &str = "datafusion.execution.coalesce_batches";
pub const OPT_COALESCE_TARGET_BATCH_SIZE: &str =
"datafusion.execution.coalesce_target_batch_size";
+/// Configuration option "datafusion.optimizer.skip_failed_rules"
Review Comment:
💯 for it being a config setting
##########
datafusion/optimizer/src/optimizer.rs:
##########
@@ -97,13 +106,85 @@ impl Optimizer {
debug!("Input logical plan:\n{}\n", plan.display_indent());
trace!("Full input logical plan:\n{:?}", plan);
for rule in &self.rules {
- new_plan = rule.optimize(&new_plan, optimizer_config)?;
- observer(&new_plan, rule.as_ref());
- debug!("After apply {} rule:\n", rule.name());
- debug!("Optimized logical plan:\n{}\n", new_plan.display_indent());
+ let result = rule.optimize(&new_plan, optimizer_config);
+ match result {
+ Ok(plan) => {
+ new_plan = plan;
+ observer(&new_plan, rule.as_ref());
+ debug!("After apply {} rule:\n", rule.name());
+ debug!("Optimized logical plan:\n{}\n", new_plan.display_indent());
+ }
+ Err(ref e) => {
+ if optimizer_config.skip_failing_rules {
Review Comment:
```suggestion
if optimizer_config.skip_failing_rules {
// Note to future readers: if you see this warning it signals a
// bug in the DataFusion optimizer. Please consider filing a ticket
// https://github.com/apache/arrow-datafusion
```
I think it might be good to tell anyone who sees this error that it is not expected and that it means there is a bug somewhere in datafusion
##########
datafusion/optimizer/src/optimizer.rs:
##########
@@ -97,13 +106,85 @@ impl Optimizer {
debug!("Input logical plan:\n{}\n", plan.display_indent());
trace!("Full input logical plan:\n{:?}", plan);
for rule in &self.rules {
- new_plan = rule.optimize(&new_plan, optimizer_config)?;
- observer(&new_plan, rule.as_ref());
- debug!("After apply {} rule:\n", rule.name());
- debug!("Optimized logical plan:\n{}\n", new_plan.display_indent());
+ let result = rule.optimize(&new_plan, optimizer_config);
+ match result {
+ Ok(plan) => {
+ new_plan = plan;
+ observer(&new_plan, rule.as_ref());
+ debug!("After apply {} rule:\n", rule.name());
+ debug!("Optimized logical plan:\n{}\n", new_plan.display_indent());
+ }
+ Err(ref e) => {
+ if optimizer_config.skip_failing_rules {
+ error!(
+ "Skipping optimizer rule {} due to error: {}",
Review Comment:
```suggestion
"Skipping optimizer rule {} due to unexpected error: {}",
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org